From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CDDC021BB for ; Tue, 25 Feb 2025 13:50:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C0D76B0089; Tue, 25 Feb 2025 08:50:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3710C6B008A; Tue, 25 Feb 2025 08:50:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25F436B008C; Tue, 25 Feb 2025 08:50:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 098106B0089 for ; Tue, 25 Feb 2025 08:50:18 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A46001A158D for ; Tue, 25 Feb 2025 13:50:17 +0000 (UTC) X-FDA: 83158601274.16.B4AB380 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf25.hostedemail.com (Postfix) with ESMTP id A9465A0017 for ; Tue, 25 Feb 2025 13:50:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Kh/Mm2iy"; spf=pass (imf25.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740491415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=flQTZ/IAOp+GXiZB2aYc0mgVQNYYPMmryd0DJ0XOL+c=; b=zoyLOomRo/UrpfuZlyqdRz6xusErCOI44tQmsAaFVo1Z/C+u6p4UnAvoUFDyrYqgjfR7Vv vpW0ytSulnKWNgh/sx8r6rtEEuahxpg4f+jvvrcmUJSiVXERs0DHCYz+YzLCRVYQDhZXc3 KWExZDtH8QDdSFmgfA89sdpMFr8CD1I= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Kh/Mm2iy"; spf=pass (imf25.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740491415; a=rsa-sha256; cv=none; b=AVtsUSkIGbDhm5QKEqvtCyqOMBr3mGmah0GYkfLkH60fobDrjSx+rtsOPxd2LgEddG0zeS 87KMuSHyLzL6ct98d8ff7xUQ1hWZt/etXJ4+l2Dme1PyATLXa2JngrHVWVt7BQZlWjc2zD HRS+qZyoYe1mTeQLUK7tYNMcslmz+n4= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43a9e6cd0b4so42675e9.1 for ; Tue, 25 Feb 2025 05:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740491414; x=1741096214; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=flQTZ/IAOp+GXiZB2aYc0mgVQNYYPMmryd0DJ0XOL+c=; b=Kh/Mm2iy9SYpqqTC/pOtoi4vlLjekp1Mm5YggT1fnCna8NsmEP3mUKejAZpEFsbK9M YxWrjKMVZOLKnGa4BdjyMEouoeJG7NW6PukZff/qGZqrJC1LQhyFVTayNwce36+bNndL W8AkxqTn+ydVdHJP/fpidKdHLYsbTlQ6x0ybBs2FLrUK5rYv3gGsqAjC/ZvSec0Agmwk ZLBEK2zaPQ1loyGxGKGBHMM55b9o2lgB6NDgar7Oo4FIVprwgDnsxms70qX56KMmNkRI UXVLml0ZZyPgm03YjVlBlQB1h7o9EU4Wc/RhypCfDYNma29c6y/J2ueUBirzn6xiF6Xt pE2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740491414; x=1741096214; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=flQTZ/IAOp+GXiZB2aYc0mgVQNYYPMmryd0DJ0XOL+c=; b=L9PF/8byOdhUvt0ijBjcIeK1SrxhmsKbRYIu9UDMMv4LZhrwgsBbn86cJ4jfStUW4P JR2l95bezD95WU8C8CNo70XJFFMHfKteRSIO86y8wFnAc3zjFwr+n69QS7KbzjeziTU1 znm4CIOwG3ULyWvknjNfC3oGOnaeG7GQf15q36ym8xJsS7MnkcFNHP4YX8MoxNRKlX6Y VrPA8nLWE3qG06gevLy3IBzi36nmICdGfWf5ygIh5WiCDep7ClOaYIj0URVQa5znfkjV yaHOh29xWQbFvpnxYZOPR+k7M+i6kROrrGSCRIU3YSEFesyjz881xpXyH29eDyANyGuF v95w== X-Forwarded-Encrypted: i=1; AJvYcCXl7zuoS8t2zYRHK2UivlHuY4Ifw/O+pWopWftEQZYbzqQGaE2JnSTmo+scvliwu0fZ0R7G/NQCGA==@kvack.org X-Gm-Message-State: AOJu0Yyo8XRsJcUBJFs1N1Jb3qTE/cFmHIyUFCR6x7HwDNN95bRWOQ5M OqbcKYqUB/zVUy6JW1ne59Tvuj1L4mevjexdMqlnyOgqCyxhRv5gd9KAO0eNpw== X-Gm-Gg: ASbGnctKMSVMTUTCJ7/0n/CPCUXK3I8CvTXNJBzUjXvV0u8lYg3nH6b2bayo3cG9I21 F9x/iyWzNwKdobDM3t2eZWhQwtiQv9jfUDW9TvO6SZHprlKzYZGRrnEVkkYZT4yk+9wNd2RPktF ssilUaD4bqir+kB8IufUtUYQstT8/AccpCKCBDg0Gm34wBdYjxlmAb1268HL4TZIU5UeRBt0mQz k33xLp2ehl5AFL23iq43G6VsHKwAJbnVdERi8qYayrpxjmSqEuvZ3I9IeKC2A8dqr/4WFF1CQag qJkx/eB0mrQbnjNNSlaDtqByaX46h5XxJHEWVKAD2iGLnH41zaFswKcfJaYAdA== X-Google-Smtp-Source: AGHT+IEVNqBoimy0tPc+jYLAvU92qKQ9P0Hox3Z1GFrcZRjdTqreOTBPA7teWDprvJFrjRs+a6mDNw== X-Received: by 2002:a05:600c:920:b0:439:6017:6687 with SMTP id 5b1f17b1804b1-43ab10495c5mr1353355e9.7.1740491414136; Tue, 25 Feb 2025 05:50:14 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd8fbcabsm2312660f8f.86.2025.02.25.05.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 05:50:13 -0800 (PST) Date: Tue, 25 Feb 2025 13:50:09 +0000 From: Brendan Jackman To: Johannes Weiner Cc: Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: page_alloc: group fallback functions together Message-ID: References: <20250225001023.1494422-1-hannes@cmpxchg.org> <20250225001023.1494422-4-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250225001023.1494422-4-hannes@cmpxchg.org> X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A9465A0017 X-Stat-Signature: o6anmbptgbb6du6xqaaf9uexxigy1g33 X-HE-Tag: 1740491415-431248 X-HE-Meta: U2FsdGVkX1+SA0JURX92P/7wmIyLf1TF7qf3V6qJ+JFVK7VlEIIP4ayTOE6xc1sded48e1zEfEtb3HxU36jqaDsVDui9n6Asx5EP6yzw/SiRz7xQGD+yOzln5pScJli2rEpgBu66EDhm70h8UCu/5fCZmwKTAEf5umNFdnB5uwiQBWhzG5ZFrTyZkFOyY0aGnyntiuiV+auVYwMdYxK844EOl9BFTolf9oKLbCHUgC7LgkYik+J0KDaGrpHl+KavsZQiXuJH6tEK41pDaM8Egx1icM0noJXfA773X9+pI6D4xP2YOFz0KHP/m4urde6Alj7QYZrOKzWFw2x65KS/a9tIg6LqEZlphQAFGGHQ3MiUGSFGeoOnZc2aynWo5WfLgWZgWV0f8huy5KCczsZC0d9mOyh25e6+BY22/bfIxPtVtiLP5Ee2BJrj4tHCgNI5fITeli4gqe9Dd8RA+Z83NhBvwv/XCrOqnB9848yIqwB4jkUGX40RQ7BL3GicyGyzoodEPgP6EGuVXgocZ499A2vvZiCysa4mpIhhJe6YMcXKSHiaxfmUS0yllHwHcA8QWXbFlL+c78zVaNY4DEQSpXsAEiHQcy+naY2CQZ69xU3uN177m270aCjN4jcRCmf6KeMaTPHTUyMFBplpa7PBtUR8zhuY/J1nYnNUoab5H2G8Xsy8+tjI+bMCJU0ZaItCgBUtDav+e04H5pyrZyTUXJB8niJZSY/vBN9vBmJtxFhA+FOPIbxtnN9wI3sxoJJnRu2DRAWAsMwxmbSx9fUwFvorvjv3yHLJ/1Fr46JHai/LlsMi2srTQ+EeIH5OtZT9/LydxhSYa6CNNwndbSyfME1TDnzSVWx3Hs7kJMpEOSPVHGfVBRp03O3+bnQIrqb6NQ39eR90FNlThbE5JLtJY64GXtb+O0qJNI2vo52VOndzMiqFauimuSbKKto78eQMYp1CvFvqSzGxArW7Rbj 14orrDOG uQRd5z7kWKifQ1gE/3YnBte2BMOAHXGNgzeY8I2WP2AAgYmJZAMRHo4EJFABU2j5uJgMQyCMs+JUWNuLurYQyyi4pYUnhJWObY1uAdC/etPHvfiTW7vZaDRodcmeb4eH3j77dVCCzOtu6M5JRUojw9ZTVjhUPmCkHqOXh4XQ+yAnIKAa1JxwD6yMJyEx+gd8VAT6XYnrNzN9DkNe3FXAN47vHQ4uEzzg2xVuoXdE43Xrs0SUcQSaALz/qbQ/ATLF3CzlYSthsERyW+jeyb/ZbQvZdsomEXfNdVXK5sjOJgOseRkKVEkyz5fQYKlhK3UdjmvBiFyZaEn908OjVrn2RylJ6oZpYB/0x8Y4x/m0jpnEqaJVN0IxTskddrfVGJLhwaBw/cJMPll2LyAwo+Ki8KYYHhXMcRdTCPHIg2q+qjiJo+kwZ68WBea60WwCjjW2pSbpRNV1PEkC5lTs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002080, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 07:08:26PM -0500, Johannes Weiner wrote: > The way the fallback rules are spread out makes them hard to > follow. Move the functions next to each other at least. > > Signed-off-by: Johannes Weiner Moving code makes blame more tiresome so I wouldn't personally do this, but if others find it helpful it's fine by me. Reviewed-by: Brendan Jackman ("Reviewed" means "git tells me there are no new lines nor totally deleted lines").