From: Brendan Jackman <jackmanb@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: page_alloc: group fallback functions together
Date: Tue, 25 Feb 2025 13:50:09 +0000 [thread overview]
Message-ID: <Z73KkRTWfu-9CBIm@google.com> (raw)
In-Reply-To: <20250225001023.1494422-4-hannes@cmpxchg.org>
On Mon, Feb 24, 2025 at 07:08:26PM -0500, Johannes Weiner wrote:
> The way the fallback rules are spread out makes them hard to
> follow. Move the functions next to each other at least.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Moving code makes blame more tiresome so I wouldn't personally do
this, but if others find it helpful it's fine by me.
Reviewed-by: Brendan Jackman <jackmanb@google.com>
("Reviewed" means "git tells me there are no new lines nor totally
deleted lines").
next prev parent reply other threads:[~2025-02-25 13:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 0:08 [PATCH 0/3] mm: page_alloc: freelist hygiene follow-up Johannes Weiner
2025-02-25 0:08 ` [PATCH 1/3] mm: page_alloc: don't steal single pages from biggest buddy Johannes Weiner
2025-02-25 10:50 ` Vlastimil Babka
2025-02-25 13:34 ` Brendan Jackman
2025-02-25 14:35 ` Vlastimil Babka
2025-02-25 14:40 ` Brendan Jackman
2025-02-25 15:04 ` Johannes Weiner
2025-02-25 0:08 ` [PATCH 2/3] mm: page_alloc: remove remnants of unlocked migratetype updates Johannes Weiner
2025-02-25 11:01 ` Vlastimil Babka
2025-02-25 13:43 ` Brendan Jackman
2025-02-25 15:09 ` Johannes Weiner
2025-02-25 15:19 ` Brendan Jackman
2025-02-25 0:08 ` [PATCH 3/3] mm: page_alloc: group fallback functions together Johannes Weiner
2025-02-25 11:02 ` Vlastimil Babka
2025-02-26 8:51 ` Vlastimil Babka
2025-02-25 13:50 ` Brendan Jackman [this message]
2025-02-25 15:14 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z73KkRTWfu-9CBIm@google.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox