From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39D1C021B2 for ; Tue, 25 Feb 2025 07:41:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CE1A6B007B; Tue, 25 Feb 2025 02:41:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27E4F6B0082; Tue, 25 Feb 2025 02:41:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 145B36B0085; Tue, 25 Feb 2025 02:41:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EBDA36B007B for ; Tue, 25 Feb 2025 02:40:59 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A18631A0D49 for ; Tue, 25 Feb 2025 07:40:59 +0000 (UTC) X-FDA: 83157670638.08.15C6FEC Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf20.hostedemail.com (Postfix) with ESMTP id 17D701C0018 for ; Tue, 25 Feb 2025 07:40:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DyCwUZXi; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740469258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QME+3JDwrUqrq8SilTHOaPJhJ/ckQHJayAqZ27tvt/Y=; b=ZyNBErxDgpRtlyMIX2/yJCTVmINS24ODCh8WbtReju8obzGZF7+uDxxO8IlLVz3M6bD4Rp JMq22zLaF/Uh49l0j1GwmX7tcbCsEd/5vscxBVRLczKMu0bcEK+4TvcRS0A1W4301lhBM5 +V7RftUxWYDe2ckptjHEoSdKWHTJNRQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DyCwUZXi; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740469258; a=rsa-sha256; cv=none; b=i0ldwVn10naIMLYj8Bm3Piu+A/EW/aPzU2G2zaLUrAfdr/3xOhavjv8KxeF8tETPbClFaF fWH4IdSg/YCv1vAwEoNDgPjhuVe118smsJN/LwA87gD69uer/SypCNPVd3zCUYWCFVZfQN veyf9MmojlOAjBrZb52JNZtsskvqORM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B2ADD61228; Tue, 25 Feb 2025 07:40:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E466FC4CEDD; Tue, 25 Feb 2025 07:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740469256; bh=ieVX5d6YbG4CbbEuq39MSmzMjPRvSdy5tV/uQ7x4Blc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DyCwUZXionE7MxaCDSn4U72FlesRhQrFrGpuMkiOxiKqybMwty65HMnnUQtV0dWsq x7yf1ePenepDvJ7E87xmvqClkzk8+fAfDEKxnIAi7R5KdEWrq/HbBGK6/m824N9Aac l/wqdDYxYnTxZuXavRvIjBWLEcQoGK0tFSLRdgKP4cC/B9wTs4vNJBGhVFg/YUZjBa DyGpLBRzZb6r41IoQvdNrSFndL/1MSZxBxXbqTMC8G/XX8sPECLY2vNOeYn9agTBnv XprvoyMTyo3iA3MRoUHy8tQHkZD1ybG+SlCOHiI+8kBb9UqYcJF8jATpbmYw4ARQPa aHoMQW26rsx9w== Date: Tue, 25 Feb 2025 09:40:37 +0200 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 01/14] mm/mm_init: rename init_reserved_page to init_deferred_page Message-ID: References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-2-rppt@kernel.org> <20250218145904.x57chhz3whvckzu3@master> <20250220083601.4p6ehmfhyvs5q5io@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250220083601.4p6ehmfhyvs5q5io@master> X-Rspam-User: X-Stat-Signature: jmk94c954jfun44sngq7xc7z4zeuc3ub X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 17D701C0018 X-HE-Tag: 1740469257-731730 X-HE-Meta: U2FsdGVkX1/4tfGprHWHkW1L01LU8i7KXosbtV38Unlmd0q+KezAdfTIM5DFTS6JIN3D9uWxK6L1l2KKrkeuZJBX0oWOSbRUm4P29jEbViS1Srcx+zNmC2qKZ0kuPdJLByK7lnOtC2vI7QeyemecoQzFPMqxllwVhXDKaCzGTR0Nu7MGiOfEJRNEnHaJ14aaTrsWZ3HO+WWZbph8WPUicIdWgpAmqFxzcReq3WGHUdeSmjoXwy1Os0lIWUC7cSrTSYrHE2pauNKGGfdKP7MMHNbPVA7Bwq/Aq+mozyG1rxGCNkt2+JvsleyPufd9pcRQn3n7vYj7lKBO3TEH8RS4k2e3q3pevjLQCTq5//NKKVXsjmCO1EO48kZ4UyecpGDCt1m5LMPYmdi0dfXB8jI/wLa1hPYe3pPr2Bp8QNYFrGgdACQv0ChOUSm0uZVRO1vBJpA6aFpDdZ7CkPrLxiYYdzQDIFdXAug8Db6bAMyMkt3Z1Fpb7QMAqJv+k6RPTNHpRUIeMiRs+H62rxaBq2VWilgWZUWQt22jvLqlHaqVQGTzL5JauUnYM343HbfFUnBJ29KbSagZbdR3B9aiQr5UDokyHBu3pul1zH2TiUnA2QEMNlkJA+GFdH1tgJzxUI3Lx85DKOO4kQOeacN+38HLo71Fcmi25/cyupQpdCzQLR8D46ydMJY9RYQczwZEEqSkhilHL+BIe97fHFJADPNsVWFoXLrarIhZNF4qJ2PH6smLKfmwiuNIXPFV5FSOXmYi7XbiUzxiJ3cAQZW90w2+2p3uPNrapLgQiEVGAuJBIiuSXVH6j/tfgxCV0zhs/0TnQFrzC1LDQm6+zbAUrhzoKDArQI8n5Di60LuLOIQJzjwXYbNHfR9yKKkZKlvfUQsa+Mq636d2PtNKxmVFiLM9cSMlU8vm0agMCS0kp829e+TjWlLLPa0jMJVbTnduN9Gos8hRJ6CLHNrVapBagaj aO4njRXW Jv2ld6P6xIPqUy9aBOCBoBF4C9rC2D8IunyLkIVkJcVPaoBiI66d1iGP4pR/4ia9VkeufdT4a7dbzha7S2w2iKy5MgAraW7/Cxn2Pl6jsapt2gm62ZleI2HpJVt0lrJXG25ABLZSehG3nYo72CaN40gsQOzRzXXwtk5msiMZCbeZgDlbRWl/NXqYwBdFrx+AO/nqBtUC3peUSu4LhGo71B9MrBYecOtmoi/kRtqGhoOrwBMahPXhjCJu2l7I3pwRFrpR7iO+sahSMdgyAFzRsNxRdny9x/6nvsW+xJImqXQeJWg7x4ajoykE9c9yb7AZUaYJ7qy9wQSl9XWCeZh89b8SNHglOETgy4tbFAJce7+6K2pgI+935S1d4kO88+7eklsu8kicp4NWdj4ihYXymMoDhHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 08:36:01AM +0000, Wei Yang wrote: > On Wed, Feb 19, 2025 at 09:13:22AM +0200, Mike Rapoport wrote: > >Hi, > > > >On Tue, Feb 18, 2025 at 02:59:04PM +0000, Wei Yang wrote: > >> On Thu, Feb 06, 2025 at 03:27:41PM +0200, Mike Rapoport wrote: > >> >From: "Mike Rapoport (Microsoft)" > >> > > >> >When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, init_reserved_page() > >> >function performs initialization of a struct page that would have been > >> >deferred normally. > >> > > >> >Rename it to init_deferred_page() to better reflect what the function does. > >> > >> Would it be confused with deferred_init_pages()? > > > >Why? It initializes a single page, deferred_init_pages() initializes many. > > > > See below. > > >> And it still calls __init_reserved_page_zone(), even we __SetPageReserved() > >> after it. Current logic looks not clear. > > > >There's no __init_reserved_page_zone(). Currently init_reserved_page() > >detects the zone of the page and calls __init_single_page(), so essentially > >it initializes one struct page. > > > >And we __SetPageReserved() in reserve_bootmem_region() after call to > >init_reseved_page() because pages there are indeed reserved. > > > > Hmm... I am not sure we are looking at the same code. By "currently" I meant the Linus tree. > I take a look at current > mm-unstable, this patch set is not included. So I am looking at previous > version with this last commit: > > 8bf30f9d23eb 2025-02-06 Documentation: KHO: add memblock bindings > > Here is what I see for init_deferred_page()'s definition: > > init_deferred_page() > __init_deferred_page() > __init_reserved_page_zone() <--- I do see this function, it is removed? > __init_single_page() > > What I want to say is __init_deferred_page() calls > __init_reserved_page_zone(). This sounds imply a deferred page is always > reserved page. But we know it is not. deferred_init_pages() initialize the > pages are not reserved one. Or we want to have this context in > __init_deferred_page()? In mm-unstable the code is slightly reorganized, but in the end it still initializes a deferred page. It's just only called for reserved page, but the initialization itself does not presume that the page is reserved. So both functions are misnamed here, __init_reserved_page_zone() and init_reserved_page(). > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.