From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87CAC021B2 for ; Tue, 25 Feb 2025 06:39:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3424B280002; Tue, 25 Feb 2025 01:39:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CBC8280001; Tue, 25 Feb 2025 01:39:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 144B9280002; Tue, 25 Feb 2025 01:39:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E6C8B280001 for ; Tue, 25 Feb 2025 01:39:55 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C953160AD6 for ; Tue, 25 Feb 2025 06:39:55 +0000 (UTC) X-FDA: 83157516750.20.A9FF034 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id E0C91A000A for ; Tue, 25 Feb 2025 06:39:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T+ILXMjg; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740465593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hj5D227ch1iq8F50kZ0cjU0+st5jyGocbEADkQeAaXY=; b=lQObcWoNQeFNVGgt3qaewb6Wy9PVGmQypqGkEg7SO0sd+LbhWGuQUzMfKuyKKoHIXmEp4E ofPWI41yXvQosjJQRLXCAj3CQLssulUK+2dSzpRCSsYldr5hazJpB6xedcznw4/JBFy3wX JQGnL/UEkorOocqbh7Y62L3Tvdhnu6c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T+ILXMjg; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740465593; a=rsa-sha256; cv=none; b=BijPxDO2CPU7MPZYIZcE9Gf5DqKgJ6e+dP+wuC9g2RmTaXiu+D+RwcBZbvMpYdf8hdElbL 1AG3j0mMrJ6OB7oelLdnznkG0Cy8+qHmvS0C98wWSd2+SM8RafmwP+zAKf7j0vbb/rX/g8 ycfc7M8jmczxJTG9xF3gLPWn8ViytDU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740465593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hj5D227ch1iq8F50kZ0cjU0+st5jyGocbEADkQeAaXY=; b=T+ILXMjgUZYHC/YNtRzx+JKdCMR7L5B05RknXFzGNn64wGsYM5sHnVesUp+4xJRkWTtQey XP09/9PED3wiBTqKdmOAnhyk538fFOZ4R19PW6DqSHU2WiEUfYGnVPKuVXQLojSe+trlh8 slOJBaZXrLt1la3OA6vtbWo+jqf7KmQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-T0i9WcdWNCim8CMnpziD5Q-1; Tue, 25 Feb 2025 01:39:47 -0500 X-MC-Unique: T0i9WcdWNCim8CMnpziD5Q-1 X-Mimecast-MFC-AGG-ID: T0i9WcdWNCim8CMnpziD5Q_1740465585 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E979A1800877; Tue, 25 Feb 2025 06:39:44 +0000 (UTC) Received: from localhost (unknown [10.72.112.127]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 13E1219560A3; Tue, 25 Feb 2025 06:39:42 +0000 (UTC) Date: Tue, 25 Feb 2025 14:39:38 +0800 From: Baoquan He To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Barry Song , Hugh Dickins , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , Baolin Wang , Kalesh Singh , Matthew Wilcox , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/7] mm, swap: remove swap slot cache Message-ID: References: <20250224180212.22802-1-ryncsn@gmail.com> <20250224180212.22802-7-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250224180212.22802-7-ryncsn@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E0C91A000A X-Stat-Signature: cnqif6doxrpf54xsrwn3a44xtkqo5snz X-Rspam-User: X-HE-Tag: 1740465593-18906 X-HE-Meta: U2FsdGVkX19taL26wdPqygGy3mlJ4QLOGJYNT6xj+89ffoqfYP4igQWzM3+x+KAXfclUQ8APCqa/P04kZXMdM0c5KT4PYgOXOK+xIgdse3/iPQ6hRqyUyPzMEgRgXhAw39REepB5GNyITJTUUqfp23Kz5RXqweJSpXEVxQ3wMIHiiJJK6o5MCXE4t3/WEmLm/ljzXrwvy1WtEdXaksa4vr5IQL8GXTUjvWdRtv8Ei/svHoUcAzNC3Lgbklg9ZFvzefS+aHb0d+Mr/kuWhOA3MAvhNy4ikI0xeP3/IPwzW5PtyHVMqxBhrqPSn/9FkK/dv7ZobNrvEEZwrF5XHg46QD9RjvrxKFbM1hyE2ILWIWXM1/yL8mpOeCOuiwaLbRAtw4JxiZz827fykE08wyqyT+YRzizZ8p05hOYz5W8KLJXPMyqdMqaNTs/MBp/AMNzezFpVF9leOAfstxifscAAUtgsSRybeL6etXjAWDoPA/vruMJQMdM/W27wDIiMeauDOvt2urgRgPiLpW/VzVMErfz5SYRoY+VXnxiHNq8KnZk3sIciJsEVTwCAzHxg1Rv9tpOHxew7RHwF2tW6BvKK0OOK+aRUs1peHm5FSjMa0uOuwkGmOcxGod5Xk0ah5tHiBaKxtzs7rnKXExsq59nLvnQWAVt82YJGvDYPxbeGqrXd9SrmkOJ2QhlKV+cuB4XzV/plidTZOqD2g2d8WdSXvctJQCuylv1WfujHVG1py9lyD/8q80Gqk+DdeUC8d6HOHb941dTuPvTNV3YzOP+eOSOsaiaUY2TCqdk3M5BXN5dw/u7gQI3XrD6kiz06tGD/lbX+PTHDr8/WmjJrxAADAletT9ifPUlHc0f9kTekjtjeaK/yjF4tek6+CHeqmU/QXNMTmA8E1EkdSUW9NoJy0m9hQVt58MKSLMEhwqDwI3/e/+CkMkwQjE6kDMiSE6X+MJj12VR0ZDje4cWoClC +GHJQwug HYcYC3fF4OfoRr6xiQ7lZc+Ulv/w8qefMx0hesfgJx2iP6yD8sZKGPBplZGUaVq1BytiI+qwEBUJOFQfrAoJ+n75Ve2JFMJKKxmTgmOg+0rVzpPTp2R0uet8OYCo6nedXyQZY6+F2YK90CUdlZ+toK2pPhmfd9UO7jrwHON3+tGAxBdGwE0fFRwumu7FjhDn2cYIoQgnTz1l6lOqJkvJGU7A4pPwRoVPJ2XU1TARKSv4EV/l+tZh10v3iG4sFpsP4Oa46gwgOsbRS56aMndBfItNb9acJl2Sp7+mXrODvsS3bTD6k8/RZibSgsnWoulUMj/e1R/VquEvoeJ+kM6LuNHpKwtFiXKVi1Fj18Gf1NIu5QTb3ySX72g7bMsBqvOfHxprnseexB+gbtzFk57eiXahQ6tKHdCAxtXL+vsSCn7FonZ1gM5HSjZzeNAfsLx3spvtz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/25/25 at 02:02am, Kairui Song wrote: > From: Kairui Song > > Slot cache is no longer needed now, removing it and all related code. > > - vm-scalability with: `usemem --init-time -O -y -x -R -31 1G`, > 12G memory cgroup using simulated pmem as SWAP (32G pmem, 32 CPUs), > 16 test runs for each case, measuring the total throughput: > > Before (KB/s) (stdev) After (KB/s) (stdev) > Random (4K): 424907.60 (24410.78) 414745.92 (34554.78) > Random (64K): 163308.82 (11635.72) 167314.50 (18434.99) > Sequential (4K, !-R): 6150056.79 (103205.90) 6321469.06 (115878.16) > > The performance changes are below noise level. > > - Build linux kernel with make -j96, using 4K folio with 1.5G memory > cgroup limit and 64K folio with 2G memory cgroup limit, on top of tmpfs, > 12 test runs, measuring the system time: > > Before (s) (stdev) After (s) (stdev) > make -j96 (4K): 6445.69 (61.95) 6408.80 (69.46) > make -j96 (64K): 6841.71 (409.04) 6437.99 (435.55) > > Similar to above, 64k mTHP case showed a slight improvement. > > Signed-off-by: Kairui Song > --- > include/linux/swap.h | 2 - > include/linux/swap_slots.h | 28 ---- > mm/Makefile | 2 +- > mm/swap_slots.c | 295 ------------------------------------- > mm/swap_state.c | 8 +- > mm/swapfile.c | 193 +++++++++--------------- > 6 files changed, 71 insertions(+), 457 deletions(-) > delete mode 100644 include/linux/swap_slots.h > delete mode 100644 mm/swap_slots.c Reviewed-by: Baoquan He