From: Catalin Marinas <catalin.marinas@arm.com>
To: Tong Tiangen <tongtiangen@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
James Morse <james.morse@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, wangkefeng.wang@huawei.com,
Guohanjun <guohanjun@huawei.com>
Subject: Re: [PATCH v13 5/5] arm64: introduce copy_mc_to_kernel() implementation
Date: Wed, 12 Feb 2025 17:18:21 +0000 [thread overview]
Message-ID: <Z6zX3Ro60sMH7C13@arm.com> (raw)
In-Reply-To: <20241209024257.3618492-6-tongtiangen@huawei.com>
On Mon, Dec 09, 2024 at 10:42:57AM +0800, Tong Tiangen wrote:
> The copy_mc_to_kernel() helper is memory copy implementation that handles
> source exceptions. It can be used in memory copy scenarios that tolerate
> hardware memory errors(e.g: pmem_read/dax_copy_to_iter).
>
> Currently, only x86 and ppc support this helper, Add this for ARM64 as
> well, if ARCH_HAS_COPY_MC is defined, by implementing copy_mc_to_kernel()
> and memcpy_mc() functions.
>
> Because there is no caller-saved GPR is available for saving "bytes not
> copied" in memcpy(), the memcpy_mc() is referenced to the implementation
> of copy_from_user(). In addition, the fixup of MOPS insn is not considered
> at present.
Same question as on the previous patch, can we not avoid the memcpy()
duplication if the only difference is entries in the exception table?
IIUC in patch 2 fixup_exception() even ignores the new type. The error
must come on the do_sea() path.
--
Catalin
next prev parent reply other threads:[~2025-02-12 17:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 2:42 [PATCH v13 0/5]arm64: add ARCH_HAS_COPY_MC support Tong Tiangen
2024-12-09 2:42 ` [PATCH v13 1/5] uaccess: add generic fallback version of copy_mc_to_user() Tong Tiangen
2024-12-09 2:42 ` [PATCH v13 2/5] arm64: add support for ARCH_HAS_COPY_MC Tong Tiangen
2025-02-12 16:21 ` Catalin Marinas
2025-02-14 1:44 ` Tong Tiangen
2025-03-24 16:54 ` Luck, Tony
2025-04-03 2:48 ` Tong Tiangen
2025-03-28 17:06 ` Yeoreum Yun
2025-04-03 2:36 ` Tong Tiangen
2024-12-09 2:42 ` [PATCH v13 3/5] mm/hwpoison: return -EFAULT when copy fail in copy_mc_[user]_highpage() Tong Tiangen
2024-12-09 2:42 ` [PATCH v13 4/5] arm64: support copy_mc_[user]_highpage() Tong Tiangen
2025-02-12 17:11 ` Catalin Marinas
2025-02-14 1:45 ` Tong Tiangen
2025-02-14 2:49 ` Tong Tiangen
2025-02-14 17:24 ` Catalin Marinas
2025-02-17 8:07 ` Tong Tiangen
2025-02-17 14:55 ` Catalin Marinas
2025-02-18 11:51 ` Tong Tiangen
2025-02-18 19:42 ` Catalin Marinas
2025-03-04 14:10 ` Tong Tiangen
2024-12-09 2:42 ` [PATCH v13 5/5] arm64: introduce copy_mc_to_kernel() implementation Tong Tiangen
2025-02-12 17:18 ` Catalin Marinas [this message]
2025-02-14 2:57 ` Tong Tiangen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6zX3Ro60sMH7C13@arm.com \
--to=catalin.marinas@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=aneesh.kumar@kernel.org \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=guohanjun@huawei.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+huawei@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=robin.murphy@arm.com \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
--cc=tongtiangen@huawei.com \
--cc=vincenzo.frascino@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox