From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB6CC02198 for ; Wed, 12 Feb 2025 16:13:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 108AC6B0082; Wed, 12 Feb 2025 11:13:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B8F36B0083; Wed, 12 Feb 2025 11:13:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEA0E6B0085; Wed, 12 Feb 2025 11:13:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D09606B0082 for ; Wed, 12 Feb 2025 11:13:53 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 452431221B9 for ; Wed, 12 Feb 2025 16:13:53 +0000 (UTC) X-FDA: 83111788746.14.CE2B353 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf24.hostedemail.com (Postfix) with ESMTP id 6D483180023 for ; Wed, 12 Feb 2025 16:13:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ssiqaj8b; spf=pass (imf24.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739376831; a=rsa-sha256; cv=none; b=HtmIOyucGH5wtlj+85PdwpFpAw36qaIanyolSmfJ0EWcBFgec8FGkcW2SxiktSwfbpuOLH +RrTiXzWWtOHGoxDiwB++soXdiAFvhnr9rconjhPww/VjWRlwMo64OicSMrCxA5cFTdvE0 0N6R8UUvqpOtG7R2wsF1KXEpv0I+/LQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ssiqaj8b; spf=pass (imf24.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739376831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uQjPm/FYeJonJ+z609Qz/2KCORZ2hGgk5RPersdsl3o=; b=rFE569SQc3/7OaSsTm0gp2Y+/fAXpUSQmBOfVMAdDNQJy1fJ1YeA3qU/Lj5FD1bEDjRtu1 Unf+C4Z8CxUHDpqGziWCspOkaJYnUe1ulRhFUq7xBTHTIc1AVNG74z1ifCr6FehK5KPdWs iEfWN2vIRt/YtIhsVAYaymM2MLk0GCQ= Date: Wed, 12 Feb 2025 16:13:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739376829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uQjPm/FYeJonJ+z609Qz/2KCORZ2hGgk5RPersdsl3o=; b=ssiqaj8bx4Ch1HBsrZI8yA5xQdbQkDNsLfTdGX3yPmgCupk3UOsCaw/C2n/0gvVfVwJVlZ bwcgHov4uaQeFVvDfcA1haSFA0r00hzbX74WUnc5cXAGNsX01EcgV5xUa9LYxwnZZt/TmU tP+9+dhmPMdKDUhJZnmEVrBp5FZW9yA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Sergey Senozhatsky Cc: Andrew Morton , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 03/18] zram: remove crypto include Message-ID: References: <20250212063153.179231-1-senozhatsky@chromium.org> <20250212063153.179231-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212063153.179231-4-senozhatsky@chromium.org> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: oqonnjmjfzz1pax1rcrak567otajbx7t X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6D483180023 X-Rspam-User: X-HE-Tag: 1739376831-183501 X-HE-Meta: U2FsdGVkX1/vwmXx40VpY5+EjuNXjYhTTtwDp01W5x/1Q+M6t0ixZHE9RDywZj2DNTMWWwF8zatB3/sgJNWyEY1fbDplfCT8+6BZzowaSPCcnEHECeszhKaiGjzBAaLtOxCGfTWHiaU9rsfStvBvWWTZtiwoDgnaSq1wmthF8UKNPq3q8PAUEejwBtzbwEy6VzTdAq+I/sge1oBE3/ObKGvtznYTq4ShLN6TccvE690VZxxClWc2cHXzYRjD9AKsUqWW9+vRvX5qD9LzTHG0dnHwGnY/ci4bki+3UzZO7vK3smwbZ/um94B9occsxrGNd+rILubqm//PXccW2lDQYioWXuKzRy+jpKcMl9u9c0NZxMdSTuWU09Lzu0bJ1gfyPIiUEnQYbf0VZ6y7SBXUaDEnz0dOPOAsoeawst6PNnsh3oYfrLio6v9VanC8q++YispEDmllud8QwFqY2bCgOIv44ICBUms2eEL5IXaaVCSIDYt5yB2Bd44i2FWIJDWDgOm+eokXpsI+6bi39k+Tcz0ABuNg41wN574c0J7qfztQNNexy8zDDdkDpKj2RYdD0rJNHLAlSWGilcdiAmBdT/sq7/7tpVejHW9HLIevcYeX4Z72OQV/GaKrKKGA5HbovZxTazC1E08WxKTujam7oyBkLVS8aVfF9W6ELFJ7vdrgDEtjz7faMGIgcKbLknvo+g3haVyJhLnCTjCM2aSaE7JPParGthcfes4eXE1S/gO3/9uMj2DQ7lOYWVPfYbdLJ3dIPdtQ72EZofvVg37kEiHHJViWzLdyhWi1XOeZCq5h30SivrjD6x69fnJrmxOk9UoeB6asY9i2n+wtx2Qgcct5xexRlGBwLd5G0P4BFHDLzBjKxVOnYdX+P4XtN4Y2kmlL3mI/4xRDEGTwMufye0LM2Xf/gefUpjNDjXrclJ8ccmVKeqUlvKnYj5QsCnLRVxPUL7CO1NHGUOtgTst La/NH6gw eIUefBvOZb9s30OhQ23W4fTkD/f9XphHDR507F1dR7lDZ3lpFn9lV/IeH1je0pZRGdvN/vq34JkifX81xsR35tR5MEH3zIkzHys7CL6VMIR6KWw/NUKLyhiRCW4K35JFAehIIFD3PWDFQM0CoykoKvtDCVN0Mi0DhfnsENp0M90iwgqQeVuCwoF/+6vJjqjT62KT0CcMh7ZokurmU2+A37R12lP9JbjZfTg84OvXhsVUAurqCCPcERj4j1NjW2NMg5vlE+UGPiwJbqZg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 03:27:01PM +0900, Sergey Senozhatsky wrote: > Remove a leftover crypto header include. The subject and log is not very descriptive imo. We stop using CRYPTO_MAX_ALG_NAME and define our own limit in zram, and removing the include is just an artifact of that. > > Signed-off-by: Sergey Senozhatsky > --- > drivers/block/zram/zcomp.c | 1 - > drivers/block/zram/zram_drv.c | 4 +++- > drivers/block/zram/zram_drv.h | 1 - > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c > index e83dd9a80a81..c393243eeb5c 100644 > --- a/drivers/block/zram/zcomp.c > +++ b/drivers/block/zram/zcomp.c > @@ -8,7 +8,6 @@ > #include > #include > #include > -#include > #include > > #include "zcomp.h" > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index 43f460a45e3e..12fb260e3355 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -44,6 +44,8 @@ static DEFINE_MUTEX(zram_index_mutex); > static int zram_major; > static const char *default_compressor = CONFIG_ZRAM_DEF_COMP; > > +#define ZRAM_MAX_ALGO_NAME_SZ 64 > + > /* Module params (documentation at end) */ > static unsigned int num_devices = 1; > /* > @@ -1149,7 +1151,7 @@ static int __comp_algorithm_store(struct zram *zram, u32 prio, const char *buf) > size_t sz; > > sz = strlen(buf); > - if (sz >= CRYPTO_MAX_ALG_NAME) > + if (sz >= ZRAM_MAX_ALGO_NAME_SZ) > return -E2BIG; > > compressor = kstrdup(buf, GFP_KERNEL); > diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h > index 63b933059cb6..97c98fa07954 100644 > --- a/drivers/block/zram/zram_drv.h > +++ b/drivers/block/zram/zram_drv.h > @@ -17,7 +17,6 @@ > > #include > #include > -#include > > #include "zcomp.h" > > -- > 2.48.1.502.g6dc24dfdaf-goog >