From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F27C02198 for ; Wed, 12 Feb 2025 16:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BF856B0088; Wed, 12 Feb 2025 11:00:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56F3E6B0089; Wed, 12 Feb 2025 11:00:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 436B76B008A; Wed, 12 Feb 2025 11:00:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 21A7F6B0088 for ; Wed, 12 Feb 2025 11:00:48 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 639A1B537E for ; Wed, 12 Feb 2025 16:00:47 +0000 (UTC) X-FDA: 83111755734.17.2DF8853 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 08AEA20014 for ; Wed, 12 Feb 2025 16:00:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HCC36UzI; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739376045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nltTZzKoIJD8v8cI1Mbb1ugEPFMXVME2vX7W2rBS9Ho=; b=WgYa+ww8Q42I5PwXg/Y/4nYGmWVw4A2JAL6CN8eX4OP8ywsIucpYbEpSBXTl4OIftd9ABh GW/WA3XNN3Z6IVMYUTsLDNpCv+e7rN1kXbrgxkHPIrf7GMnatHmbQ4XmvGJBhx+Je5Z6Lq iOdgsOAA5LRfsidzAwjlZpG1Jc7OEBE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739376045; a=rsa-sha256; cv=none; b=wpI6P0erKYzg8ChfgBbO2QEw72mU8Hi6NgMUa4+24/kwsc+3sREMoio2NVDcedIabNIWsf 3N+45i56o9Edf/fZqwuZCPEp0pqS55lw9x2YYt/7tdAFkmwugtDpFTsDqzwj/48d2i1TAq ynusAZTIxUdlr2mClf5iBVj17TnYzp4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HCC36UzI; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B928E5C6084; Wed, 12 Feb 2025 16:00:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA975C4CEE4; Wed, 12 Feb 2025 16:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739376042; bh=P2PvM3qZ0BEUNG+xxCfwPu3336ksPgx0VFrUhWZNXA0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HCC36UzI5XBvCVDEyZmkpEjKTweo4lRn22Jcr57O8TYA4WG6yztDM7xUPMpbHXwPA 6ik2sjCWTK0Demi17AUvltnpwZJs4K21ZaxEOhIlLsoX2/gKsbDoao1B4LyUk3Gt+7 RLzMvpg1RTwslbWYmoqoSEp5phjfBi/bAWroTHzeNBMwQuhzqelFPR9Bth1s50o/Cu t762+vVPiI4XQFx/Q36/eBPYLe9Se/7uXtevG82OKGZbPPnAfHpZVkE/pHCGPluycY b0sJBqsOa66GQ2IOn3SvABlnQv2cQEWXragDbof3+ALbgRqjK+8gMM93Qrt5GFCJFb P+dBLJrUeXXaw== Date: Wed, 12 Feb 2025 18:00:20 +0200 From: Mike Rapoport To: Jason Gunthorpe Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 14/14] Documentation: KHO: Add memblock bindings Message-ID: References: <20250206132754.2596694-15-rppt@kernel.org> <45df0d7a-622a-4268-9683-c5c6067483c3@kernel.org> <18529b1f-dc79-4c85-a485-a0a2cdd48670@kernel.org> <20250210191539.GA3765641@nvidia.com> <2fe7a404-be2c-4ac8-8980-2b3d07a74bca@kernel.org> <20250210202040.GB3754072@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250210202040.GB3754072@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: 08AEA20014 X-Rspamd-Server: rspam07 X-Stat-Signature: 9f76sz7gaexjxpc4o1m397446nwpcwfi X-HE-Tag: 1739376044-998982 X-HE-Meta: U2FsdGVkX1/Ac2zfmLgCB0hMCM4UI6nZANVTTLsQD+y0bjFiX7unR2NraRv8QKOn1sr0GtIZU3+XhSg3U6ktQe6ytCORywf6keA2VPLnzhYUm9OeM/+I5ewCmxPv3Gx60/WcNX8S7l+ki+xwDDZA+dRrp4d/JpLxhh+9NlWLmrZCy95aGVC1o/ygo6Gxwy/4cRi0dqYZZAJJTOx/X1hQwbjGsEQK1JwHnWk6uWH1eC69paX3b4qmc/YT3s6uCt03S217QoY9YhRFsihv/Y7GkYi5fHGva/jcuueQPzJkN7AsB9CfspFF35A8gdn8DdrAVmhZYldPPj7XYTerPjE33lCqJqDAG0m/eOUaX+GAjptzWJfWuweyq/Wpr6dM4j6tZg+CTIlmPRog0HNTolprVtb+36/WDtqhm9krQK/9xmNqY3J0THe/EHoVAbccE8eTn4WqBM+G64/kilcqUuf57Oa7lFPEV+q+5UrOu0LQTeR1bc+6ztnuunje8W5NjnTp0OHkYAzIKzAWEQAjjHQyEF+FskANsqEYy5VeNygTd4vG7i+2ILR/33qNDwG01t2z2FThsGh3+xpS4LnwfPg87HccP8xEQZTPXbJ0ska9H5O3NyDRolOyPO9EGkNkg9FI+0aF86XBXVxs2dXpEwhCoHEQVqzSEjnm1OJL6MDODmOK6zhAhN3J6sjx0MAgs6M2friQYrPjS5gsFGPvDRdUVWUk14fY7HcV20HyLFoP0uejQlFWHGWmJ0QHwvv+cWvts/RfkmEbBzvy9PP0PVMsh1a7Vl1c8sgoToofjqI9btjwrijolj/EO1Y7/T/sGCDFlMTGlMqs+rkM2h1PaOZMp+UAHlcAzQm/vvXCKhumNuVHUogOvgEVm1unyfNcUxW2Hi89n8StnK2prtKmmWRpOV8HuZIcUpzT9egPuUMpiSaThTWuH1z2r8M1c4Cy6uVGLPyq86YOL1ANfcpV2xI oF1sJ0tS ZTWf20UbvbJcX/nkM+RskaurTH/PCcWYbOdcwQoCkWYDFHMru7fmjrecIT40t9x+qcTtZm84zfBUZbIiPPbzADM6iGFiV4SvwVRxscof7s99nTs/ByAQegan7Gxg8BeUHxxzsnbnUx5mTu6+fP4rbxoYhdrVfcvmOB28l0HS/roF1Pql33ahNAJ0xaGixZEePKWQYsWzSfq/zXCAaxIXtpCrK02+Ct1BePvkEuNfMC3FWd7z2vehRR8IQ5FnSyqH178CjXdxIQS/JMOSeyeGBZTmIU/iHMAXgT6DMtIElmN61OfaSr8Sz420Q6rLbt/drqZpjjVFoEVNxUsn5wDEzF4e1vYtkB4+b7qMyLdkHhvRFVsJzBiw4a+Osperpk0gymmlT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 10, 2025 at 04:20:40PM -0400, Jason Gunthorpe wrote: > On Mon, Feb 10, 2025 at 08:27:34PM +0100, Krzysztof Kozlowski wrote: > > On 10/02/2025 20:15, Jason Gunthorpe wrote: > > > On Sun, Feb 09, 2025 at 09:50:37PM +0100, Krzysztof Kozlowski wrote: > > >>> Ah, neat, that would almost solve the problem but you wrote: > > >>> > > >>> +$id: http://devicetree.org/schemas/memblock/reserve_mem.yaml# > > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > > >>> > > >>> so no, this does not work like that. You use devicetree here namespace > > >>> and ignore its rules. > > >> > > >> ... and that obviously is barely parseable, so maybe one more try: > > >> "You use here devicetree namespace but ignore its rules." > > > > > > It makes sense to me, there should be zero cross-over of the two > > > specs, KHO should be completely self defined and stand alone. > > > > > > There is some documentation missing, I think. This yaml describes one > > > node type, but the entire overall structure of the fdt does not seem > > > to have documentation? > > > > A lot of ABI is missing there and undocumented like: node name (which > > for every standard DT would be a NAK), few properties. This binding > > describes only subset while skipping all the rest and effectively > > introducing implied/undocumented ABI. > > I agree, I think it can be easily adressed - the docs should have a > sample of the overal DT from the root node and yaml for each of the > blocks, laying out the purpose very much like the open dt spec.. I'll update the docs with more details about overall structure and will make it clear that it's a different namespace. > Jason -- Sincerely yours, Mike.