From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F3AC02198 for ; Wed, 12 Feb 2025 14:21:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 964876B0082; Wed, 12 Feb 2025 09:21:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 914896B0083; Wed, 12 Feb 2025 09:21:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B5A16B0085; Wed, 12 Feb 2025 09:21:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4C07F6B0082 for ; Wed, 12 Feb 2025 09:21:01 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C865881C87 for ; Wed, 12 Feb 2025 14:21:00 +0000 (UTC) X-FDA: 83111504280.20.C757A70 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf19.hostedemail.com (Postfix) with ESMTP id A56FD1A0017 for ; Wed, 12 Feb 2025 14:20:58 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l6v+quOF; spf=pass (imf19.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739370058; a=rsa-sha256; cv=none; b=YOndwj2i2kDpT4bD8A/Q2NJ5g0p44r9h6riN2W3LMTlq/ZpPeSnlgJV3C//sHi0utqO1ay qSqb1pVLBG2YoyfqYq394qR77SEJ0eZ45r2kOWWP2vPkwmJgPWc3DBezjlTU7B6jXo8XcH 8uGkpJoHOepZVIlBLhJUWoyilHm0UUA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l6v+quOF; spf=pass (imf19.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739370058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jaIYJxkfq1FpQvIWfelFCHR6bgEv7q45G9WBNdGRrEU=; b=u3kGHW465QmZM+zAOlfp493NNlrB/+S2jE0D/zTOCPi2VeqKG8Qe011dCy+WqN9wtjOMq8 1Klj0cEXZ/+tk3WsoBbsp7l3pjEHBYbAMT23K1pDyIO6MRaLXaBNLzXyP6oq+RJ6+fSCT6 Z8McaieUuPx+iF+mcaw0bh67JY34/Io= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-220bff984a0so14271675ad.3 for ; Wed, 12 Feb 2025 06:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739370057; x=1739974857; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jaIYJxkfq1FpQvIWfelFCHR6bgEv7q45G9WBNdGRrEU=; b=l6v+quOFK5Xl0nr9z8SdYMyqwBVCkLZg78b/fi4Y2XuIcT35L1amJ5fhWeBqAGKq8H tW97MwJVTMeOiFRdocXBIz4W3NI+3g/jpy4fKx1wa6H5h3PSZN8bEB+sGK4Kpb4wK8jD gqfL9eKL+vh5MAMwmCxXwCebLg3bcaYFjpyizLMLAytTyyvu9myuUAzD4yxBaTyxvdjI XMh9wUyLG4VsJ1+rXXnVAgpJdV9uw7ZldLcwGwLMqP4daTK2QxZAHP5DtT12h0ClIHEJ EUga4Tl3UDMR56mUPBSfO5XtgZnQJOYZLPPM5J7KoCiUyaD3yedKJw9LeEq0gJWJOjkv ZICw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739370057; x=1739974857; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jaIYJxkfq1FpQvIWfelFCHR6bgEv7q45G9WBNdGRrEU=; b=pQl07lyddTpzrKZG75qrf50O+WmXsVXNjiqZpbuU+dONGie4K57pCRHSUyrvZgS9xL yuRrEebcC9KzZr+gj+AX9UiO1hjQHG9aGi+2paECwz903XyLqVnnQhPuzUWCW1BpDNEq gQ1GagDP5wn7i7c7AMCYlpdaJ55WUC34IOSaHe/d42NCSJ51aUsmOFPCvG0X/kNdfZ+y Cq05CUPxLYMH9h0s/VzzPp3vWSVEHsMr+RpJfF3VhHSGuiq+OblzK49x/26172WmehNx ryJWgwPkjzggmGibVtBP+98pQyZXo0ZF19qm2ShYRIpcIWP4B1secf7IHmUSHxXCmtk7 iLAw== X-Forwarded-Encrypted: i=1; AJvYcCX6sU8AADNfvE1h4OBNeqK12H9xZ2Tq7OmGLtaAuEKRD/EcTqyr9BsPrzkV9dzGFMFyMtpfjNzDXA==@kvack.org X-Gm-Message-State: AOJu0YxfJzs4nsr97gpY4Wo9xi6HbyGx6/P8YXma2TryAkbgVck5R9ic K1tOQRjg/951JuZkSf6DX4hve1Ivc7fjlgq2Xgq0cQosFBN4aulK X-Gm-Gg: ASbGnctxJND4vv4luhE5EMkrtuDgjlQk1hzMhgE5ufSw2DgFs56hmAvcMPbamSsooru hFbvWKr5M2K0L4ZlHb/aa0ik001oW+z4UvUWCaK7pGgozxhCBZS1EMUr+XdEeEr7ypUPUNvKmaR v+4dO8lPu0OBSL9UfWc0h3rFEI3p8KQwLfU1FucwWJ77PKKvoYdAsqwsD6t3RGm3EmB0i4yx02Z nv8NiPkO12kWNNah5vPPJo+gqSpp6ZeJpRTo0M4rneUkgKOXkamAcIzoZ85VQObJtLfYtt0g3a8 Vbq+ZA== X-Google-Smtp-Source: AGHT+IELAEQ3Su7Uqr4OcDRN0pXjfLjCy12n0YoT9VXRC5Czs6XS2YZHik4XXoqANjmviTX4+vCgMg== X-Received: by 2002:a05:6a20:9145:b0:1e0:ae58:2945 with SMTP id adf61e73a8af0-1ee5c822982mr6803627637.31.1739370056948; Wed, 12 Feb 2025 06:20:56 -0800 (PST) Received: from fedora ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73048e20c32sm11487073b3a.170.2025.02.12.06.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 06:20:56 -0800 (PST) Date: Wed, 12 Feb 2025 23:20:48 +0900 From: Harry Yoo <42.hyeyoo@gmail.com> To: GONG Ruiqi Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Kees Cook , Tamas Koczka , Roman Gushchin , Xiu Jianfeng , linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] Refine kmalloc caches randomization in kvmalloc Message-ID: References: <20250212081505.2025320-1-gongruiqi1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250212081505.2025320-1-gongruiqi1@huawei.com> X-Stat-Signature: pxsz8yzmt1ineam3yygb87k8xcopaeyo X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A56FD1A0017 X-Rspam-User: X-HE-Tag: 1739370058-178583 X-HE-Meta: U2FsdGVkX18VN/Xy9jtIqfsH+eTxPqEdrMAPuPKL06F9ExImJCl60wU8rf0g/aVkpY1fhfDZSIlNf2vR5g6jXSZKBmgteP68rJZhBVJblwnOZ/8Sh44zYcZMRhSuD8/OXarh0Fk2RvteqAeNtlHgANVTf4iMoxmcsggXGsx8M0cQG0O90C+Klq0FYEB8s7xhKk7PpR2l1ubqYX7+f6EGzCLutPx2GAJNwvJtNLB4YvMrUjdPLepH+0SBkp+BEfqxcCiC5rI7NxEHXfvFVV9/KV5BtoHsD0JqSltfeOvHVUJWLue5oMOwakIjBatLnkmCWhLe0TkIUAlBSVe+8FyJvj6NAT8ZVKzLN9G8QZygxTypn6yEqj/zMCFQ6M4FpC0wAeKGcZuvvcxZ6SCnGyKBHMYrBqBWU91O0ZTQL7myK9Spqd29ORxWTZdAaTUi703Yp+wF29G5UPSXdGtGIzHlWcwSTk7mYP7Ds6G8r16KsJ9Ace9xxjLJf5c8ZQWTNJgBaFF7pwxRdc+aPwi2ZdVnvEDgPudLW8fhL06AqZ6qYhW9fyT5LcR/KOZ/6GO6e/MH0Kodvi6s0zIczHNQeXy9oEaGWRLUob+7TjvLNMO+TLSQNL8MDxMvShy0EQ6Gax5lz+ctf+FksEapodKlboTMHWCswVFvV4htH2LdR+5rbMCqHuXtoVKf9QWKqXHOjxfVOlqk5VRhxOr6VpPb461NerSLgcdHcX9f9bzulsD8zU6evqfebvy5CFJv9hsaOLU0RhcfHhkCcf7GmYL903gK+Syrk+INtst+0DOlqBqs9jtQx273l6YSJ8g4uGH+eIctKcMIHfcnP9BC7N8rajy3JRRiEklpAoWU90J4A9srJAnVelzZwA4tToQdtChEGGbkF0obsUYvqCQdbN5eFhR4JDk2sqS++q88dx4pCf+0bvfaJOYnzJfk5uI/2DIlCCxr+QN6IWHGBN+TSXgUSmf dh6UhRif IpC/6Xh0UzswKHra/+K6vQ7nzgRZmX4fBBQDFPmgmb2ym46xRP92awywOZ3j0+OjVP+S/uzbFE2mTP7oq9wWKVZZMTmwzayqS49bdockC6HvEOtuDgzCHMdxpieOPVWW+2jglvrwF7mauHoBKNQ5detosLS9lBUcHzenxygwuRCmkOVyRwr0D7aokinCKA6tEKo6b0zTDN6V5o0K0UXnqZzon8YKgou4xPF6it9a/QeGeSjidCwpkk7los5n9er3+p1VT9MGSHvBBZvfcaeBUUwdKrJyk3Vxqv1UfMlCzt4Kmttafu4JEVqb5HXRqC9PdvmTiYnHMFs9526tRzs0nZs+TEhf6gt4qPtnl9h3BPsm3fcWB3AabcxLiVsID/dcr0xDW12HN8NvYtrqsuWIlQXxO3bHK5PTPweMLJgelx27QGdakdA31O8otKKYZtZOaFtWywuBnU9qjFLCx+HsmrzxyRFUPex37cqcfU3diz5ZRcRU6gHsjVYA5zTqaUUiojQlTYZD4WW0BNCGY8abFKReV4ah9vY2/8qfu0myOT6GPpUg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 04:15:03PM +0800, GONG Ruiqi wrote: > Hi, > > v3: > - move all the way from kmalloc_gfp_adjust to kvrealloc_noprof into > mm/slub.c > - some rewording for commit logs > v2: https://lore.kernel.org/all/20250208014723.1514049-1-gongruiqi1@huawei.com/ > - change the implementation as Vlastimil suggested > v1: https://lore.kernel.org/all/20250122074817.991060-1-gongruiqi1@huawei.com/ > > Tamás reported [1] that kmalloc cache randomization doesn't actually > work for those kmalloc invoked via kvmalloc. For more details, see the > commit log of patch 2. > > The current solution requires a direct call from __kvmalloc_node_noprof > to __do_kmalloc_node, a static function in a different .c file. As > suggested by Vlastimil [2], it's achieved by simply moving > __kvmalloc_node_noprof from mm/util.c to mm/slub.c, together with some > other functions of the same family. Hi, GONG! Sorry for my late review. This patch series looks good to me (with a nit), Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Also, I verified that the problem you described exists on slab/for-next, and the patch series fixes the problem. Please feel free to add, Tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> nit: Does it make sense to call __kvmalloc_node_track_caller_noprof() instead of __do_kmalloc_node() to avoid bloating the code size? My simple build test says it saves 1592 bytes: $ ./scripts/bloat-o-meter slub.o.before slub.o.after add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-1592 (-1592) Function old new delta __kvmalloc_node_noprof.cold 39 - -39 __kvmalloc_node_noprof 1755 202 -1553 Total: Before=79723, After=78131, chg -2.00% > Link: https://github.com/google/security-research/blob/908d59b573960dc0b90adda6f16f7017aca08609/pocs/linux/kernelctf/CVE-2024-27397_mitigation/docs/exploit.md?plain=1#L259 [1] > Link: https://lore.kernel.org/all/62044279-0c56-4185-97f7-7afac65ff449@suse.cz/ [2] -- Harry