From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E422CC02198 for ; Wed, 12 Feb 2025 12:37:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E814280001; Wed, 12 Feb 2025 07:37:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 198796B0088; Wed, 12 Feb 2025 07:37:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0381D280001; Wed, 12 Feb 2025 07:37:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DFB6B6B0085 for ; Wed, 12 Feb 2025 07:37:41 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 554ED4B9E4 for ; Wed, 12 Feb 2025 12:37:41 +0000 (UTC) X-FDA: 83111243922.11.F55AB0C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 6446480005 for ; Wed, 12 Feb 2025 12:37:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YwLO0XoO; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739363859; a=rsa-sha256; cv=none; b=2ptkikR7I94RwMQ457jzQC8yj6qKAm8jHNzQ+WJ3YbwZUr3g+rliVoQrn1fNR5Bk7r+xRu MTRitnTPxcApqcG464Cv8vDWrjgiJw/R5f55q0FV6/IybSpUz/6sjda35V8awcOophTmgQ KqmbidAD9ovT5UzUjf9/nnCsfJ/1Mz8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YwLO0XoO; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739363859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4vF4v9ob3Qt/mW/L63qd6/SAxzb9yktu841ziiVlM6k=; b=nVY8URt4MPTX+/ahk8KC4JtjaKfxwEY7Qpiaqvz+q+SmDyON8JEgUukK/t2ZOKG7pDNq8l NjXV+vLH5eUAOVCi3ZM4ombqrFPUWgHTk8qYmi7/7Z+VDWYXzARc7NMWgY5zZ6z/LaXibA A8BL6EgKBqH9VYK/jgpPIGu7yftP1rk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4vF4v9ob3Qt/mW/L63qd6/SAxzb9yktu841ziiVlM6k=; b=YwLO0XoOeeK4Q6urL4urw1+a4/ 4foenamCUfufzAyjm9joxAHlnYNT+g1Q2XcwX3F9AhYZIvpbtLTtmambkcsy0c/c/llLN/5I9UtyD XFZr2pUUhB3X6jIGSvd437i28qcS7llZEJE/oxwP2jZA1IVWwTfYMpMpcFSxMeB44YCcWG6+Rktpt 4oWBQx8xP1WXJVDC5EmgR7e81Kjs9FNDOsk4kon2dZ12AijEpZq0rPALLJk42NCW5uF+NIT/Ke1cu esXdcsizifIA0VNrJgAGIYxg31306Ad6ea4n5kDBidWtgBnhmowzHXbjXKdTP9Odo6CKh8O48kQ48 88OpQMFg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tiByo-00000004mqO-1xGa; Wed, 12 Feb 2025 12:37:11 +0000 Date: Wed, 12 Feb 2025 12:36:38 +0000 From: Matthew Wilcox To: Liu Ye Cc: brauner@kernel.org, dhowells@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm/mm.h: Write folio->_flags_1 & 0xff as a macro definition Message-ID: References: <20250212025843.80283-1-liuye@kylinos.cn> <20250212025843.80283-3-liuye@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212025843.80283-3-liuye@kylinos.cn> X-Stat-Signature: akxdnzxgh4nfj9p4jszibnheub67wob6 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6446480005 X-Rspam-User: X-HE-Tag: 1739363859-342964 X-HE-Meta: U2FsdGVkX1/biIYVYS8maeTDcJ/51anDOJPXwoVNC4+w8rpl++7sJYuE6hmt1nuIqY71bG/JqB38uISnHYsQDMt/HmCiFg0JGHMu5S9Q0AkOVSRrmP2g8Vr5fNQMFl39Cdc1W/neqKQT03u9iKQiGbxMXTZhXkoTSnZZB/rC0P4npdWNbMyxjhFgJdERuvsZnajNL2LBeib57Rkrtlh5laaHPa/25tjRYDwPP85zwvvbscpB4UstOHE5hkbejh4yz4oYEdx5J2b5TEcnncX/AK3kNEORumDHCkbdGt89AXLDaO6nGLl8Cq1OOyjvHBLjDmCY1WaACq610+J3wcxaJxKxFPe8uOncIk/ZXiWpj/EFUb83eYc33+NDBqeQfsCTkgi9zLPdJmG8czLYV2twG/e/PO3NfiymXcAEa/fdn4e5i6Mx5bi75oUzJ9Q1yFRFOL/MAD58J2GZvxVoUQci2Jkc4ULEqLbZQP0SKEQAPMhXJsObTTFQfTDRqlayQfJikbqPhekEDdsNVEiOAiAwKEOdY3pv2GuHab3t9IWYY8wXP4pSNy/A8od9PiDkjvYfYl9vstGNuxJmJhzfBULzG2m58b6JMpivKBoeAtd6zKZVjNxaUbTEw81sGyHjc0337TceqHqLK9/fWlJ6R9Vx++duDM0EHAA33XlMRWLlIW/D02Hvp2h/+1UL92Kyb8p72NcnReQAG/tmET5js8yzEjsO5chF5reX/YyBr7DusOn9iLN4tZS23K/ZzgBgFaxU4IFJ8sEuBQPyfmID66oHSOjMyJIAQZT9lF8roR3Khd7XzouBGdERoaXPGE1adTRVJ/rcyN6qyibsYaSVXOU1RurVv13YH1+nF2Kq83AccgVDhm7tu/AXEbSTsGgmlUMe65zIisgNb0m4NvBq0pZ5rDcv61pc71UNRrg3i5EGErcPTHeGqYiB76bGnMYR2qRle57lTQt46xnRi4lU86D 9Y0Uss8W hXuGQgE5bZ0BVr6HAwIxlx8VRufdcMZsg3Eq1lLKoXhRKjn4GF6mroghgIsxtO9Ip6R2lOsHaXjOWKV52QgCyotsUCd24UT2hpOLyLsi1xKc03sR/qde1dz2v4+DNJ3NAhHEUGvPi27HEMhV/+yqdipkJJ0yCOnzY1EPiJqfYcKXCPvm1QJ3Ve3nGGG7S+Rxsxstz8rvk8FROh7T6JKh9+dn1rUgykT0qXz3BWR/SaVH5rj5DkLR1J8i7YDfpcPy0b8XxeFc4Wnm5W4RzGpoxcNVfPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004571, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 10:58:43AM +0800, Liu Ye wrote: > There are multiple locations in mm.h where (folio->_flags_1 & 0xff) is > used. Write it as a macro definition to improve the readability and > maintainability of the code. No.