From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 325F9C0219E for ; Wed, 12 Feb 2025 09:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97B7C280014; Wed, 12 Feb 2025 04:00:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92AEA280001; Wed, 12 Feb 2025 04:00:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F38A280014; Wed, 12 Feb 2025 04:00:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5FD7F280001 for ; Wed, 12 Feb 2025 04:00:59 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 684D747EA4 for ; Wed, 12 Feb 2025 08:57:44 +0000 (UTC) X-FDA: 83110689648.11.7DE5BF7 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf27.hostedemail.com (Postfix) with ESMTP id 4609B40003 for ; Wed, 12 Feb 2025 08:57:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NyipE4Hv; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739350662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+IuI5zXvDpkkZzSpr5OZmFLbRF4AuQK1DqlOW4Frc34=; b=G8CduqaJ+yJPBByDFkgmQ9s2cKqGrVOCWWHxVK+W31Qu68AkTSsey7NGNCyrPeqEFCaofG Vxp7CqXGDYhBqPYFxu2FGGOqf0oKlf+S40XLl3xsHdEXvpScK1ipVZHa/CaAgHvCwxUPmU 4O5VmiDR/cx+OOl9XheAY4fLYdTqYLw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NyipE4Hv; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739350662; a=rsa-sha256; cv=none; b=nP48Z7jx3MQIGegg71KoWulUN1sSGIHMzpWNVEtyj3kT96UGl6UybVDRBJX0i/ruegw22l PJw5skvLHNuxpVbfulfuEyxDnTAdOjhasr+uhN23V1SBtFUBWm6d6w8kTNLCsGj3/xGsjk L4eDQZQJJhYs9WEzZoFrCyGcKgc7ut0= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5de5a8a96abso6984606a12.3 for ; Wed, 12 Feb 2025 00:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739350660; x=1739955460; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+IuI5zXvDpkkZzSpr5OZmFLbRF4AuQK1DqlOW4Frc34=; b=NyipE4Hv9ZRwGGI3N18KycdZEMXDOcspcXcm/yb/UEvVjdxLaP8b7HJ5V8wNamUQW9 uBNAdYvUxoGUI+pLD1KHdpK5vD0VGVwUV549tggCQMWQKfl6pWF6BFNRGekAE+8kkhaI 1sqXkmhrri/0U7PrISSsXJxyYpLONLXP1e8Y78R1cdfUhoxmIhsC3W5TPKlydN8Z8R85 69FBNgZ61b5w4vM/tp4w+gl/BChjCP8KENJu2StZetIpIFAx3H0kIsEWQrvqyk76EvaK f9unDtwpKHzIzq7qJk+xJBMTGkqp8t7Yag5mGzrbpXDHxVIeIn7hGSBf8/sM+JLXLBB9 RU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739350660; x=1739955460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+IuI5zXvDpkkZzSpr5OZmFLbRF4AuQK1DqlOW4Frc34=; b=PBRbKAz+TMpE5JNgiKPiMnNL2WJF+oXUxOJlW3K8rMGgpXnofhEeVR1RKKSjGZGHdM MFf0hs7zB85LXSduMQyy1owHaQ22vcvIFcn5iaipv73zrXAIFd9C8szbaM5DiG1mDTF7 vtXWkk5/qCBQXe0dejDHhmeAuPp33ytBoLeqILqrFRErrCCpIhS5MmzZhbujh4bkk1nS P6GqnZhCeDWd4CqmYh+99h1H6QDRYMMd5MjhZ/SQ5Qopavqn7bWOsnG0gJzEBvmHh/eL 6YpPZokk5U+BklQ/XE2xVEA66FpcWhVFO3VjCw2Iz45thb/zIZ0BatN8/JBO9zuLhzq8 vHrQ== X-Forwarded-Encrypted: i=1; AJvYcCXs1xmfdnfP3FTiNK06hJSV0Qd53yaOdTXTzT+rlbeiti/HrQszl9dPQnn3cXlvqbel2bZfrwo6Hg==@kvack.org X-Gm-Message-State: AOJu0YyNbcsrqclaqoV6GZQs9K7uyeQozm8KGv4QyFflHX1LNHcpTTFj Hl66HqJ/68DNCLpMuCE989H+Bk9svHYi5tEfT9tws3HR2iDZ2uzv8ps9YX7mKPg= X-Gm-Gg: ASbGncuADweosxVS+SzotQNANeomqtbuwRMsmG5zy1DirEfgBkG+dqwrQeN5XpAPNjL EHoW1DE9fS0iRwiTX7bKLD0J5fpjQL/sL97Gg3TlTTHXG356erGv6ywtuspb+N+5WwlX1bXlOos ci2YjHlfuUF1kckVnXguAptxfLh9G/4iTxuz7jH188s/rhFtFa9ILzMpTlPsHDyUhTP3cK9LAZ9 kPrUtu/q37tyLyOpp+QPywVEIX0AVFfhXYr3LJu2Sh1cBUPDj4Szz/2eBhTSX7fuZoqI6UdGXke pR8RelbgAUk0E2v/lW0v8XjfIs+1 X-Google-Smtp-Source: AGHT+IHAlI+h0f9gQ05Wk4VO5y5MPCyT960vP5L1X6nmRum7jNTTiYbDKSPELSyxpwXSfS409hjybw== X-Received: by 2002:a05:6402:40c1:b0:5dc:ea7e:8c56 with SMTP id 4fb4d7f45d1cf-5deadddd4e6mr4918933a12.22.1739350660368; Wed, 12 Feb 2025 00:57:40 -0800 (PST) Received: from localhost (109-81-84-135.rct.o2.cz. [109.81.84.135]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ab7d062771csm422764866b.29.2025.02.12.00.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 00:57:40 -0800 (PST) Date: Wed, 12 Feb 2025 09:57:39 +0100 From: Michal Hocko To: Chen Ridong Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH] mm/oom_kill: revert watchdog reset in global OOM process Message-ID: References: <20250212025707.67009-1-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212025707.67009-1-chenridong@huaweicloud.com> X-Rspamd-Queue-Id: 4609B40003 X-Stat-Signature: eecx83uauif7hcdr85n9uh3xiugfnaig X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739350661-585940 X-HE-Meta: U2FsdGVkX18TupATGdpp4bQPh4mD2itKwSB7KFRgnbvW1+RX5lISH49+h9n5hbRGfl7T0UNof5PbUwLbN+ycrUj7VR2s7mIK2zRxAm1OzJ+y/zM7zYC7lJEzEVaG/9FNeXXFPusjwvfaAG/sQAYJRKCrah34TTIusvkxMJH0HIzGdrrHSOWz5YhfWyPnzzd+KqPqNDKMxtdavJeGGbsCe7EGhj1cwzi24JEDXDiqkiyIPxvyd+0csYbgL0SwejNFUq3CsMYrXD3VgpXzDhuDZ05nxbuMFxtyw0EcRb+67RdD/+aAfSIu1xH9SQr1SUSKA/VQK+pq2eqg/Gti6sSN3Cm8o9dtSOqWEHUt5uDqwDDVWF48XsS5q0JGmFp9cxFhUGT71fSiFOnx+dTkg30JuUlwKZxRhIdbB4waz43TYqG0/SgZ5UksU5qJvhIvwgldlWRgDuRgpvONHeDq8zjlNlUCRXH2KVMf/BFHx4Tr2QQAABWBvQEjxm/WFsK6+M7Qk9XfebsUepV/seLQ2x+xdyzUDXmFqnd02BkapPiE5TvjTNKKN4Y1AbmMJRTsXFduOf5RQpPC2AF+Wa/hxeYVJxw22A8wgy4J15mgeOXDFr8zUEZddXHbfhf2B9NvflBrU8HojV0ga2Bupd7dA2KCPvtAAlOyHJZgmtUVvW31m6UIgh5ipGcRDlAn/7qeJsCadG6i9WIeegVgPPxZoNu/++lVVcMaq0l4bmNL2UmGOeY3UzSWFhZBngC2NemsmWmoc3Q8Oex3ITWeE+2RkPXxyptdtaFrTDAQ4NNtrxdIkXo2nb+CDcxnoshmJ94HWfMB/g1Z9shCtiu4NWU7y+sMiVKApIkE4kRPZ0qqM51LVrZ56pqA3fN2ymOnJJWspjJOzDZetZ9u+trMCWGhLD9Qjfkb7gWPFmgcFt9bwq6qoGoIi0Jnl93cjKBle6/eYsoJhDRsAOKECPbnHfvJETw zQ7klJkx f3XKJ0RILx8jUXdtSwl4jOzaP4CO/Es+FIJhXozKANjYg9E2wJv3S07GducQ7tQN/jlvNzHQztccIXw0rv2CGZ1VUhxIcR6lZ5TRUcMeYgx7UKS0KkhzzAhAFgu38GENaL+qYbfV3y7SC7IllOqZryB/eQMB9/uYHau9oXJ8R0+vRJu2n6MEitXId9SjBYZ3sVFDuZEkwkQ4AaSKpPWLy/Vz15PXe7XOYhutO1aO31sOc6IRhEpKl1/UHJWkCDECYpnGa93Pb3MQOfAPn4JS2S/cHbLiwBqE/zAy0FHfeqCQ9FZnHzWvsukmHF5x3Dlx0D6C7tkp2kP46A/xX3hxXxWcZUMHmEKbJuIwQUtOWMV/t8oO6/w4UgcRDbBlg5f7RBcEEqHvbjP7bQPdrNS/umcwkDM7a5z6n8dV0z/EEqP4UUtU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 12-02-25 02:57:07, Chen Ridong wrote: > From: Chen Ridong > > Unlike memcg OOM, which is relatively common, global OOM events are rare > and typically indicate that the entire system is under severe memory > pressure. The commit ade81479c7dd ("memcg: fix soft lockup in the OOM > process") added the touch_softlockup_watchdog in the global OOM handler to > suppess the soft lockup issues. However, while this change can suppress > soft lockup warnings, it does not address RCU stalls, which can still be > detected and may cause unnecessary disturbances. Simply remove the > modification from the global OOM handler. > > Fixes: ade81479c7dd ("memcg: fix soft lockup in the OOM process") But this is not really fixing anything, is it? While this doesn't address a potential RCU stall it doesn't address any actual problem. So why do we want to do this? > Signed-off-by: Chen Ridong > --- > mm/oom_kill.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 25923cfec9c6..2d8b27604ef8 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -44,7 +44,6 @@ > #include > #include > #include > -#include > > #include > #include "internal.h" > @@ -431,15 +430,10 @@ static void dump_tasks(struct oom_control *oc) > mem_cgroup_scan_tasks(oc->memcg, dump_task, oc); > else { > struct task_struct *p; > - int i = 0; > > rcu_read_lock(); > - for_each_process(p) { > - /* Avoid potential softlockup warning */ > - if ((++i & 1023) == 0) > - touch_softlockup_watchdog(); > + for_each_process(p) > dump_task(p, oc); > - } > rcu_read_unlock(); > } > } > -- > 2.34.1 -- Michal Hocko SUSE Labs