From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E207C02198 for ; Wed, 12 Feb 2025 04:28:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE2AA6B0082; Tue, 11 Feb 2025 23:28:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B92F66B0083; Tue, 11 Feb 2025 23:28:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA8626B0085; Tue, 11 Feb 2025 23:28:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8DE9F6B0082 for ; Tue, 11 Feb 2025 23:28:21 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 134D680425 for ; Wed, 12 Feb 2025 04:28:21 +0000 (UTC) X-FDA: 83110010802.26.82B9A70 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 2DAA7180009 for ; Wed, 12 Feb 2025 04:28:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Yf6X/ZnH"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739334499; a=rsa-sha256; cv=none; b=mt8FWr05sIzWrhn/Mte+uOUOmSPor8HlmZURL0iybXUnjKOfnBSsRD9uPg6itAjbJshyHZ ROfSTG0F2BGWHjEJBLMo1/3jx5DOaEqzoibZNwlB/+g6Cn1vvbe2Pdxwr2JS/nse+lM+ZO 3YNUKKtekgLXO8sQY681VSR1jiFdJDo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Yf6X/ZnH"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739334499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HjowFBZjHeZYOplTepD05PX4mWsm7bGiAj/uMGBz3po=; b=U7eunvgeP8+LWihiwKe1VXJTKeJzTa0JBmKx64jfHrPb9OLul9dmC6EH+uff6v5hn4NSJ4 rGixUwd26T2dslWZOCsXwTg3tdWvGbeuAMy8c39CCJ4F3XRgBLFqzLLmmogGlcNGTDKmZa enq/hilKuxnf0V3e7WWxMf3j4G21MuU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HjowFBZjHeZYOplTepD05PX4mWsm7bGiAj/uMGBz3po=; b=Yf6X/ZnHpb9Wu6Dx7nt/Ty3ZnD Iqx8SMLOwhMyh3H4uvprU+fhdtU7/iWNi6eVjht2MO7GM0sLAPPkA1srVE3O4ec1J9WPBeNkYRf6v 2yBS3OVO8LCsutZV0rbw5268MvvCK/rXw+SOkFhCIkUp5PfswhVilH/CUxEJ+Gt6Zqbr8wit4LL9F 6PZ6SYy+vNYU2thcSxUY04KLzVgy4W3zfp9tbuGy1cPxJ24sPSVVYM+BXJhtulHD0K8t+ujIBfj66 olEMVbQ6kefMhH5zxVPFZzQ0FZNR/mCEcwYvaZQo6FgMpBfkXSLvkk7BnFDA2vT2z6arMlGZUdtZp Y+iS9j8Q==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1ti4MD-00000003FT0-1zF0; Wed, 12 Feb 2025 04:28:17 +0000 Date: Wed, 12 Feb 2025 04:28:17 +0000 From: Matthew Wilcox To: Shengken Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Remove redundant PageMemcgKmem(page) call Message-ID: References: <20250212020627.3461237-1-shengken.lin@amlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212020627.3461237-1-shengken.lin@amlogic.com> X-Rspamd-Queue-Id: 2DAA7180009 X-Stat-Signature: j4zx3cwmqdn5wexor8i4zag1poiexkku X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739334498-634690 X-HE-Meta: U2FsdGVkX1+O6bfze+oEc8qRSrf5u3M1nIEQh+VNCsLv0g8OEhdh/hXOaBoqcFfI+dtufTwAwHGe+5i9fsiJDeDHKh2aNuH4P/FL3Ak8QlK3AFkuPUCpW85Rkx3UToj8g2HrEA+noKmrHiE2mCpUL0JWDw6xREybX5+iqyJ0PVf7MsMhaEdknBT0r5kLBt7H2Z1gO+36Ca72S+63aF7HOAjW6w9lRUT7+Mm+YI+oAAQ1Gr+AsLGvd+BMFpDd+ksyUxlQR3p/XhY7kbKm+FTVZK7drOlP7mI3M5wAKmXjAUEPrYIeRDt65W/VRllFEBqlyBddVg4NpHWeILwQB8jtIfCvMvtLiv81kvHQPhlp5QdeNpTb+8bEWboRPz8vPzYd+VUHBCUvclVR0U17e+7Qx6saKNorWwJ/5cPcvIkjWOSWyczSFsTckiKaZd0OyPCCY/5osMSph0S12lUY0rMyg0SVjN4FKxAmrDsMKY7yfRdnKjfgQQjYSVEppkyg8rhnjc+ewUKprTy62NmF4WRtW2wAEspCfGKNinn2a00BgAr8G56JaWaEaqbgESfWldm32994Ts2NHfnfD2LRUxUAmlrvlLK78JLEcektrrWXjSpfknI/RhozqkG8N6tEsbR0PTgYGzN58s7GkuYNpWjxgH/0imvVWrCIpDRfpu4XIV6cSJ5wvMJJq8tVXjim4ywyEKTJb5Zr7/z1jV7K/3SaUZZEZGRv9svFi+j/2up49OMRLeSLV8E3DH2oILF8jxqPqBEHjiWBLNaDMIBZvFeuv6buaJ2DfRD2ya9BSz8oUlMUy6DItekulbJWWMa24DxOvpGZlcqJhsc79AC5juLtwuQomaxa5WSrDSI58G5QhDRfERPMwM+WAL4w/QCknuTNiLKXYc7HdBNsFvbQNlsduWfSYgme2PR74B30ehR/BPKUuaZ8yifOARoe8ZGWoNaTAYX1Kba+CFjjaHVVDQX iybd8NjG CowOyjgEYpDe1NIBUgzNMO6+JMTaD9/i69n+4au8YRfh+CDdZ86ANS1/hD7BR1JOrQ2jVAJBcC5SPAmBcFrNpisYnw8aLSq5oyr0nii+NavvRLEljHhH381yUT/bn+vmiQdXEkCMl2ph+6NBuBCa2nVha5lBLMxcPuhVq83TDYBpm+xywsvPZdZ0EiuLimGhnAj91mBB4wMJPJfUu4BVjWiLbHvrQeyWKUc45 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 10:06:27AM +0800, Shengken Lin wrote: > The function of PageMemcgKmem(page) is the same as that of > folio_memcg_kmem(folio). > > Since __memcg_kmem_uncharge_page already uses folio_memcg_kmem to check > if a folio has been uncharged, calling PageMemcgKmem(page) before > __memcg_kmem_uncharge_page is redundant. But it saves a function call. NAK.