From: Matthew Wilcox <willy@infradead.org>
To: Shengken Lin <shengken.lin@amlogic.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Remove redundant PageMemcgKmem(page) call
Date: Wed, 12 Feb 2025 04:28:17 +0000 [thread overview]
Message-ID: <Z6wjYQUxIstEqJHC@casper.infradead.org> (raw)
In-Reply-To: <20250212020627.3461237-1-shengken.lin@amlogic.com>
On Wed, Feb 12, 2025 at 10:06:27AM +0800, Shengken Lin wrote:
> The function of PageMemcgKmem(page) is the same as that of
> folio_memcg_kmem(folio).
>
> Since __memcg_kmem_uncharge_page already uses folio_memcg_kmem to check
> if a folio has been uncharged, calling PageMemcgKmem(page) before
> __memcg_kmem_uncharge_page is redundant.
But it saves a function call. NAK.
next prev parent reply other threads:[~2025-02-12 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 2:06 Shengken Lin
2025-02-12 4:28 ` Matthew Wilcox [this message]
2025-02-20 9:47 ` Shengken.Lin
2025-02-20 13:22 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6wjYQUxIstEqJHC@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shengken.lin@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox