linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/2 v6] add ioctl/sysfs to donate file-backed pages
Date: Wed, 12 Feb 2025 00:39:04 +0000	[thread overview]
Message-ID: <Z6vtqMB1P_t390Vg@google.com> (raw)
In-Reply-To: <Z6pNBxgMKHTiHAnv@google.com>

On 02/10, Jaegeuk Kim wrote:
> On 02/10, Matthew Wilcox wrote:
> > On Mon, Feb 10, 2025 at 05:00:47PM +0000, Jaegeuk Kim wrote:
> > > On 02/04, Jaegeuk Kim wrote:
> > > > On 01/17, Jaegeuk Kim wrote:
> > > > > On 01/17, Matthew Wilcox wrote:
> > > > > > On Fri, Jan 17, 2025 at 06:48:55PM +0000, Jaegeuk Kim wrote:
> > > > > > > > I don't understand how this is different from MADV_COLD.  Please
> > > > > > > > explain.
> > > > > > > 
> > > > > > > MADV_COLD is a vma range, while this is a file range. So, it's more close to
> > > > > > > fadvise(POSIX_FADV_DONTNEED) which tries to reclaim the file-backed pages
> > > > > > > at the time when it's called. The idea is to keep the hints only, and try to
> > > > > > > reclaim all later when admin expects system memory pressure soon.
> > > > > > 
> > > > > > So you're saying you want POSIX_FADV_COLD?
> > > > > 
> > > > > Yeah, the intention looks similar like marking it cold and paging out later.
> > > > 
> > > > Kindly ping, for the feedback on the direction. If there's demand for something
> > > > generalized api, I'm happy to explore.
> > > 
> > > If there's no objection, let me push the change in f2fs and keep an eye on
> > > who more will need this in general.
> > 
> > I don't know why you're asking for direction.  I gave my direction: use
> > fadvise().
> 
> Funny, that single question didn't mean like this at all. Will take a look
> how the patch looks like.

Ok, it seems we can get this hint via POSIX_FADV_NOREUSE. I'll take that
instead of adding a new API. Thanks.

> 
> > 
> > Putting this directly in f2fs is a horrible idea.  NAK.


      reply	other threads:[~2025-02-12  0:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 16:41 Jaegeuk Kim
2025-01-17 18:05 ` Matthew Wilcox
2025-01-17 18:48   ` Jaegeuk Kim
2025-01-17 19:04     ` Matthew Wilcox
2025-01-17 20:37       ` Jaegeuk Kim
2025-02-04 16:29         ` Jaegeuk Kim
2025-02-10 17:00           ` Jaegeuk Kim
2025-02-10 17:20             ` Matthew Wilcox
2025-02-10 19:01               ` Jaegeuk Kim
2025-02-12  0:39                 ` Jaegeuk Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6vtqMB1P_t390Vg@google.com \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox