From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E33C0219B for ; Tue, 11 Feb 2025 19:25:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE35A6B0085; Tue, 11 Feb 2025 14:25:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B92B16B0088; Tue, 11 Feb 2025 14:25:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A35106B0089; Tue, 11 Feb 2025 14:25:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 83D7B6B0085 for ; Tue, 11 Feb 2025 14:25:37 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E60AA1A097E for ; Tue, 11 Feb 2025 19:25:36 +0000 (UTC) X-FDA: 83108643114.16.D14DB00 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 367D21C0017 for ; Tue, 11 Feb 2025 19:25:33 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="k2iqrBM/"; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739301935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bu8XhFzWIupWhNNm1tqrJKrhTEV8V1mngEpQUzU8yZI=; b=NbtwohZdVXh1PUbdlnEeao/kh+MMtgW5yxgB7pK3a6G2pfrfAqmJKRF5XQbfcezR1YFqJl QS+3iddaV57lRCnp1Xc26AnGBqFD89nRUrreA64RYKkC6fvqq1Yk2h3QlsvibKmCjDAlpS 3Z2h4Hxbp/EEV0fxzCJ8D2YezbMag6A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="k2iqrBM/"; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739301935; a=rsa-sha256; cv=none; b=Bo1yTpZIi3TW3M9HHsXdOgvRTGymXT34yff48dWa670kIUYszt06SQD4fUTY6CBBGTuB3d qKQHPs4MoxMxZ24VBnKRRl3VpfmUiQ4GiUr8pf+1HaGUBM2ZksLSkB3X8Y+a/zA7oTLCI7 Ei4SfxRjGMtTqvZjLEXriz+E8cds0qk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Bu8XhFzWIupWhNNm1tqrJKrhTEV8V1mngEpQUzU8yZI=; b=k2iqrBM/xGT5VbYpgj0Enk0o8s GXw2K4qqm1huXr6SsHDxTbIWLyQax3Uc7Wbkqi+y6/cOZ9NmuzEBBZFCwBm3FEHAoyJ8BrcQwKb+E 9cyBVNyIV54fGfguuI5gGrNYrsRKnQKmoKSrHvZPxupdSS0sxK50f0yjGOYwuwQwKMYJi4qK+2dWv 3sCK5YzUwqmbHZaYJ1kAQwLWxJq1NS3506zec5qP7vaC/IbuJy4XxEci0sdkpddF1tnI+mChyBSXe HIgIhsjmOYZwLILMjrkVoY5jvjXufDSLFCnHDSfXFAiJ9l7gsKy1tCgf6Ah0hOD46kxPRRRqVajBg bleEebqg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1thvsv-000000025nM-3u1A; Tue, 11 Feb 2025 19:25:29 +0000 Date: Tue, 11 Feb 2025 19:25:29 +0000 From: Matthew Wilcox To: Bart Van Assche Cc: Vlastimil Babka , Andrew Morton , linux-mm@kvack.org, Ivan Shapovalov , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner , Linus Torvalds Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings Message-ID: References: <20250131191231.1370466-1-bvanassche@acm.org> <8b018dd9-37bc-468b-b992-2731c0270c12@suse.cz> <02cd4d8e-9451-4785-9664-0d680d5e82e3@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02cd4d8e-9451-4785-9664-0d680d5e82e3@acm.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 367D21C0017 X-Stat-Signature: rw4gmhs6pzc4syhjqztk1p8m5nk77g38 X-Rspam-User: X-HE-Tag: 1739301933-680628 X-HE-Meta: U2FsdGVkX1/bTtetQUcR8FHA+hW68wbDPTyKr55hov8QZAEhlUW5OHQLYdfyTXI9ipiyfg2S6M/IXPTSF3r6RJMYqL79Y5pq4pKcdn8LMBzu4MHWAiwcID4vFk0sLljFjTtBCvJgPWp0m9FSWx54hNlnjs9T4JGVqyFtiKof9Ef8c8vLi599PBxW9spCdjowpWgoBviXeN1MjZVpWiq6D39/iFAn4znSG9tXO3uZFflWYjNagIP0pwM2HuEBOXbD3Lh46Cri5R/ACEXE7TezuQOUP8A9CQq+Ol2h78Uy4+A4LFmAq2biVUA5cl/Kq6c6UtW1Y1zJFXoJ/rlq8IGKMX/M50dbRDuhDGAPM0+KbOhr6tQrVB9dlOXlzsNzTiO6J5iUfueIpPRtYzvjLml9/fDXB9h681qXqNcwK8GcVUIYzEnhbxwX0MqYLqheL7MM2kZRpr7PMFTM4SAPFXox2Ir1+A/wCxjt/Zzeh8vL5kqyBMiso0MsJHwAe07sS4Wjg3QSzUdsKjqBU5SziVb+xXsNusuywSGvrKGqSr4mrmaqLRpyz360ts80taTGfHnvTxjbhbB0B6DiSLCPbj1YIglBQFl/wHZOdY4vgxXUJLfVWdGVaQ5NIJM+hwhUWsiBUNAG7Gbm6n3+U2RosfAKpBXhtJMgxhPdufdyVQ/kPcKYe5fBW3WN1xP/GM2OFiqN7rPgVycIWDmWy8CoedjyoUPjOOSb1sbvpCK7ewnubAShLd2shAGGGur/5IlC9fCsonC298okH1XgOV3bQWozflxYHxP5JafGCtlKS1zcSC5Zeuf/BD93mEVaAZHrLwudA0L4Zgc2ap5dPAVwZqtQ6T431/9gDpI4LWXb9LtEE/vd1yJ0S1jho3FDiSkAJ6hN7l1GQ99P7iyF9OPmsTSmk0xLUGVidyrfE1rREQYgZsJiFYZFIQEhRJAla1Fv0rg5M2WJoCwEO9oM7j5Pcaq J8VV1EY7 azIU96xs9dt+X99Uzt1IidoubTwLMR8MZYbMg4gGduE4K8dbXQCU5OBn1SMkzXE8OQds6WoLrl0cHk3/Guv0POVuFo+Yb/cjUhTqthe3G4unA5Fp+V11A6W0KZKExQOaX2bK2oucizph7q51VMuqD85gTDtnIgO6ygLaHl9LPK6sbw17ABsCACzgrh5wb1yaTGIR4TraLx+xLQvsIF3rJqxPenLkpz+DfMcK/fc9tLSRrWKN4H2VGKbsspcCYuOSd1Gzz80TdNIwoG+YcDzfhkd3qAs/WkHTnj2dFlyVoRZ69nb4EQa3Nm3Kkgt9PP+cPMGr1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 10:48:47AM -0800, Bart Van Assche wrote: > On 2/11/25 6:34 AM, Vlastimil Babka wrote: > > On 2/8/25 11:28, Matthew Wilcox wrote: > > > this patch was NAKed last year > >> > > > https://lore.kernel.org/all/ZnXC5Xa4R0Mp7FCB@casper.infradead.org/ > > I wasn't Cc-ed on that email thread so I hadn't seen it yet. Yes, but email lists have archives for a reason. You can always look to see if you're the first person to encounter a problem. > > With the warning now in W=2, want to submit the revert of above, Bart? > > OK, I will submit a revert of commit 30c2de0a267c ("mm/vmstat: fix a W=1 > clang compiler warning"). I see that Nathan's change already made it in > Linus' tree as commit 8f6629c004b1 ("kbuild: Move -Wenum-enum-conversion > to W=2"). Thank you.