From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E38C0219B for ; Tue, 11 Feb 2025 18:44:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5ECC6B007B; Tue, 11 Feb 2025 13:44:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E8036B0082; Tue, 11 Feb 2025 13:44:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83A546B0085; Tue, 11 Feb 2025 13:44:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 613B16B007B for ; Tue, 11 Feb 2025 13:44:28 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A8E111C7EA0 for ; Tue, 11 Feb 2025 18:44:06 +0000 (UTC) X-FDA: 83108538534.10.79891FF Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf02.hostedemail.com (Postfix) with ESMTP id 9614680004 for ; Tue, 11 Feb 2025 18:44:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Wj5oNf0G; spf=pass (imf02.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739299444; a=rsa-sha256; cv=none; b=UO8ODstRAFvaZ/tcBy16QIkg6y/lvceWFRYA5KAghHV78IHADUqEPRZ6sXFyeRi9+xMIDe h4KtX10SKbnaZZqcj5SPx2j9z8Qa3tFGL/n40VaXzdcliXmXOurv4ZHF9tiKP4Hkr1qQTD aFRwlSoa3XyTu0kJyfv4Hx7mMh92tNA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Wj5oNf0G; spf=pass (imf02.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739299444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=12Y6R9YRZk8Jue/FVtlF2Z1F8YliyMggH+wBJrK9OAk=; b=nAzAdCq6xOVR4kbTgrd3VtCzzeU9WX3d20aOdeLJoW58LWpYfxzvLLdV7fb8fk/mOQIl0c 7fxgENM2agAuXzjzCZgty4xelEk9tg0L1uoYD2tqdE+Jw3Hj+8SnExuk+oqwNNdSwWqrZ1 8V7FuzU5RXN1Yl8E35TP/VUx3w3sHwE= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21f48ebaadfso100451245ad.2 for ; Tue, 11 Feb 2025 10:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739299443; x=1739904243; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=12Y6R9YRZk8Jue/FVtlF2Z1F8YliyMggH+wBJrK9OAk=; b=Wj5oNf0GgeFBzUkfM2hE7QSSwF6A/P5Xu90d2a0vIvv+pTa2W39asj+aC7y8gqiHZi zhfMVBpAwBmx9CSmee0tXbLF2/7kcpkcfbGI9YdRJve3dq4AaZdSwcQ/KMjXm+9gGtyU A3Va/i3vcjUS0Pes+X6TJFLG7gc46KxDdHEwKJ0LAr2NeRDgy6yYEH4SUV7z17Y+FmfK lEISnZkqQdcSpdFiSL1DWgFSY3AXq6+kLXx97oERtB6smjnYAsJraaXFYR99b3gIJDun jkcb0lG7CrzCqwXc0XMKUbB+R6lN5fpA7KQm00sG15yIIBsuAikZp5OtJ33zwqgT4bfE K/DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739299443; x=1739904243; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=12Y6R9YRZk8Jue/FVtlF2Z1F8YliyMggH+wBJrK9OAk=; b=MISwFOP4CyHg8uDS1y5ofSje41A4+QjCILNnoJO8ExMGxpIQ0jaFHKqFvRmvUHI0rt tHIyT3LD9UrHnleXKYWqd5OpObT1KJA5fs3Pm9+DnviXkzWbsD9uEmpmEhNG8WaMe4aA Bu6bsJqXNk6WiaAW0Kqwn5FZ3lQr/r0c0VSgYAjAhnBDDgG6QZuVpphJa4oRF7EKizeY fMQOlw/V1lJ8nIygMYLMAQJjhiNqowy+YSOFYp360ysBnYwDS8X/YSYdhbLHOCXu9xSE qmZQ0/Ik/sDiSa4kzJ3/P2Y2CwvvSYQFvBU9+9Y4BvOaTTVwDEygeWfOB3gzZHfaWxTv KR+A== X-Forwarded-Encrypted: i=1; AJvYcCXtTulVjvN2wwtlbUyjQxBaoUxv81pUxh6svmjysg/EGNuQWMO83XQOEt/PB6EoK37ENsqufqixng==@kvack.org X-Gm-Message-State: AOJu0YyyrR7I+4Lr2RXO+Agk7lfasGmoRy3M8yJjrDm+HihwTLppCt7r nw6TmDLTg/iPAxKa8Ob7nNiJnU1bDEAHd+s2UC7piXwLkfC79ION X-Gm-Gg: ASbGncvhJigHl3PkXwNqXVToyNHFVNjaok2nndiuC7tMXI+S5vjnZr08/LpvXZo2OUH hAvcoJOTtVbQlxlq/BPJ+hEYqjev1td0JC/xnkDgACNtCzxqrDk9rSdm/KKcimgFQ1L6FdWV061 QxrjnXalA37GZeCnyIy7DJAfiilpx+DZ1W5JfPJvNnTqX/tZgA0hKm/Fe8qldnkVKOMYakgFsuV cyqkbXO1WeQh9OOC+u14wC1ZS0WCBwd4k5h2V9ddy4mGKuUnkuxorBrvVQuZGV0eZIFisvPuXcW B0SOtw== X-Google-Smtp-Source: AGHT+IFkGi3oAlql1pNuNzs7aio5LNXqemb+oRz2/bDSC6hWtZUaUvFojExrPWEhZjADSKbDaLK6dw== X-Received: by 2002:a05:6a20:2d12:b0:1ee:2550:e811 with SMTP id adf61e73a8af0-1ee5c739702mr680238637.14.1739299443297; Tue, 11 Feb 2025 10:44:03 -0800 (PST) Received: from fan ([2601:646:8f03:9fe0:a440:5911:e4a4:e315]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73218c206a6sm1879443b3a.49.2025.02.11.10.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 10:44:02 -0800 (PST) From: Fan Ni X-Google-Original-From: Fan Ni Date: Tue, 11 Feb 2025 10:43:48 -0800 To: Shiju Jose Cc: Fan Ni , "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm , "a.manzanares@samsung.com" , "nmtadam.samsung@gmail.com" , "anisa.su887@gmail.com" Subject: Re: [PATCH v19 00/15] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers Message-ID: References: <20250207144445.1879-1-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9614680004 X-Stat-Signature: gpte8yqyg973snbup3npxieqsc8bid7e X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739299444-346757 X-HE-Meta: U2FsdGVkX1+rqH10H80/Ygq64lCPF8SjG4bcROHYwXYXvuuv4T6aqxYaTB/7gRbBNtMJekU26hD1R+A9L2Fr/ffPfSMUm5FiVoOGfjTMKQGvDDWvgHH6i1AxTax66yucqxP+ZEgEyJ7URcJVJ8JeL+FMMiGo62ZdrIBG4sPQizI16aMyPsBW046GLQbLMSjtIYekTgfa8opYa14cjoy7k1Hk0NtELpbjDiiwK8WZtnY44HtbNdr9Gle9EbCsosVh2efc1FRL5zurWrPfpPw9NumRCRir2tQbD80HDfQRsg3c6KCa3qXIBE9zZEtqBFOU82wxGHFmd5Fu6jpwNDaOzS9H3K+u/1VsbTIRG4+4dOmTZkgty7Mr5Lq67+XPjRWqog8ad5o0vD68NAp7BSBrQesZGXy+SW5CrNWOToodJJCjz80vJfF81xsVRhEFwq5xsbbvSQssv9r+eFoOEWLKZbAG81jcISlOCt85NGqO0/I0gxVXbChxj8x8JzV09ANahTxqeK2gC0gRuwoGIDdMMpknFTPw/2f+m3Cs6J2WKiF54wFo5R8yD/+fzuUVDFwjl8ZjJzg9SlO33PRv4N769vM4vfN+dC04cpaX48xeLKynHKs0ZqRHXtJ1tZC8D/or4xWjCqeYKM7udvaYMncbdKK/uOVXPXepBSz6xB1g+3fLtrZQ7RtAMtPRQjN+18HWGGEMz85JQb4C4vs6lo79vk+drluNhy85zhDBL9KhWzTyu2Mixaw6v8LkdvCtbjnQ3P5P9rcZk4e4ne7ZqQtwFaly/VzAiZLGraVJsZ+R5Cix/xAPxV4ysDyv9eSaxMNFEacGGVd0LUMciIw1ETvyTbSWK/RJvyGnYIg2LPSm9RaWU4nBYVOvUuczcF4Oor0yLTyGPAFc5ic1+LuxsLPJTZOtTHyE1/yCBtVdQcrfOoIL4OWUAiyEbCducdCWpSjKwP1chySXdk24+vMQUpe /tzurB7i vEUNJ5BmEhceXcewB6Ft+ltWz6bh5aLiHvVK0BgAeLgGw9kaw2Wj1T6o4YITCfCe37hR7SgbYKbxesxk0C91nJDJCZaaNtrxiSq0ccfmsctg1/ZD6JZPcT6YjD/VJI4JAZUQuv2va2aAvD7Y6QVHi5PYnn8TQ+zn7L+N7ezhMmQz3F8df813ij2bPIA8T0B+ru+ir1sqfAaZp+VHBE7GxsT6QAcVnr+tUJWdmNtKncVDXlC5s/Yo1iiAx0MJhPVGi295ZU72xoe+RCKq6mxfY2+Jk9kVzweynNEGMmLYRTJO6OD5yms/aWKl/NxCWPoeA34M6aS11jOH43w+2Nvm2glA/bCcfqy+Jfn900JpErrP4gRNj3y+sTBLSId46FEe696Ng1a4xfZ5pSyACn+oK8bC+VsyOC+w1925Pxx9ioh0cS5J5fi4jKU+6cIuM8j6e3khfpttP+RKYJcgwNrglw1rzEr+JUWOv3pMyZadLgcwq+Qa6xFujibVACPORNRInWk8OYQGCQn3jmUSEG73AfMj4vScH8bDDNK3zcQS+B72JFOvbf1ZeUW5bCbAgMvHh29ngiQjEOlYOSsxKdqEA4gN81SaifrXCscC/FW5ISFLy09Vyh9xDm9eY84fWrdN8cclS9qeXKY0HIyUXRykHEhCaBNFnRa0F68q5I8pS0Yg5BaJcaK03nrfjiOtyFMacKHYisRJgUWgbIe6Uu6/gRcbcFi6DdLbA95E3HGayiGigecg5cmgmQXDwzIxHj0SvDPm5OAAJX2PyAuGFqoFhWlO0rwdtUIFPCmABHUYnGdON1fgvUv30RHLKF+JTlsyIl1LzbH47YwF910KDxzRhGvY18swBSQ/3o4LltDGaOprQ1W9rGhVvgeA64L5P0rYaPgkqrmzk9lT2/b2gSCqfXFMfLzMhE71i1nRxCNgZdHvQxhZjsJLiza6u1PyAym15cOen4khiR0Jki7Ciup1ZWDbX0zzB UigjkHLj AxkUn/1H1n+Ek78iGb5OOvXtqmz+TprmFZAqJdu8lTu/t4QtZrXyBKDTRPK1DApaizTz2JJ94GNYJKG+intceokitkRLR2VG1345B1kNmiywSyrr99aP8ZxtQVxQKD9fefOvXE5DlZW/STe3MeE2qmbE9wDRcvXKns4buft7cGnUz5fAenK7FCT4AJoDEGnLK043a3DHla8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 04:55:49PM +0000, Shiju Jose wrote: > >-----Original Message----- > >From: Fan Ni > >Sent: 10 February 2025 17:53 > >To: Shiju Jose > >Cc: linux-edac@vger.kernel.org; linux-cxl@vger.kernel.org; linux- > >acpi@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; > >linux-doc@vger.kernel.org; bp@alien8.de; tony.luck@intel.com; > >rafael@kernel.org; lenb@kernel.org; mchehab@kernel.org; > >dan.j.williams@intel.com; dave@stgolabs.net; Jonathan Cameron > >; dave.jiang@intel.com; > >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; > >david@redhat.com; Vilas.Sridharan@amd.com; leo.duran@amd.com; > >Yazen.Ghannam@amd.com; rientjes@google.com; jiaqiyan@google.com; > >Jon.Grimm@amd.com; dave.hansen@linux.intel.com; > >naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com; > >somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; > >duenwen@google.com; gthelen@google.com; > >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; > >wbs@os.amperecomputing.com; nifan.cxl@gmail.com; tanxiaofei > >; Zengtao (B) ; Roberto > >Sassu ; kangkang.shen@futurewei.com; > >wanghuiqiang ; Linuxarm > >; a.manzanares@samsung.com; > >nmtadam.samsung@gmail.com; anisa.su887@gmail.com > >Subject: Re: [PATCH v19 00/15] EDAC: Scrub: introduce generic EDAC RAS > >control feature driver + CXL/ACPI-RAS2 drivers > > > >On Fri, Feb 07, 2025 at 02:44:29PM +0000, shiju.jose@huawei.com wrote: > >> From: Shiju Jose > >> > >> The CXL patches of this series has dependency on Dave's CXL fwctl > >> series [1]. > >> > >> The code is based on v3 of CXL fwctl series [1] posted by Dave and > >> v3 of FWCTL series [2] posted by Jason and rebased on top of > >> v6.14-rc1. > >> > >> [1]: > >> https://lore.kernel.org/linux-cxl/20250204220430.4146187-1-dave.jiang@ > >> intel.com/ > >> [2]: > >> https://lore.kernel.org/linux-cxl/0-v3-960f17f90f17+516-fwctl_jgg@nvid > >> ia.com/#r > >> > >> > >> Userspace code for CXL memory repair features [3] and sample > >> boot-script for CXL memory repair [4]. > >> > >> [3]: > >> https://lore.kernel.org/lkml/20250207143028.1865-1-shiju.jose@huawei.c > >> om/ > >> [4]: > >> https://lore.kernel.org/lkml/20250207143028.1865-5-shiju.jose@huawei.c > >> om/ > >> > > > >Hi Shiju, > >Is this series the same as in branch > >https://github.com/shijujose4/linux/tree/edac-enhancement-ras-features_v19? > > > >I hit some compile errors wen trying to test with the above branch directly. > > > >Here are two cases where I found the code cannot compile. Please check if it is a > >false alarm. > > > >Case 1: CONFIG_CXL_RAS_FEATURES=m ... > > > >fan:~/cxl/linux-edac$ make -j16 > >mkdir -p /home/fan/cxl/linux-edac/tools/objtool && make > >O=/home/fan/cxl/linux-edac subdir=tools/objtool --no-print-directory -C objtool > > CALL scripts/checksyscalls.sh > > INSTALL libsubcmd_headers > > UPD include/generated/utsversion.h > > CC init/version-timestamp.o > > KSYMS .tmp_vmlinux0.kallsyms.S > > AS .tmp_vmlinux0.kallsyms.o > > LD .tmp_vmlinux1 > >ld: vmlinux.o: in function `cxl_region_probe': > >/home/fan/cxl/linux-edac/drivers/cxl/core/region.c:3456:(.text+0x7b296f): > >undefined reference to `devm_cxl_region_edac_register' > >ld: vmlinux.o: in function `cxl_mem_probe': > >/home/fan/cxl/linux-edac/drivers/cxl/mem.c:188:(.text+0x7b8ad1): undefined > >reference to `devm_cxl_memdev_edac_register' > >make[2]: *** [scripts/Makefile.vmlinux:77: vmlinux] Error 1 > >make[1]: *** [/home/fan/cxl/linux-edac/Makefile:1226: vmlinux] Error 2 > >make: *** [Makefile:251: __sub-make] Error 2 > > > >When compile with CONFIG_CXL_RAS_FEATURES=y, it can compile. > > > Hi Fan, > > Thanks for checking this and reporting. > > This error is with CONFIG_CXL_RAS_FEATURES=m and CONFIG_CXL_BUS=y and CONFIG_CXL_MEM=y. > Now changed CONFIG_CXL_RAS_FEATURES for tristate -> boolean as this implemented only interface functions > for the CXL RAS features. > > > >CASE 2: CONFIG_EDAC=m > > ... > >fan:~/cxl/linux-edac$ make -j16 > >mkdir -p /home/fan/cxl/linux-edac/tools/objtool && make > >O=/home/fan/cxl/linux-edac subdir=tools/objtool --no-print-directory -C objtool > > CALL scripts/checksyscalls.sh > > INSTALL libsubcmd_headers > > UPD include/generated/utsversion.h > > CC init/version-timestamp.o > > KSYMS .tmp_vmlinux0.kallsyms.S > > AS .tmp_vmlinux0.kallsyms.o > > LD .tmp_vmlinux1 > >ld: vmlinux.o: in function `devm_cxl_region_edac_register': > >/home/fan/cxl/linux- > >edac/drivers/cxl/core/memfeature.c:1720:(.text+0x7b665d): undefined > >reference to `edac_dev_register' > >ld: vmlinux.o: in function `devm_cxl_memdev_edac_register': > >/home/fan/cxl/linux- > >edac/drivers/cxl/core/memfeature.c:1697:(.text+0x7b7241): undefined > >reference to `edac_dev_register' > >ld: vmlinux.o: in function `ras2_probe': > >/home/fan/cxl/linux-edac/drivers/ras/acpi_ras2.c:363:(.text+0xb0ecc8): > >undefined reference to `edac_dev_register' > >make[2]: *** [scripts/Makefile.vmlinux:77: vmlinux] Error 1 > >make[1]: *** [/home/fan/cxl/linux-edac/Makefile:1226: vmlinux] Error 2 > >make: *** [Makefile:251: __sub-make] Error 2 > > > > Here the symbol 'edac_dev_register' can't find with CONFIG_CXL_BUS=y CONFIG_CXL_RAS_FEATURES=y and > CONFIG_EDAC=m. > Modified CXL_RAS_FEATURES depends on EDAC=y || (CXL_BUS=m && EDAC=m) > to fix this. Hi Shiju, Did you mean the following fix? diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig index 77baef31cf3c..8615f329baa2 100644 --- a/drivers/cxl/Kconfig +++ b/drivers/cxl/Kconfig @@ -162,11 +162,12 @@ config CXL_REGION_INVALIDATION_TEST say N. config CXL_RAS_FEATURES - tristate "CXL: Memory RAS features" + bool "CXL: Memory RAS features" depends on CXL_MEM depends on EDAC_SCRUB depends on EDAC_ECS depends on EDAC_MEM_REPAIR + depends on EDAC=y || (CXL_BUS=m && EDAC=m) help The CXL memory RAS feature control is optional and allows host to control the RAS features configurations of CXL Type 3 devices. With the fix, I still see the errors with following config. fan:~/cxl/linux-edac$ cat .config | egrep "EDAC|CXL|RAS" | grep -v "^#" CONFIG_ACPI_RAS2=y CONFIG_ACPI_APEI_EINJ_CXL=y CONFIG_PCIEAER_CXL=y CONFIG_CXL_BUS=m CONFIG_CXL_PCI=m CONFIG_CXL_MEM_RAW_COMMANDS=y CONFIG_CXL_ACPI=m CONFIG_CXL_PMEM=m CONFIG_CXL_MEM=m CONFIG_CXL_FWCTL=y CONFIG_CXL_PORT=m CONFIG_CXL_SUSPEND=y CONFIG_CXL_REGION=y CONFIG_CXL_REGION_INVALIDATION_TEST=y CONFIG_CXL_RAS_FEATURES=y CONFIG_MMC_SDHCI_OF_ARASAN=y CONFIG_EDAC_ATOMIC_SCRUB=y CONFIG_EDAC_SUPPORT=y CONFIG_EDAC=m CONFIG_EDAC_LEGACY_SYSFS=y CONFIG_EDAC_DEBUG=y CONFIG_EDAC_DECODE_MCE=m CONFIG_EDAC_GHES=m CONFIG_EDAC_SCRUB=y CONFIG_EDAC_ECS=y CONFIG_EDAC_MEM_REPAIR=y CONFIG_EDAC_IGEN6=m CONFIG_RAS=y CONFIG_MEM_ACPI_RAS2=y CONFIG_DEV_DAX_CXL=m ld: vmlinux.o: in function `ras2_probe': /home/fan/cxl/linux-edac/drivers/ras/acpi_ras2.c:363:(.text+0xaeb5c8): undefined reference to `edac_dev_register' make[2]: *** [scripts/Makefile.vmlinux:77: vmlinux] Error 1 make[1]: *** [/home/fan/cxl/linux-edac/Makefile:1226: vmlinux] Error 2 make: *** [Makefile:251: __sub-make] Error 2 It seems ACPI_RAS2 depends on EDAC. When changing CONFIG_EDAC=y, it compiles fine. Fan > > > > > >Fan > > > > > Thanks, > Shiju -- Fan Ni