From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03227C0219B for ; Tue, 11 Feb 2025 16:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70AE5280008; Tue, 11 Feb 2025 11:12:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BC11280001; Tue, 11 Feb 2025 11:12:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55C6C280008; Tue, 11 Feb 2025 11:12:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 36B51280001 for ; Tue, 11 Feb 2025 11:12:20 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C7FA9AD7DD for ; Tue, 11 Feb 2025 16:12:19 +0000 (UTC) X-FDA: 83108155998.11.F4C94F1 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf27.hostedemail.com (Postfix) with ESMTP id CA2354001B for ; Tue, 11 Feb 2025 16:12:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=G+Wx3Dzb; spf=pass (imf27.hostedemail.com: domain of qperret@google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=qperret@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739290337; a=rsa-sha256; cv=none; b=ORY2+Gy8Xug6PnqC2sG/n4YXknailuhE1c6l5nt7+r3p/KCVXb2D6rFiCASgj47/Wmvg0u kAhhvPaujBAxZz/3qQccAdQtasz3RkCr1yZujLRsDDGhJon0rtof1rHxLPsR3gpbrRbu+F pxSdCnxTIeAimHXq/bFam+Uf6BtA3ik= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=G+Wx3Dzb; spf=pass (imf27.hostedemail.com: domain of qperret@google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=qperret@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739290337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ksYhiNxYXxIQXSCUbIP2PVxMkppBVi7a3p8q7qKHPhU=; b=QDzchRuK+C6UfA/TKa/vGpBZDXD8iCh+A08nrigqxYatoLQ+ph4aW1oIs9yTy49EH0685k 5Nhv1F1tqQoVUzf4sc2ok/VoDarDoPQX6CoIpqPcHhB3wJTl30vA69rwvwOoHBrc8lGguX W0BU03TAWeqy5xOEAcV0rbueCRrme78= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ab7e80c4b55so124714966b.0 for ; Tue, 11 Feb 2025 08:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739290336; x=1739895136; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ksYhiNxYXxIQXSCUbIP2PVxMkppBVi7a3p8q7qKHPhU=; b=G+Wx3DzbYrEmTs8Z4Ib536KcYVGptGHTQRtte+uvvH8enHHqBuFNCehfIPmzlwQM1x PAZp9ypSyskA7tQHxglAc+eUzuuigaoXufx1QCSQN93X3lldTYvrSH70pk5xcq4fpEMA lpr0TudDvHjDN8Qv5eLO+6KZCc5RyDduzGLxtGXe/QPBqOB6gFONU16wS6JEgbLpTsab 27V/LYsDvupSlIHv6O8KA3+6Z1WGnCkdb1Y86xNGbzu7U0rKYESxuT1SOfCHgM6SqcyG +3aXeONyqc/txvuOVJGWsCdNZQuHklj9AL8Uu9+rKGUCRTk97R9BnDxE94K7+TgJP4Ot M1gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739290336; x=1739895136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ksYhiNxYXxIQXSCUbIP2PVxMkppBVi7a3p8q7qKHPhU=; b=HrI8vcW8CAncvz0a2X8xi2MKsTpeeMGQTw8JVk4hl/LdmEKspcjZAvrb/qmibV+Dro cdnTH1TBQJ2pnp7ndMF63vUJQJJ3uXhEQkjdC99cRVILJlJ/C66DRnxs+SwFpnXSVVUa EFD7rXFNPs0mAah95n4h/U3guGKolseplnGAQD/CMLCOOHn1VEKTVObrd+gyqAKUUCOc TzhfWrvIeL7Rmv/qhXwnSX4wb8UxzsyH4qZ7ut3ERaxCAjzITBvcTSKWyK3VlsMPy1CN efXxSl7NRMo3JXg7FNkHuZAuuQcceKCLsYVKpQD7wsk1V3zlPBEJFYKJ6toUEClKhsOj d1GQ== X-Forwarded-Encrypted: i=1; AJvYcCVvCW7FiL2kvkcQiji87F9Sn7OhKMektsHTimHplLJNaY71YMnh4w9Eps3aw8pMcf+VRz5ozxK+SA==@kvack.org X-Gm-Message-State: AOJu0YyZUwoRTJoEfYcgx/ERy1zfrJdDQFDZzlOscjVh018MlgsyULob LpxnC8OVSn79IOAA7DbzAL8r+kkCRvlGZkrVcorLclEnhFp25OK9QA+456pEAQ== X-Gm-Gg: ASbGncsDVLBrZoXmZt0mE69nAGAkBNevO4QFA6hyAnbFuI0dXIKV17k4+Cb8oz8dBx3 j+g7N5Z/vYE6sOlRl5gCW4nktNYqG7TocPGBPoWfy14VLN/yQa+kjbXuZzz0md67ORWnCMmlq41 XMz45u/+/FLjwb84r1tnL1H2fFZZypxyThOVJeehbjE0q53u6fcVNtpIEOZ4P2pUGwHkibEe4Pb MSY9ZLKt4tp69N6Yo6wqr4/k/S77KpKnHcnOD0hxPvI85+UzkK96OBLhSJ9uGCc4ddXbUTocFtO Yj4j8EBTnwABOIl5hyufgv1Hi5OfiKyKgCjObXxm00v1tjhevCqF X-Google-Smtp-Source: AGHT+IHArNcP+f9MjN7EP3uzU7DHYs7lXHuAPyrJhIGf+osevoSlQPPB7u5M+tNFRK6c5XzjVmPf/Q== X-Received: by 2002:a17:906:c146:b0:aa6:96ad:f903 with SMTP id a640c23a62f3a-ab789bcb704mr2131203366b.31.1739290335795; Tue, 11 Feb 2025 08:12:15 -0800 (PST) Received: from google.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7bcd53bf5sm467078566b.87.2025.02.11.08.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 08:12:15 -0800 (PST) Date: Tue, 11 Feb 2025 16:12:11 +0000 From: Quentin Perret To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Subject: Re: [PATCH v3 09/11] KVM: arm64: Introduce KVM_VM_TYPE_ARM_SW_PROTECTED machine type Message-ID: References: <20250211121128.703390-1-tabba@google.com> <20250211121128.703390-10-tabba@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250211121128.703390-10-tabba@google.com> X-Rspamd-Queue-Id: CA2354001B X-Stat-Signature: mdrat8chbtqkq8ap5at789p5c6entpb6 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739290337-50854 X-HE-Meta: U2FsdGVkX1/JsblLdpjxugxnxsaXjb+kTi6zZ2JlvXkbY4d0EtD3UOFf6QjAxY3ObK+8nq/7Gdd7q00JazYt/fBUkRvTmooZRMqrwEI6BR22akTcOnDxLO6XjldiDgGkdlNPua9FXcQQ6SxHxH8xvyeoLzmLFDnEUUFZHAQP8aCO2xJ8qUX1io8UNgCA6kk/VanImPUIa2WyEh168TfwAYjRDVVNL97CBXXQQ7X0polcbNJMoYDOYSGZt7GpuxK/9yy/2iZwwqFAFng8JhbnMdTJQ9j121nBFOK7s4ICxgyhnh7yhPerneHn3XI3OajN1pw6PCadfgJuBtNscKTlAuv4R9nYGGQalIZ7Sw2dtmELikR39QJ6+Sz0Bxmv685a9SItv+NQrjXOtZI60ZR11cp3wC4ZU3n6m/9jWK5Cv6IyN6y6iHQpT883CZ1cA6ouz44weLoOrqeZyFzVK9lIML3fzbr4fD6BWEVQDrTpAdiSamhCJ9HPVAdb7Uy4o5KQX/REvn/PRz3nxUlr22P+DTokrjWtfzLmACEDNqbcjKlBwzaQCQ1USCDnX7k12SmiVEtRmgGbdSDHrPY8qwkg9FsfVUZaL8UWVwND7PcL1QEGFcD/IhtOJCmQ51kRNfOJKp2Xvs7qEtTMU3S0b9IDmNp4sEYkn8F2fx6GPypZqn7k0xabdcwOJGfcg9GzTEdUtQHK8bk7SZuzRksV9fUQ6x7CXs3vCv0N19XU1uUj/xnsDL3jK9gbw8pAWohgtjxSBXiLTKsPf4Bxgfv1FJg07WOjV0Q8zEe8dtkriOITA+kbQ17EcramlDx303WFlJvvJkWhhocrj7XOCgPxwFSpp9aDvbREvmJTIxwafif9U4aO7CeoTISFf0N8SlYDjFCpcXlCvsHM+6KRJIhpOv69RBdbaGU5fCv3eyeNfrjXQouhaRu/arMfA6zu2fGB19VmFzX5SW9tjJTnBWqAHbu iH5SdO08 acLGNs3h90gbAYqt7XbuiazftUdG+TIfgKC89Lx40yaZtpvOgLTawGVSK01ZUqWsfwjT0eq3ioCcXLjF0YZA4JxzY8UR2k3QiWbkOa5S7FTeSEioni30IVeNNqNUK+tQMl/4EtLsRcK6tL7mVPO4mdFNmh/Cr7z7qJRAzrcoq+iaj46mRX3jODLYwEU1fwmwOAGLdM3GvGqVdr43NtoT2ZsyyTQtbWMYNnpCY1/Gg6p0KloRCparBaiieBAWRZwlgLKEp1NON7O4SLLyVM5U6AqmUolDcTC8P1iccMssTRp9/cVhdpDLRcxIeuK7qDZmLVsPeM6Gm7e8blezNTdQ9ZwwEoXj6NkDR6Z5FBNxs2I+aMUjHGowJVn3bINJoWQ5ycLFJKv6Z/DxFyFLCr5FvLqvWp23+dtTS6Qjivxi/VtdLeBFLXb1JbqKYLM01+nh0kWJiD2zP4EPHwRo+i4sWDCnSCIyQ9MxM8KqM X-Bogosity: Ham, tests=bogofilter, spamicity=0.001980, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Fuad, On Tuesday 11 Feb 2025 at 12:11:25 (+0000), Fuad Tabba wrote: > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 117937a895da..f155d3781e08 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -652,6 +652,12 @@ struct kvm_enable_cap { > #define KVM_VM_TYPE_ARM_IPA_SIZE_MASK 0xffULL > #define KVM_VM_TYPE_ARM_IPA_SIZE(x) \ > ((x) & KVM_VM_TYPE_ARM_IPA_SIZE_MASK) > + > +#define KVM_VM_TYPE_ARM_SW_PROTECTED (1UL << 9) FWIW, the downstream Android code has used bit 31 since forever for that. Although I very much believe that upstream should not care about the downstream mess in general, in this particular instance bit 9 really isn't superior in any way, and there's a bunch of existing userspace code that uses bit 31 today as we speak. It is very much Android's problem to update these userspace programs if we do go with bit 9 upstream, but I don't really see how that would benefit upstream either. So, given that there is no maintenance cost for upstream to use bit 31 instead of 9, I'd vote for using bit 31 and ease the landing with existing userspace code, unless folks are really opinionated with this stuff :) Thanks, Quentin > +#define KVM_VM_TYPE_MASK (KVM_VM_TYPE_ARM_IPA_SIZE_MASK | \ > + KVM_VM_TYPE_ARM_SW_PROTECTED) > + > /* > * ioctls for /dev/kvm fds: > */ > -- > 2.48.1.502.g6dc24dfdaf-goog >