From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 536DEC0219B for ; Tue, 11 Feb 2025 10:10:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4ED6B007B; Tue, 11 Feb 2025 05:10:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5DCD6B0082; Tue, 11 Feb 2025 05:10:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FF446B0083; Tue, 11 Feb 2025 05:10:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6FEB66B007B for ; Tue, 11 Feb 2025 05:10:02 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DC21D1C92F0 for ; Tue, 11 Feb 2025 10:09:52 +0000 (UTC) X-FDA: 83107242624.25.D38595C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E8FC51C0003 for ; Tue, 11 Feb 2025 10:09:50 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M6DcKNHA; spf=pass (imf18.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739268591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vESXwtruJGbx+75bPYc0hWkP4ffIGUWG2LusBWyhBXg=; b=GLYMs3JSdLq3gNvOFmL5vnVttm9w+9b4VXt1e1jHfxgYvboVInqwKlE0ub6Ar3srrViMcW JzNliVBE7kZSzwFCnhX6Sj4jQW8RCuuQ52tyohQmpt44jDhrpsfSjNZgfvjTq4MGdEZ1We ZiOzjc/qOH6BDa6hoGYQ3EFUJTqv5V8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M6DcKNHA; spf=pass (imf18.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739268591; a=rsa-sha256; cv=none; b=iq31+jj4PX74yLB2yo04a2AHSBkkWRoiFGXdLuZDIWa4hQtd/TrtWoFmfP979bkOv19Vkb B1HQoIlrULvQAVCeaZO2V2UKcX1EFA03VlSPvGQSzzI1TCB183LFQupm64uooEh4RA/4iI Swmjjti/edG1ethgl+Xpcvzef1fv4aA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739268588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vESXwtruJGbx+75bPYc0hWkP4ffIGUWG2LusBWyhBXg=; b=M6DcKNHAlg2tvAuIWhOf902Z+FWyBgVc7h/5uOedtQUT+o7biQ/RKdvEUbGAN2VbmS8W+9 5GlkVJEq7HSfUfWY8ug5YeG6nE2FuiLp8r3u4MZNSvL+a+vaHxJiKV6ciUtvUg0tAf4w8k 7/HavUMRKsIbxKyYpc0D0yEuGocQYFU= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-Q0vgbHaEMyqFbqtab1GcOA-1; Tue, 11 Feb 2025 05:09:44 -0500 X-MC-Unique: Q0vgbHaEMyqFbqtab1GcOA-1 X-Mimecast-MFC-AGG-ID: Q0vgbHaEMyqFbqtab1GcOA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4E07B195608E; Tue, 11 Feb 2025 10:09:42 +0000 (UTC) Received: from localhost (unknown [10.72.112.8]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 957DC19560A3; Tue, 11 Feb 2025 10:09:39 +0000 (UTC) Date: Tue, 11 Feb 2025 18:09:36 +0800 From: Baoquan He To: Qi Zheng Cc: linux-mm@kvack.org, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/mmu_gather: remove unused __tlb_remove_page() Message-ID: References: <20250211034348.39531-1-bhe@redhat.com> <616b5fdd-0f15-485a-b5fd-cdd6d7fc9d45@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <616b5fdd-0f15-485a-b5fd-cdd6d7fc9d45@bytedance.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E8FC51C0003 X-Stat-Signature: 6bh9f886b48fezch4s3g4n6fi3qbkfi9 X-HE-Tag: 1739268590-492718 X-HE-Meta: U2FsdGVkX18wlx5f93Hzf0pSwpojvGox5EJwwymSI6MBqgTg+PwgP99pxxE/wASnrNnvTKBDX0O/giJPEqP3ho31KB/AZDZ2Ctn/qfSNjp7DTsM2ZuTNbTYWzXAzRARsvdl8wmQPlDRkWt4YRwPgzv+J9RzPdsdWna4cujEutV47xk0mKMNAtmsrHrgtyK4rLPiJOjhV7zLgUrP/qmNAFsQFgMjoIuUQSejMWNzpA9gBpa2znGW5own56RtwTrm+4+ayxmZui3t+y3fidapi/gu5sNdTDZ0cpyLEcu9lOIp1rnZ5N2pa8XwOtchL26xFUZ+X13RmJK9llbkB7b0Rmlie961jvYmj3xVksFZLqVdHPw/bv+cLZeY/5H3mfY2wjPC+TiL+6ZlR6u/Ay0aIw+f95q06qK6MGp8i93Zd+ZCfkMHgYEWV/UxaL1Jxjj3NnQhzbJg/2lF9Fzs/4RDj3iVYx2GmbuI4Wk6T0ywWYX+UA+AVAE9i7XAfWfnEt8ARvE57a/0yRC4aZjpRdLQwT0x0QYcEIMTZjO1FbOM4rBHGc4VZRSXZvOTcOGW/ZEb8vYTpG6CfY28s8o2lLbHtYYqS2bMerPss8iCOpWRYugB1hibiohWRJiVzzCXllzeqVK/00eU1iyCuyaSDuqbImersXLEvDNmaJVYpiuTLGactC5H9ULO43FUmMmNXyTt8ntP96GbGEyHVNhW6C6elSteD+MG1XWlD/NV5ELBEJXY6z28FAOeKhRIdG5G/vaPFxIMLp8B3JOHQrsFtcUBxRnaRUrSkzlwhlH92RFdMkRWPqeRGoCksFJ52LeDmnUaWkSVNRDZFEChDvK13y6ps2tNtQ8z0kn5t9bo+4TirpPWIFswjyjvffYpZ2nW1BkT1quNpFFIn21EFu/G5lHiR3KlQTqHtMn36Bx3s2fQlTCSnOhjCt56XuvaNLxzvSFC4oH4pROgbRAw7mavSO8O 34BDZpV7 LgipxEC1U/yjh1Z+gPNB+LGijQc0PLtXhSv7gXSic1wpYFGDgYQS3Ok3qVBz3SUumpozear+Puu2ubN8GUd+J++8L0zTjbArGbsEiJbqWLc7q8pXVYEseoc6/22g6oE7mKUXD+/jldmxkDdMxeDoA+pBJw/RirvrEG4OIeon3liPtPkyHr6GVUZqeaNcca9Eyti80aCD8JP2VUL8eUAD78sA0dhrmg53p16iaH8ME+J8+U8n+V2wksYEiskbJS9uh1Vj4vuGSMSgQQmxSQEVtKYbQHSNA7AP1ekQX5I9IWX0VU6ly/VjfI5r6P4OoVHhE8NtleETEZLPZEnoJDNEH4bmHqNVHvzOFl6YI4OlB/HCdDyQxWBlmedEHzZQLnQUSM99gG/ti3CRaa0hOlLC80h6SY2zShBHf524ZTFNw62NfRwL02tgIP4Ec7DKM7F31t8ubtFp9lg3/cbgKvHEi6JZRR8m5Z0PabM3fkY0fqa9CpQ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/11/25 at 03:45pm, Qi Zheng wrote: > > > On 2025/2/11 11:43, Baoquan He wrote: > > Nobody is using __tlb_remove_page() now, clean it up. > > > > Signed-off-by: Baoquan He > > --- > > include/asm-generic/tlb.h | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > > index e402aef79c93..9ae4ca02f29f 100644 > > --- a/include/asm-generic/tlb.h > > +++ b/include/asm-generic/tlb.h > > @@ -489,12 +489,6 @@ static inline void tlb_remove_page_size(struct mmu_gather *tlb, > > tlb_flush_mmu(tlb); > > } > > -static __always_inline bool __tlb_remove_page(struct mmu_gather *tlb, > > - struct page *page, bool delay_rmap) > > -{ > > - return __tlb_remove_page_size(tlb, page, delay_rmap, PAGE_SIZE); > > -} > > - > > /* tlb_remove_page > > * Similar to __tlb_remove_page but will call tlb_flush_mmu() itself when > > ^ > please update this too Good catch, will remove the unneeded code comment. Thanks for reviewing. > > Otherwise: > > Reviewed-by: Qi Zheng > > > * required. >