From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447CDC02198 for ; Mon, 10 Feb 2025 21:18:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3E6D280034; Mon, 10 Feb 2025 16:18:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BEDC8280033; Mon, 10 Feb 2025 16:18:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6709280034; Mon, 10 Feb 2025 16:18:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 88144280033 for ; Mon, 10 Feb 2025 16:18:08 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 39194A0657 for ; Mon, 10 Feb 2025 21:18:08 +0000 (UTC) X-FDA: 83105297856.22.45E3FA7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 7B0261C0011 for ; Mon, 10 Feb 2025 21:18:06 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t97e1HkA; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739222286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GrlnFGpTcpJHCevQurfmbvgrKTwhzhcmfTdnYrE4ibo=; b=1ySacHhydsdbh6gRxr2soKrcCck+vWkh57qNmqI7rpXPWU/+rQVXsK1jpVZ95tmfmfQK7y H8q3OFX+oS2ty9YkjHjBEWyDS3hvITe6nHvfEjcpJmLHgaAoFC4z5Gf5dI6+N5LwECtFGd 5W8mnQtv9lnSydto0oO9Xt2nDqpHhP8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t97e1HkA; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739222286; a=rsa-sha256; cv=none; b=qZyQnZsxCHtiA5zF+h3x2llFexb8u/wIKEKd3nSy47qG0BxXRcrKmDXBG7Z2QUPM31ANQn rV0oTJzTkhpXPnouCeNoAn6uGUykR1gwUZu6g7P+aKSbv1m/lXY619RlVSu1dJpVTnHEMT HezEopCeT6FSNSKeVHfD2PAUVZlumCw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GrlnFGpTcpJHCevQurfmbvgrKTwhzhcmfTdnYrE4ibo=; b=t97e1HkAox5QN0FLIyIeq2exVs fNXQoKT2xnLU9hq01Pm8bHhbRiEIb3VPUqtADDs4T5xFWweQ9C+WAptWLuHbXKs1LCEq8KVMstqHS itl4c2oNuCT4jWChinvOLxrUiZ2ORAE1Sq3MpdHBTAXn9nnwDCCE6jP5+xcq595s3wJ32wX78Ekan U57P6N30p8LMIITW/AkzhvDt60KarhszJowEw34KladrLUc9H+XaHzq0p4iNGm4TxjEZar0EbXELC xAZAC3js7tMDnPm56iJfWjNWcpcToIMtQOqkVHwSLdNFoPMUubq2SWetqQ3Cp1AcBiFTshuer8aqD qglLbrNQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1thbAK-0000000Gmuv-2i7Q; Mon, 10 Feb 2025 21:18:04 +0000 Date: Mon, 10 Feb 2025 21:18:04 +0000 From: Matthew Wilcox To: Dave Chinner Cc: "Raphael S. Carvalho" , linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hch@lst.de, Avi Kivity Subject: Re: Possible regression with buffered writes + NOWAIT behavior, under memory pressure Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: fyp6epiwzmwhpx6y8tkx74kqtqryjjng X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7B0261C0011 X-HE-Tag: 1739222286-867764 X-HE-Meta: U2FsdGVkX1/V3Ev4PZCM8GBeYXhNyo/tezAkq7Y+oLrgLLFmFcepcfa9G2fYQEzVhE2FoO6u6Kr7eJlgB6UWbKXM7pkaRGDDdX7M89t9e3pBbMltsSzdXdWsss40f/Vz9L9RjDXmetNLpztt0/FG2SSLk1nqp3tZa876RbqwcMxwiGJG32zQw7NOab+pZV431q786Gh9sR/9PVV/wIaVlV2/MNKc2Tmv/Cx40Mgagv/gTet4AW580Pu2gKiAd5A/fxZisJ9oULO3pgsblKYMkztUt6Srygg9mjQu3gCsmWk3dSMlZc/3w3qZ30oPqSatHufU4w6kIspB3ZfVpjOEiFzjoKHUfBdq6hIR2923Rzr3PofP5rDn5WHjsy0ZestcFiXIKSslu3vQBjibPEt1ACUmjDGbZC/Goz6XhNSgIt+7KayUiWYv8e2n1ldm2CnsOTzp3rD3DV8g4PwzALQxURhwBz0wxvbssLGxsbgNQ2iyLR7th7+CU0EFhXqw8ftya9Bfo5H8Wo1pGR7vJDxqFqJ4+oIBr2Kp4d8GIExbgjBJ7ugC+hQbvt5xqdq3X23AEVZm0mkrN8B4+Q18RvQIla7s4gEWe4pzvMDq4rT4c4ii8qIqTYFLmJ9WJbRNSKgcHJPdCqcsjLAWVgvd7Och6m1f4BOIDEwpV0p4ISBMROAdNLj7o3uak2Htcc1+W6C5kEahiCXaeUtMuaAHorHxkXDG8WCNaildiZ205oP+cF6Y4b7ZRXJl+0pFtUknzS0p0Ds0vrae/xaIq2cp81v8XQ2W7CY27502PH2V5FCiYcg1JRy4GgUUaXypP69+H1SUygOMB3VT8me5jCJWaSyTyE8sxPx845nuknpIfw6LDZCYv79oBq8UPwU/EWTJq4SqcE9Y8UnCj33t55s4yDZnZXljHGGc2ItD+9qwQS+ryuOHRIZEQHsgKkikXAs11ZZPoadwYqI6lgAO5SlLLc1 7TMkNsDN DmYJZvLsh0+PE6ZEzMFmhG6LpyRWYpEPX1rh+37XMZM+66Plpo7qdIZipyzHQTlFP0El4i2kVP7w3Nngk2bcykkJEeQERJRj/Lcchi8SPsthAJdTNIv/RnwbCW9sRkwWMNrUHoryjEdR7tE4dAtJlg3ElM4UrQUe7k1g+RD3syjF+0tbSJvu/SRfcTyAZ6u1NnxNhN/xQ1oYDLURoaB9UPABEqXTfCwR1z7Sq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 08:09:31AM +1100, Dave Chinner wrote: > Better to only do the FGP_NOWAIT check when a failure occurs; that > puts it in the slow path rather than having to evaluate it > unnecessarily every time through the function/loop. i.e. > > folio = filemap_alloc_folio(gfp, order); > - if (!folio) > - return ERR_PTR(-ENOMEM); > + if (!folio) { > + if (fgp_flags & FGP_NOWAIT) > + err = -EAGAIN; > + else > + err = -ENOMEM; > + continue; > + } Or would we be better off handling ENOMEM the same way we handle EAGAIN? eg something like: +++ b/io_uring/io_uring.c @@ -1842,7 +1842,7 @@ void io_wq_submit_work(struct io_wq_work *work) do { ret = io_issue_sqe(req, issue_flags); - if (ret != -EAGAIN) + if (ret != -EAGAIN || ret != -ENOMEM) break; /*