From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB18C02198 for ; Mon, 10 Feb 2025 10:13:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E8436B0089; Mon, 10 Feb 2025 05:12:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 898C3280001; Mon, 10 Feb 2025 05:12:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 738AF6B008C; Mon, 10 Feb 2025 05:12:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5690B6B0089 for ; Mon, 10 Feb 2025 05:12:59 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 117441C6DE6 for ; Mon, 10 Feb 2025 10:12:59 +0000 (UTC) X-FDA: 83103621678.26.C02F3A3 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf06.hostedemail.com (Postfix) with ESMTP id 1771318000E for ; Mon, 10 Feb 2025 10:12:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PW11lRUZ; spf=pass (imf06.hostedemail.com: domain of richard120310@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=richard120310@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739182377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFn4UHKKr9XPx0URdc5uNtF2TrkHu6xcH3JJm9xjq/o=; b=rCGi3a0u/DXA5wwKJNhET6d/CxfHd0UniTpn71E72z7vlSdkr2i2gc/hHrYVm/RAiWIAms 6FbQiP8Zyn7GlRRT0vGTEK8YnUDpk47fwV4gqhguh8+bb/BA/A2N6S0RiAzxAlvvAqRl/6 veKa2TaUNEADoNsKrRyWMHrZOzyeuSs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739182377; a=rsa-sha256; cv=none; b=xH4PHieVARSopIEg0CMjqDtd/j88zmCt2pdhMEzRGA4+kRwrKNBLZ84oi3coI8ZkKhZkJQ ioVj6LiSMc5GsMw+5fOL/8Jeb2o6Vjez1kTH59GbHBInitGlJ6HApCXyH1uAqHyHLyCPxn zVMmlOMneQvSgt0TYGt30zWdQq7GKhg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PW11lRUZ; spf=pass (imf06.hostedemail.com: domain of richard120310@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=richard120310@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2f42992f608so6237281a91.0 for ; Mon, 10 Feb 2025 02:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739182376; x=1739787176; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=tFn4UHKKr9XPx0URdc5uNtF2TrkHu6xcH3JJm9xjq/o=; b=PW11lRUZe3uQZQStGdyMK/VVPdGRzoWsWP6f/6QsXwJ/HnSAmqwOZ3iHmvGwvZNRVe /dUUzGis8YuuqkvYmLKaCTTRK+StvaobZ/jZsZP0Oc/Fd2RaJGkPVbjC16Nq3qp/UWmw /DohgqjhyV3yIr8e4Ajy0r8UjccY+3sTXItcqWeKcPsTr9w5Sh/wybDkekPq+3N9ub3X pE5sSPy9jYcoE0sK7pSZDTIJPdu3nIgam+lAQjuJaTU0qY55PmdN+Ys5klgOeVtqmv/h Fi93k2DSduaN3wiJcrIQG4kFHTKXbHhnZmw7iirMvVGp82gyVXAJPr+eFwxHas//0jSK 8Q9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739182376; x=1739787176; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tFn4UHKKr9XPx0URdc5uNtF2TrkHu6xcH3JJm9xjq/o=; b=JOECFO2C7k+3LqhPa2FaqoNRs47ZVpl8owsiJFOtr3WWCCR9ovUyUBKOhN0HT4znbG 1oHHoAL4Gd1Dik00Itay84qe+yk5CvJSskmatJEwADWvsys0sxuG1JErEDyK/PPIXFaJ GtP4jvTo5/7ks+swegFCjXmOeVqHbTdNmNHApVEwEJe2zhEdjtJQyIGCkx2oexPLTHaa QtyMpMjAQ2MNZ+3tFAoEaZF2SudNqccCoZgsFX8n36QDBVgULvS4AwPERfV8KNiBKuC/ d5A/Uwl8MUBziveh0+HEMvc2ZlufzQ8WWCXobe+JGuZ37Rb8OkU/rOM0UHRffXcSzmWK Yj2Q== X-Forwarded-Encrypted: i=1; AJvYcCURwTNuioQdNBvIiToed/KpBk4mYX3yQ6z/MgB4G5m6rriYOqltgtcIMT+0Dfvop5H18zJ8MgpwPQ==@kvack.org X-Gm-Message-State: AOJu0YxcU9jbLUZgXJTOKyw3P5OYX9oXT1KKs6bitIFt+GZR2okDNbEk HY6Pai1fkeZcL5cHXaycOv+c0K/Y3neJQ+eIf22KHw3pVWpIsjA9 X-Gm-Gg: ASbGnctsCwF8YPlcjmtWSkcR0bKvYXCFM6FV2ZQLq5XdU37trPdGDF805jVnXuIJYf3 23dJbC5h+iOgFGQpw2EA2aDecP792yI3Zp3hhFDfPmyD2xvhQaSX//leqvhkcgw0iBALFPMKHkL HSg4w9XnrnIkx0I3yZ7txoHqgGhGkmb8AWqvHNAyj7MKUhNdu/mD+UARJmlZeegyWdkyV6KbDSC +znjdHPMWbUWDZ5b8G6ihbAy4rbxbRzA6UzEdZisGNdb0y/CY4NbMxQxNZxmzu1+B+ouFYqSbnM PUjGLfcERAozVSCpUAGHpUC+QNOkHr7p X-Google-Smtp-Source: AGHT+IHvaivavOz7PALWmUfBd2SwUocU0pAOAWkCvUDckwmmZ/da7ocSxotKp4Wa6wHL4T8yUOipew== X-Received: by 2002:a17:90b:2bd1:b0:2f8:4a3f:dd2d with SMTP id 98e67ed59e1d1-2fa2406f6e9mr20518623a91.15.1739182375888; Mon, 10 Feb 2025 02:12:55 -0800 (PST) Received: from vaxr-BM6660-BM6360 ([2001:288:7001:2703:83e6:5a50:60c5:d373]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fa09a6fe28sm8269019a91.26.2025.02.10.02.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:12:55 -0800 (PST) Date: Mon, 10 Feb 2025 18:12:50 +0800 From: I Hsin Cheng To: Qi Zheng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: pgtable: Ensure pml spinlock gets unlock Message-ID: References: <20250208184928.219960-1-richard120310@gmail.com> <4524511c-d685-4af6-9de9-4f15f7dcfe05@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4524511c-d685-4af6-9de9-4f15f7dcfe05@bytedance.com> X-Rspam-User: X-Rspamd-Queue-Id: 1771318000E X-Rspamd-Server: rspam07 X-Stat-Signature: ggibpidwyxxqwh1jswwtjk8r53ofofx7 X-HE-Tag: 1739182376-190676 X-HE-Meta: U2FsdGVkX1/LDAumHB4bF9ip9QlDVTSLL/Vj2MJwIRvH5eCdt9GcyosSwodplMpP+/6nR0x2b2nhRVJYusyvYNfZtOmqShkI30Jfh8XylXvrY+KR9M9DbfS/SHLjIUN2IWyaMpInt94/X0rFxC9kSccnLTmQulw7HucMy9AWDlLd3+TogfS2Y30o7s9fGkfoVEdajLDSKy4R9DD6/MhreYOPnih4oSXUmplzGdAgGzmW3Z/PxdpAvclzCGqN6z81pqCCec5UBsWnFUhI7yqweMpVmQ3cJGFfoS0dlNY8E8HWaq0FzWqtqOt39S7WAXBaU4+MPu0fUZDFJDBamsXZBeukj1Wr4eSS0zXr88cZhIGPX8+X0/t14fiW15L5ll5u6bFxxRHuvKrNfiLYjhayWFNjMm5UhD4yNl+6Yrqq5pHM+yx911Uyst9MCnkuKy9eYzKMJYXDaovy9YGyNFbZPucodH9rCNaOae3wDyEhNUx0Z7UkOejj8B8PHCypw0yBeY1rNU3sym/L37S+hetHgPmZIYr1lcEtNAQ0RD0fgbLJoiQ9FnJfEy8GNhnKjLjfI37LqTOeXeyvMUDLeyUNtAyQDNPFNYw34m4/MWyBYvHmjZKuaGkNL5cKRX2+65+YbPmbJtJSFShdYclmns4SYplVSVtMdvBz9HO3V2hP2h8OdFIu5JWBx5AraCJdib94K4U/iT8L7BldsanF94htPUhAgCpV7b36AcZHEbv6IDbodzDv66KsUOJK/O8B10otGP6XdHP1UItD6O2aaW6jrTgBI+FJB5aYwQvtMrisKAd9VogSGwfocq1LugV4KbOx3NgIvktyjrFZiKYJzljsXCP7Ug35trK0TGBm5MLabpoUfxnjkqKiZO4Q5wCnpe4QrIxn9jsJD/3k+dpvaFULEAG6qg3eEAYc2Snmc5shaA76u4rp6Bmu9f2KpCrrLjxv0cHbgAwJUX7CSlwkrw7 GrzaT1R/ p1pONQZJAKPz+ie0qSCfsXIv+qH7K7qSmIp1WrU5KVNS7w0t9nToE/SlMMqA61wLuBPwyZ4EW7ILcQTH1gBc4z3i4l5+XMnlDdbi0ZHlQNRwX6ySZcL9tL9IX16SYRW+4CMj9jx9vFK/gLz6gvEJULZiOtJNvhAvUYLGcBvu3MwJwo/XhiGVqvE7pKZ8aNLwjZdLpSHGNVDhwJwGVRIOkRMkG5WL2J9duNic2fdgH08i+4OtsvaqX0twEGb7NRdDg3aa+baS9Xp1uKB62ZJ4RcmERemG6u+lVc+l/i1ElyEgvZYSBgbcWX2P+2gd4ceiQ3a7YLQS7QK8KOD+kwbhy3wIK/qQsMQZH9smAFov/RF0NGXOU5+KRPLQD7AUQei1RyflD/AesMwQS8TGwGdXUMkm4eo6KmOOL1QBP+51UwXpsCiDLJIoVmc6bbwrQBu4qxd8eM3Vj9W2FziQzeohiWB4qby6u1H5uQuprsME4jwHAgDgjq1WHtQYB3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.216604, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 10, 2025 at 04:42:13PM +0800, Qi Zheng wrote: > > > On 2025/2/10 16:31, Qi Zheng wrote: > > > > [...] > > > > > > > > > > > diff --git a/mm/pt_reclaim.c b/mm/pt_reclaim.c > > > > > index 7e9455a18aae..163e38f1728d 100644 > > > > > --- a/mm/pt_reclaim.c > > > > > +++ b/mm/pt_reclaim.c > > > > > @@ -43,7 +43,7 @@ void try_to_free_pte(struct mm_struct *mm, > > > > > pmd_t *pmd, unsigned long addr, > > > > >        pml = pmd_lock(mm, pmd); > > > > >        start_pte = pte_offset_map_rw_nolock(mm, pmd, addr, > > > > > &pmdval, &ptl); > > > > >        if (!start_pte) > > Maybe we can return directly here: > > if (!start_pte) { > spin_unlock(pml); > return; > } > > > > > > -        goto out_ptl; > > > > > +        goto out_pte; > > > > >        if (ptl != pml) > > > > >            spin_lock_nested(ptl, SINGLE_DEPTH_NESTING); > > > > > @@ -68,4 +68,8 @@ void try_to_free_pte(struct mm_struct *mm, > > > > > pmd_t *pmd, unsigned long addr, > > > > >            pte_unmap_unlock(start_pte, ptl); > > > > >        if (ptl != pml) > > > > >            spin_unlock(pml); > > > > > +    return; > > > > > + > > > > > +out_pte: > > > > > +    spin_unlock(pml); > > > > >    } > > > I've send a new patch stating for this change and change the title, because pml will sure get unlocked, we just prevent the redundant branches. Best regards, I Hsin Cheng