From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AABCFC02198 for ; Mon, 10 Feb 2025 13:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0B026B007B; Mon, 10 Feb 2025 08:15:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB9BB6B0083; Mon, 10 Feb 2025 08:15:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5A7F6B0085; Mon, 10 Feb 2025 08:15:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B39C76B007B for ; Mon, 10 Feb 2025 08:15:08 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 336BF1A0C91 for ; Mon, 10 Feb 2025 13:15:08 +0000 (UTC) X-FDA: 83104080696.30.B98ED69 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id 024E91C0019 for ; Mon, 10 Feb 2025 13:15:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QbfJr9Iu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ny7OKTdt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QbfJr9Iu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ny7OKTdt; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739193306; a=rsa-sha256; cv=none; b=qeC+F72Rf2pKzIKYVjWxblk3BdReSb8mX+FJF/98aNveuE4nwkMJTKRgNhgbI/kHcD0eXX C4I/gfpV3XZgOwxKbjVtAJbv8iNLqGWjlfV+J1wKQL6LzM0uggbbwFNZIVLirYcFxozQgj FtMjs/VuEOuk/+c9d0JmwJK7qbPSVcg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QbfJr9Iu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ny7OKTdt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QbfJr9Iu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ny7OKTdt; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739193306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xlmAzRtWPENVb4EYtsH26IXnshftttCWb/bTVIHZo9o=; b=8Dqhg9OMWJchUtJP4oMgPP7b9aZIUhAQy6+M4+baLJjhB7ivzYpK4/JlfoZo/Yt5MVD2cB 7MUVke0df6umiqMjz3zHwqA02or3s5YEnO2c3e2E2Q7Ii8iC4ON+aMCgGm1F02yw7+dN49 ovKBe84Y3eCA9uRDS4X4s6cSUOgI55E= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6084C21106; Mon, 10 Feb 2025 13:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739193304; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xlmAzRtWPENVb4EYtsH26IXnshftttCWb/bTVIHZo9o=; b=QbfJr9IuvJhzvVDNmYxRSkcoIpSapXOZZYJkRWiv9bdjiwlm3+cB5ZkeIxWXK8DC20sPnu jHcSXMYyZMaTItSsu/yZQzu2IM1UOUiQLiCuWZv3ok4p/SkbE2Q9OLRme9GC/ms4x/LD8e q7btknOl1ReGvDEcCwnnootR7yam1IE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739193304; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xlmAzRtWPENVb4EYtsH26IXnshftttCWb/bTVIHZo9o=; b=ny7OKTdtkDITeYiYkWNXogzU/ho9FXpvn4zFqmMz9v7P2WhjPq4DPyPecB9IhuBpwqzq9O Xg1L+PTlp6c3XmDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739193304; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xlmAzRtWPENVb4EYtsH26IXnshftttCWb/bTVIHZo9o=; b=QbfJr9IuvJhzvVDNmYxRSkcoIpSapXOZZYJkRWiv9bdjiwlm3+cB5ZkeIxWXK8DC20sPnu jHcSXMYyZMaTItSsu/yZQzu2IM1UOUiQLiCuWZv3ok4p/SkbE2Q9OLRme9GC/ms4x/LD8e q7btknOl1ReGvDEcCwnnootR7yam1IE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739193304; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xlmAzRtWPENVb4EYtsH26IXnshftttCWb/bTVIHZo9o=; b=ny7OKTdtkDITeYiYkWNXogzU/ho9FXpvn4zFqmMz9v7P2WhjPq4DPyPecB9IhuBpwqzq9O Xg1L+PTlp6c3XmDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD04413A62; Mon, 10 Feb 2025 13:15:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NwAqK9f7qWflBgAAD6G6ig (envelope-from ); Mon, 10 Feb 2025 13:15:03 +0000 Date: Mon, 10 Feb 2025 14:14:54 +0100 From: Oscar Salvador To: Frank van der Linden Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev Subject: Re: [PATCH v3 06/28] mm/hugetlb: remove redundant __ClearPageReserved Message-ID: References: <20250206185109.1210657-1-fvdl@google.com> <20250206185109.1210657-7-fvdl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250206185109.1210657-7-fvdl@google.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 024E91C0019 X-Stat-Signature: 81ij77a3f9wxpyrb1tj9zi37szro33u9 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739193305-383557 X-HE-Meta: U2FsdGVkX1+WBpHD21q5Be0oOEiXz60c+eSIRjzSaj6bj14ygqe0Brxzg1DdU8G48puoVRACRxrUIJZwVcydeirOJ17So7LL4wmraGO71HWAb0xT52TY7S+pfyBn6BpSIzOwoBLSHid26xJJHAblieNRJ6hEmk+hBRSpudo4xxo/rKabmHwSw6QJdaXwewkzd5bFRIh/BuO9AajKTi2Zey05fAPhcAcPcnc5upriKyeTkosefgMBLuLMpNQTiECj1/gciHM77fA5M2t+SHHGs7xaUvfJumneNh6DVFAbyB08IKihzqC058ikXjDQkd0cEYvRQYFtqssZDJcxZUzy2uhMoI4hRaC9phWjb5UjDWJ4rnryKCWWV1e5wvt7vd9H6+PTsqSRq9/3hZAlTalOES/8njmU+0JyGZHG2ES44rv6pudyUL68Aq9FHeoWjrMXnsZVCXS2sIatsTHiq+HFNHg23FKK3v6szjF6loLNjK+RFroIBU+cCdyiu3QgLkSs27oyfUx+G05OZWZPpBhnraP0NOjU9eisFSwNmk5+DG3gadzpYE+0AToe0ZGo+kL6pvaj4CQbgrvT3rRlgXJ7Fc7KnVgnMLgGL9R+4lO7L3IYzhLYa1XVhP+lctwf5egmQmwCKJeQJ1NA7DUHjJsI+0ZNDsUnq3Mlva+roYKVzeKWAaBI2OcdP8KLkKB443LLRWCWC5502gOxlE/3+yE1UV8oWQCLZTOAXv0GTTWIwYoa7GRwIbsktw+jBo5CPIdy0B2ZXdnLBWOMi+ABwzk+gQJdovO/l4LzoQs4EuKEOXRPQSGoJFPpPFDMYLw0dqolydTk/GzzPF5hBZpIhr0gbZp0bffl2YC2fIrT9YdCUBcVJC4qCUFP8kofgdOU6GFoN/llsm6ti6XPOl9tFB7iMYnc1xokElD/wvsYteCpF0I3hFQ7t+N7fKXBMgL6tTYNqyCO6pQW79HG4z6Bd4i s5cg9ITQ 2eihcEXun7nX3y6K8t8bd6vbGilO5VmkpI1BZ2x7UEuWo9ES6TFD/aEdnMQ5HKTpMDxwBvpz1j6Bbk3NkWKKNhEp6Im8jvyLQ0rTttmi4wZ5FzLc5yYx2xqfawr2dxKpHfAGmPiCqpoqSdJAPWUBjYEKicL9XS1Y3NrcCyppAPcoJScXZg7f61Pkplwb1xF+kjRNrfYUO3pFSD2duFVTmlybuU+fX3gwxjK/I0yqiRNGyliaFkKo7Ewz3k/WkkBJmndBulWfeuBTVfQukoYTWIzBWK1DTRFE/ie3Ru5Z5je6XiedwoG5udVTqhL9pMdtQAWXcfpVPLgXEY+A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 06, 2025 at 06:50:46PM +0000, Frank van der Linden wrote: > In hugetlb_folio_init_tail_vmemmap, the reserved flag is cleared for > the tail page just before it is zeroed out, which is redundant. > Remove the __ClearPageReserved call. > > Signed-off-by: Frank van der Linden Reviewed-by: Oscar Salvador > --- > mm/hugetlb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 1d8ec21dc2c2..0836e3231774 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3202,7 +3202,6 @@ static void __init hugetlb_folio_init_tail_vmemmap(struct folio *folio, > for (pfn = head_pfn + start_page_number; pfn < end_pfn; pfn++) { > struct page *page = pfn_to_page(pfn); > > - __ClearPageReserved(folio_page(folio, pfn - head_pfn)); > __init_single_page(page, pfn, zone, nid); > prep_compound_tail((struct page *)folio, pfn - head_pfn); > ret = page_ref_freeze(page, 1); > -- > 2.48.1.502.g6dc24dfdaf-goog > > -- Oscar Salvador SUSE Labs