From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3474C02198 for ; Mon, 10 Feb 2025 12:58:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 589506B007B; Mon, 10 Feb 2025 07:58:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5115F6B0083; Mon, 10 Feb 2025 07:58:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38ABD6B0085; Mon, 10 Feb 2025 07:58:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1B1FF6B007B for ; Mon, 10 Feb 2025 07:58:00 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 725D2160C39 for ; Mon, 10 Feb 2025 12:57:59 +0000 (UTC) X-FDA: 83104037478.27.1DADB96 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 412D380003 for ; Mon, 10 Feb 2025 12:57:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mQp4qLRw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=iiWfmPrg; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mQp4qLRw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=iiWfmPrg; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739192277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G5N+29t5fdH1xZC+QmxN9ar41yJPhbeshQ+XzkWvaBk=; b=X+Kl6Iowpej0qXa+uBpMrHbFWA27PDXitHR5rOIVQHaBBU/+kv0DwgAZi0bfpWNfZr1hw9 TQxf0Y7b6wSXOM38hHhQQBPA6/Ftik/UOPRFtEdMTsvnHM9Gs/O0aBpF9EdM+Df/OsNkO5 Yh5qJ7aaTIOuDumQiIl/RUaRgWU2Wd8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mQp4qLRw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=iiWfmPrg; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mQp4qLRw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=iiWfmPrg; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739192277; a=rsa-sha256; cv=none; b=VyySDV+nnXizLVRcEbaU407LnonzF8Lhxdqh/Kikk5f2XeuTbR5rVQ9W9H9rFIhSEbaPBP CTZO3PrRUQxYvkuvzZEUkW8CkISKOcJPb2moHg6pC1LMYsPhorZjogrL08gGwspD3o4//r JSxtJIAzjCpp//2aH2YqwumJdNtSyYo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BBE28210F8; Mon, 10 Feb 2025 12:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739192275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5N+29t5fdH1xZC+QmxN9ar41yJPhbeshQ+XzkWvaBk=; b=mQp4qLRwGUOY+WhAxZIvylgKQUO+f2UaTjObrMRqMW4bt/S5EZwhe7FkrqlF1lL9jxDasP HBqGp+abl459j/a5FkCDHNcQyoyP09o6UkmBCyCMI1s/SMLDCy58tIBUcvCQXL6pk3MxGp Ag0ksCLOPrL6WetWc8rXSS76IalTTBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739192275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5N+29t5fdH1xZC+QmxN9ar41yJPhbeshQ+XzkWvaBk=; b=iiWfmPrgGKhq0yux6kMny3f9TcjnSH9pCKL15pKymgNQfPQOOBq+fCNWjEra5ktwISMRqs tsEKBwgwEpfe6LDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739192275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5N+29t5fdH1xZC+QmxN9ar41yJPhbeshQ+XzkWvaBk=; b=mQp4qLRwGUOY+WhAxZIvylgKQUO+f2UaTjObrMRqMW4bt/S5EZwhe7FkrqlF1lL9jxDasP HBqGp+abl459j/a5FkCDHNcQyoyP09o6UkmBCyCMI1s/SMLDCy58tIBUcvCQXL6pk3MxGp Ag0ksCLOPrL6WetWc8rXSS76IalTTBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739192275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5N+29t5fdH1xZC+QmxN9ar41yJPhbeshQ+XzkWvaBk=; b=iiWfmPrgGKhq0yux6kMny3f9TcjnSH9pCKL15pKymgNQfPQOOBq+fCNWjEra5ktwISMRqs tsEKBwgwEpfe6LDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2DB6F13707; Mon, 10 Feb 2025 12:57:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id b/aGBtP3qWcvfwAAD6G6ig (envelope-from ); Mon, 10 Feb 2025 12:57:55 +0000 Date: Mon, 10 Feb 2025 13:57:53 +0100 From: Oscar Salvador To: Frank van der Linden Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev, Zhenguo Yao Subject: Re: [PATCH v3 05/28] mm/hugetlb: fix round-robin bootmem allocation Message-ID: References: <20250206185109.1210657-1-fvdl@google.com> <20250206185109.1210657-6-fvdl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250206185109.1210657-6-fvdl@google.com> X-Rspam-User: X-Stat-Signature: 4nourwqaps7i7fu4gmreafum9j4qia71 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 412D380003 X-HE-Tag: 1739192277-930250 X-HE-Meta: U2FsdGVkX1+Vu7dN5bC0Jx+hh7vOdH3Ln7oycLfBNJ0XvytfURvYkgOxFe3WUYvTfiwwvUXuHMiPhzXXoHhOWmyVicb1vGwNmGsxERGUoDWS5ebs8OSj43jP38FvHVIrdaiCUMp0dVFOQr/PCGAVhSGjT4WYMdvuUoJmWhnIC9FSgQA74eeT+ki3uKtllg+xwDcuVhc5GFhmRTWan7jCVY+/ycvMJCSh1P//yllQxEGJO/MSPxuiizMTKyVgRmfbOnLECdKJC76gJ8qWyC8gEfXvuC7BYbtfn7Dv0VN0X8YQr7bmORuYd29DV3IiVNNYJlPQ51+65nrntJA56wKgBX3xuRT3wIN1N9OufWeJ3QtF+HWjUKySrnqwPf3s48LiohM2WFFzSSmvNDyJDthXNy228515vuh61v8o6/Yel8jOjPVVlkOXFo9/ugYZRBnJbbG3L9FyQUWOv3nGMmI8yIx+aNp1dBYU4czpRTLi90MN5wFXqZd3WBY9PacuQyGpoJ/pytoxMe/GBqF9Is//mjDXGcQfE0bxRcY35fipKa2Tfif2Gm/oavikBKdHMi5IZdILITo85r4vEkg4Ya0Abif/7lV3JVNx0Kg4AVTodfetJhl9hO0EM718bv3LoT4jAYNGRSd84ZiPfxapSqDp1X4jxkDUiKr+gHabw3cXf0oIGBh0oUecctIsv6D2zzMexI66kU5a1NMFpfCLzhcxiMBhlAqKzbX02j7fPqvc6H0DxaOxJOHLPw1W83ufbso+ryvdaVaZ9TwUUQZ3LX92wESpp0nwGysOLwSQAhgN0dA/FGnj2cu0YjPStx4IST1dd1LsGMOQs/kSaH+sacVtHKc7PGAppFO0xK5IKtDx/k2ChNrMYymI2hhb2zacU76yLTk8t1vgEHox9ZGT/FrZsbVTwXpIXLASb2N4EdYW6jLKo4S8ARNXQeC03L953gqdx+3rCjx8INtp3dDShYu Yu+ppzwv mMtFwwUEka9io84dPdRQuXAkDe5BHUs5sPNFoTSumucftM5LCrtP+79riOEIojj3Y+lX+J0YqOK5cngph75GxGAxxKmKrk4xP6HSj53CQHO+h+PMFgIS8QGQHDb4MZ5STvWYfjMwq9RKI/OHFKoCer1XQZBV2yDnjoHZ3uCSzt9fPHM/lSKzfEizJe6mg7sJ+0Cx/w5p40a0BUfe/lHzV6CQSE+g+NSRXDa9PFbGR7h6Cu2RCTRDGp5xjyoshL+8fD3d7FA6oruAQUIc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 06, 2025 at 06:50:45PM +0000, Frank van der Linden wrote: > Commit b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation") > changed the NUMA_NO_NODE round-robin allocation behavior in case of a > failure to allocate from one NUMA node. The code originally moved on to > the next node to try again, but now it immediately breaks out of the loop. > > Restore the original behavior. Did you stumble upon this? AFAICS, memblock_alloc_range_nid() will call memblock_find_in_range_node() with NUMA_NO_NODE for exact_nide = false, which would be our case. Meaning that if memblock_alloc_try_nid_raw() returns false here, it is because we could not allocate the page in any node, right? -- Oscar Salvador SUSE Labs