From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D007C0219D for ; Mon, 10 Feb 2025 08:59:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1651A6B0085; Mon, 10 Feb 2025 03:59:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 115446B0088; Mon, 10 Feb 2025 03:59:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1F35280001; Mon, 10 Feb 2025 03:59:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D418E6B0085 for ; Mon, 10 Feb 2025 03:59:26 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90930A0240 for ; Mon, 10 Feb 2025 08:59:26 +0000 (UTC) X-FDA: 83103436332.18.A35F6B8 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 99F1C40006 for ; Mon, 10 Feb 2025 08:59:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ngk5NaJ/"; spf=pass (imf01.hostedemail.com: domain of richard120310@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=richard120310@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739177964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V0FOdeNN8xEA771wgYDIWAiBn8a2qFfFqcNYmlhYwUY=; b=O7PAnNp7jQAlPo4chqof6+Gc3oU0mBvzYlhuUj35PPYeu9+cECr71NzFy1EzVupMHIiN7z jg5CjpDJemvfrYRsyzQiuiFjfKGrmLbTTmJnNLvCsjN1L+CGgDk0gQ1knxeXIgaHT4RpOV UklpxaPN5NXYoMHpkAn0/5B33qYFegE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739177964; a=rsa-sha256; cv=none; b=uBZ0RM9MUgsrXps2bzHu/UzhWCLzNSueaNUrOhypCTyeiCdkUobFF7RxpNVYoqjbEgirnf LN/Hd3la13n7kfP+Se6Rh5sVhRmI2B/QWOhk+bE8Y7IMKCE1E1yz/N1HliCH0PC9JjY8tA r8awkuYYjQXfCVk7LYE7vXmmzBhVoAA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ngk5NaJ/"; spf=pass (imf01.hostedemail.com: domain of richard120310@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=richard120310@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-21f44e7eae4so61461925ad.2 for ; Mon, 10 Feb 2025 00:59:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739177963; x=1739782763; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=V0FOdeNN8xEA771wgYDIWAiBn8a2qFfFqcNYmlhYwUY=; b=Ngk5NaJ/VErfPnwl/AgfHzCdjzCcYt0oAnpf9F4JRzwCqY+b/fz4QcOwgSbAWdD1/d nXRnlg8/DV2CBfquPm77QiRUoU4eeBdR3zEa3FrF222mwR4i9Yh4Ak21Wlh76Ch0hSHp DJAHbhvvJdE5cvqtdVAqOXRKAgk6cdQGvHB7b9BGPQxZb7Q5GUk7MBl4tGrkSIemq7UB LxoG1T7rlnFzLciBr/Ool5khXYDGlkP/Zrxi4+QJt/wDJOvlSL1nPDSp9DZy/Q9DhSEH LlQeVnIp0y4a2kKJsq8HR3znrWZaKgKoSeXN+sLVQ1TeIVnFz2GT76UZghp80DDNxpRR G9fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739177963; x=1739782763; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V0FOdeNN8xEA771wgYDIWAiBn8a2qFfFqcNYmlhYwUY=; b=KSNffRjoUTEu34Y0BuRLMBWZ/8tDYs2NyE4YMx7W27VCqubMlOpgkpOKbjLSNmuvCE mx1t3xYs3PRQmrU2UocrTOAorC3Aadw/C1aU63ybFuStB03mnRnJs7hUz1tJy7yRJo/K R/qa4LhYS0EEMXLV2RO9Xg1ASe+Qj0B1/aDELG4jXX38Phd5RLzINprkpevZNuZUi9dm acybYj7ArHbb1c+QBMyJESOmcrqLSCgO6yhxus8Q3kJqORur9VR/lTC9jOTU4+LRtcdN awRyTiQCDQJFUolaY3/3dQdUrjxXLYl46h8bna7ieM4aN97cKBmqYkuS2Lf0c3bCeKS+ TBFw== X-Forwarded-Encrypted: i=1; AJvYcCWWUQZwvjW6u5S9fGi2JcqZoYZw6Z/0xQcUnl8y/prLSwbdl0oWrA4iwS5ASUU7yOfXfrgVppANvw==@kvack.org X-Gm-Message-State: AOJu0YyzyFQo27zyqL74zIPo0QdlhQKCV1Fkmih6naLC1YYiDE9E3xyH 7kVgXdIwIiQZPvpLhSqL/lttXs4fk1yfoTeRy6rV6EVeF6xE37nV X-Gm-Gg: ASbGnctA7JOOdmexqrSCQTy9WTYmA+xMf6qGcJn06tvw1tsXLV+XjsWn1i0pheo3zfq 4lZUkdl3UyOgOeOWUhmnPd2k75AeYQwWjH7B64f+99/UMV5dzkmy1oQrtKU75OFD151g6NJKq3D jVuCo+wTgG3IHTNv90UT+hClioV3W8SUCGa9bKKDrgGdVX2pcr73jNEJJyORkGxL0l9VfI1GAG0 ZrIeO6O8sFO4BKDu17WMvMosAcQgZrJOfP1XC1TMVTlTFYLZ3sJGuTs+B1ND2+6jdqnaSC1CntL MLdIZMbNfdc0GJhrvhiz3mIkKB6od+WN X-Google-Smtp-Source: AGHT+IFASvhac+YpuX5T0KXy41OzK3q+6qgA4rC3Ayz2rGb68mM3SVOAwCo3OKKQ5X0mreUc5GFsvA== X-Received: by 2002:a17:903:2345:b0:216:6fb5:fd83 with SMTP id d9443c01a7336-21f4e716972mr179450335ad.29.1739177963406; Mon, 10 Feb 2025 00:59:23 -0800 (PST) Received: from vaxr-BM6660-BM6360 ([2001:288:7001:2703:83e6:5a50:60c5:d373]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3650ce16sm73639075ad.9.2025.02.10.00.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 00:59:22 -0800 (PST) Date: Mon, 10 Feb 2025 16:59:19 +0800 From: I Hsin Cheng To: Qi Zheng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: pgtable: Ensure pml spinlock gets unlock Message-ID: References: <20250208184928.219960-1-richard120310@gmail.com> <4524511c-d685-4af6-9de9-4f15f7dcfe05@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4524511c-d685-4af6-9de9-4f15f7dcfe05@bytedance.com> X-Rspam-User: X-Rspamd-Queue-Id: 99F1C40006 X-Rspamd-Server: rspam07 X-Stat-Signature: 9b8b38uk3b1g5soh3o9kxshqqgajpw7z X-HE-Tag: 1739177964-366680 X-HE-Meta: U2FsdGVkX1/IXor9VDSvqA5p7aeaWPhZfXuu4jHsfCJvc/vs9P/c6cjoWR+yr6pAVaZLJGHFzjVVMt+RQBpRDs9rwl/UqGmvQ/yY/PKsccQG+wOfOHBkqByr8OFJpBnOMVhf0bSZWKvNHmawCcA22sJZs9qz2Kcx59NrDAOote4QCa8zpiS4010SGFQl+JtsSNJ5j1ZOIGHuV8Jl8NhGFbVsWXqxbeKSenWrIQGhOkuVnHRUhS6xaPFt+JJkXIf8BHZtnXi998iyE1L7YIDGj/hhwVnoQCGo6ga8zGzgtarYiWVtdfxHXBHY+L3t/fVG419FIoqDPWWB3rZnIYw8iWfcrO0u3fnQ4dRJjZTkJzPXX/S0ksZdnjlPei1s9GV9KU0NkOMnbL0aiOXbuf44UaYoGnD03o7740Gw41O4Wx4He9APkhCrkqX6c80nyKSlHiSmsN8XGIbYBOZFb4gxax8dX1EoJ4RA9u0zESLso77VjlERcWRIKqgWf65ia6E+oKIOpE47ha9jia/V3aKnG66Ka0nYsuvWCu2G9QTEk4wtpWtHPkf5MvFYNqETusIN9GgKni4xLE7SKgz6A3pFbwcYZyqo81X7hxDvuV2v80o645S65gXnSwTodUIIKvJYu9at2IzJwI+8uDNmeiqao5/XlYsOKJyfyvBNbg0LfqKqw5kYwK1g4w41mqo8P4VrHhomQC9Jt1T4DpwwRPCB8Gl+NkmHLlpRvlgk3ck0a/CLKH1Kt3McUWgh/ynnUSjqd1RhlUgRMhj453KGTtSAkJ18VrqcbIg9oE+T4WvCR1RIIl/I1o+wN98eis/3JdVfpzwyqrvO6JqoWZK/E1ZIBhMBmce057f4nttvMQmKYh3y1EIWj11fwy4XnK1O4LlwEk1EPdVdteAlgn+54IY6WDIprCnydIQJT9q5ye+KqFsTeWbxrykqCtazNwIwV+kipOyvqQaGkcxl0homWys LTGUOeE5 lUxjtt8TVmJ2P9xjq+XsciLxobu4UpbRwf0pxPS/jpERScPzLd+I9Z7NzqeyQyvcWSJL4m5OKj/X2zyoam4TUr/rSQI6dej9cmY9Xu1g/4U73YAaiGVGbq3zq742T4y4Ec/c+8+mspfwriOKLICA4gTkzC/5NX0esb5F7OpFqqqP+4jPJ6c/kCMRWWx1It6WDZ7dkTQQ/NkN1TCxASoJcylHRqSjrrCPl6cRQrMOekJUSEiHauSBn4bTzjisoXwElBrKQxQFzwg90H1rCCLP7mIkxCC1r5Mcdu1YJ8BZpNalIQqa0cQ6OjGldUJa29cgpY7sKpZNIJEwfHzxdca8O5Ai8UlgW2ekm0i6rpw9iLmvTV0LxTJs2FGX7bWYSKRXns//t4YIYS5XF0gGlfZ4kG86DsQ6iET8jd7vagt4KLB0oHPeRoloKH4uUcBHH3L9sDjm9WCloGodXcdeotyY/CwzqOL0f6tjGmDMopzqfi2fwE6IgxCrWyXLFOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.090014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 10, 2025 at 04:42:13PM +0800, Qi Zheng wrote: > > > On 2025/2/10 16:31, Qi Zheng wrote: > > > > [...] > > > > > > > > > > > diff --git a/mm/pt_reclaim.c b/mm/pt_reclaim.c > > > > > index 7e9455a18aae..163e38f1728d 100644 > > > > > --- a/mm/pt_reclaim.c > > > > > +++ b/mm/pt_reclaim.c > > > > > @@ -43,7 +43,7 @@ void try_to_free_pte(struct mm_struct *mm, > > > > > pmd_t *pmd, unsigned long addr, > > > > >        pml = pmd_lock(mm, pmd); > > > > >        start_pte = pte_offset_map_rw_nolock(mm, pmd, addr, > > > > > &pmdval, &ptl); > > > > >        if (!start_pte) > > Maybe we can return directly here: > > if (!start_pte) { > spin_unlock(pml); > return; > } > > > > > > -        goto out_ptl; > > > > > +        goto out_pte; > > > > >        if (ptl != pml) > > > > >            spin_lock_nested(ptl, SINGLE_DEPTH_NESTING); > > > > > @@ -68,4 +68,8 @@ void try_to_free_pte(struct mm_struct *mm, > > > > > pmd_t *pmd, unsigned long addr, > > > > >            pte_unmap_unlock(start_pte, ptl); > > > > >        if (ptl != pml) > > > > >            spin_unlock(pml); > > > > > +    return; > > > > > + > > > > > +out_pte: > > > > > +    spin_unlock(pml); > > > > >    } > > > Hi Qi, > Maybe we can return directly here: > > if (!start_pte) { > spin_unlock(pml); > return; > } Ahh that's right I think it's better than adding another label, it doesn't even need to jump. Should I send patch v2 for it or wait for the maintainer's review first? Best regards, I Hsin Cheng