From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0305DC02198 for ; Sat, 8 Feb 2025 17:53:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C7E76B0083; Sat, 8 Feb 2025 12:53:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7783F6B0088; Sat, 8 Feb 2025 12:53:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F1566B0089; Sat, 8 Feb 2025 12:53:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 409766B0083 for ; Sat, 8 Feb 2025 12:53:34 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D85B3120349 for ; Sat, 8 Feb 2025 17:53:33 +0000 (UTC) X-FDA: 83097524706.19.D7A71EE Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf22.hostedemail.com (Postfix) with ESMTP id B6EB0C000E for ; Sat, 8 Feb 2025 17:53:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=glFUAXpp; spf=pass (imf22.hostedemail.com: domain of joern@purestorage.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=joern@purestorage.com; dmarc=pass (policy=reject) header.from=purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739037212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8coXW9enRj+Qk/uYq+Viia1Ez3ddHtkgWQ9wK9feM0g=; b=XloNgqFKAVTmAWmYDn1qTPjtr6INyeZkryL/gQMw2y2lQ39O1YN8pn87u9rzh9d1LUyc1h UPR/+SRCO6kPW3RqAWV5qkN1jTwXdvFXYTk8vMvMWt0ciepRgMCH8l95Wks3s/JVO12x22 z0M4xGhxOdf3y6f1ZFPjAxoaDdt0Qio= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=glFUAXpp; spf=pass (imf22.hostedemail.com: domain of joern@purestorage.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=joern@purestorage.com; dmarc=pass (policy=reject) header.from=purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739037212; a=rsa-sha256; cv=none; b=hxnNT29GFJqf13+DC9pA7ZqxlL4qLMh8v9wKeYdqdAIStdsTHrxuZzPTw5nwEJuACQaf0f 2ixo1jcM7iTlaOCLQgoDSdRM9e+2O4nTDTqdkwCWTb02zMU8znOQVVXEZtDFL2McKnvire 0N/Cxm2Cucj6WQOFgVFIeHPH9bsZd/4= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21c2f1b610dso76487585ad.0 for ; Sat, 08 Feb 2025 09:53:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1739037210; x=1739642010; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8coXW9enRj+Qk/uYq+Viia1Ez3ddHtkgWQ9wK9feM0g=; b=glFUAXppWfIAPpvuAvmXwpcXzHIMVnV+ZLlSP1fXQvvrdUN8l9IDlzuWarqE0JQKN7 wvDoQ3Yo/nkv0ctmHE4A823BdIEm3Za0o2z8kgh8V+IRgLCGP0bULA6YDeCf/Vh4Yc6O HWuDk/mwjHg3fKkN/vM1sQ4fe5T/NzNBNgMa1fxEuIAB0benm5HABFwrtoj12qhT6owD TEiA4RPGfgnqZq8IuVKlJJhlAVT73P63fvM8g3rJ7YCVxQG3bb7rnKJVuonYu7T402A9 aI912fCibVcbde+yQH7V5U51LF/AKEzhlAOCU/QBk+NGof8IrTg5kiaOMf6sdyCNcF+e u+Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739037210; x=1739642010; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8coXW9enRj+Qk/uYq+Viia1Ez3ddHtkgWQ9wK9feM0g=; b=ebH7iD61TwHkm7dr5OqazmuGsiH+l8Tj4fTzmXfK+6bZg4L2oamd7PgavHoctKgb3G gcWqmN8sfK1YHEdVXb0buaipPOMa1arXufOOMe2KSZoid2CXrD5ofKwS/Bj+6jzr+lHm IiB6gaMUdsHFw6Y3BYPx3XpnZaSj9FjYI6NcJEZl8wxboCdurLgx+8Zwn8w2FFd+nOgK 3cHZMgaws94mdIZ1ckOU8cwb+gxXY0Ej+dU2TDbSo56xBO5NWmrZuX2av7VyXgVE+qey y+sOslVZBv7/QH2iFLe3zfwkaNYX/+fWFcT9F0tK6LRg9x841d1mzBj0WLmsmLpo3V0s LaRw== X-Forwarded-Encrypted: i=1; AJvYcCW9P3ep9lkX4DBLPqH65BfWFhL86NUJzUyXLfpJMakNlS0P8qBB2H8Ey2wUQl7gWMbIsPp8A0D85w==@kvack.org X-Gm-Message-State: AOJu0YwCS2kcKrUDtMIZ8Kc4mGG/dtbX40Ud77xmbXnJqgwObeYl2K25 bH5UhPmNpS1GkJ+xhDtymuvkRDCBN9DPhcryDmmHS7VBqHBMbS6+4n/DYyidqrI= X-Gm-Gg: ASbGncsl024FSZ2EvnSvIsQNEhyxC1u5TSF5/oCS0Ny/xKZFY0kZrcxaN6eRpuREtXD E6TTLajWBTwrKxP+XOFJIHbmtaopW3QA3jza0CcIxs3S3pwKY0A/2MtbTYKoZy4EXIbwV3cRCxj 9ON6lYtLIinmLJsYBkLmsYL3b5XJbM4WS0QuH8Rqe2UdQs3ce0B9ViczRKxPKmmVea+7r4SEjKm y5AjekeWEIZS35QfoyWy7nZC6EcxmDKqaBax5144BiIe5UkvJD6mrdvH6TCv1eMWbOnudigADV5 tJGBg11unCuVjpRmzvszT71zL+un8YzUhkfKb5ZebA== X-Google-Smtp-Source: AGHT+IEr8936SrpGms4VFTM9nwnUPu3f+MeKwew8ZkYhynHlrWAfSHOwYoznFAZrHaEfRn9AUEdjmw== X-Received: by 2002:a17:902:f114:b0:21f:75c:f7d3 with SMTP id d9443c01a7336-21f4e798104mr90183885ad.38.1739037210568; Sat, 08 Feb 2025 09:53:30 -0800 (PST) Received: from cork (c-73-158-249-15.hsd1.ca.comcast.net. [73.158.249.15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f368d79a7sm49268895ad.253.2025.02.08.09.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 09:53:30 -0800 (PST) Date: Sat, 8 Feb 2025 09:53:27 -0800 From: =?iso-8859-1?Q?J=F6rn?= Engel To: Lorenzo Stoakes Cc: Uday Shankar , Muchun Song , Andrew Morton , linux-mm@kvack.org, "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Oscar Salvador Subject: Re: [bug report?] unintuitive behavior when mapping over hugepage-backed PROT_NONE regions Message-ID: References: <82afe852-4098-4eea-a646-37beab88604f@lucifer.local> <935c5dc8-03c6-4988-9bef-3c2de09e9efa@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <935c5dc8-03c6-4988-9bef-3c2de09e9efa@lucifer.local> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B6EB0C000E X-Stat-Signature: wr5tb5yz3zr3gdwxghxzytag5jhwwyhm X-HE-Tag: 1739037211-23699 X-HE-Meta: U2FsdGVkX19yc2cjythUq7m9ArTJm9sisI49Ywm2yHGV6w1qDML58aRHKQ3EZxuUVUfoCqZpfvbxGuxriS4wjsWgfnDbjWtksUf8SQY9zaIano5Jr0AerlbaBKD5LG4pNK/BWvuYBvIm79ocUVCzPvPGJfn6xOgjXvCi3vD0di+BQN2RIaj3672LCGdq9GLOpuDuFWYNJBUbqdZ4TPzamxESQ5CZmgHmhJoj0ny977XyK0Y1Jr94DsQZnGEN/HdreT0kbBICTQIIRkOkykM1WDRqPmRpDOB3pD/1gkBV/mN03FS5guPGxdYAN9UVoV1S6eQ9vM5Y03lOoUKDv9SPmkrZt/lcP7RC3dyJ5OEMjLki/NNFv1Fouhm6L6RYtnV8sYToQQ/KBcXEWSVn/6beRx5yw4SQSFgMi5gu1ifLZZPnc9iFV0UylhITswouP9EWx7a9PU7MdthrM3QbT3F9+xQsN7Q7QCKtwOYXKKbYjHdovAr+mQAOruDv/mf10ah87X0CyeZRWLjXb8gpGU8g1WJ7GEd381V4hZcmZwNndFne05v16p6g9zjt0ux2smfJ3ilvGuMj3A/I2CNvz+DEmVuSVbD+jIecRm0oluoY9+IDWa75J8e4gfoyk/tbfAhba8bPmtnAlfAQrXwRTrMZJsSn1au4QXpCB5iOQE6VLD6LPLLh0DWKJbrH8uIIaa+p7TMAFsGeP4CtKhSSpdAz2nd5BN2d4+Js3XqyhmIx0EVAWFjUsZke0/al7MsnZtcF8108Frf3+eernyAcVujZhSgEikEYxyeY4/KFOFiSqAOaHv7dO9Gz4v/kgMVnP+CWnBVmLxMVYa87Ig8w2XLIiwt4Ntx0k5E2gpqsy9FmJmtrqRp7bEOyqO5cKfjuRJv5BFKDsVCXPcdWJUVwWDPsX1cQY5e7cZw76MhtoDVz4jD5T86Mrdtpu1BSNodtxYQd5bk7ZQN21bY5GjqhCsG rR+6CdG1 X3hmZ0gnUcnzNxB9MY+OtDhUdb9w7YwVBe+TN0++7YnpyGhimDjY3DnT2qGHWx+gYcLkZqZBjIZpY+XaWYsb9rYHeTdlZ7pxHKOA1SqG2icIVeBUk6uditl+CSKyCgqQN/S/Hw3yMXe1swLGwN9gNEXU0pRoJQB+xXuhtrQYao1m2/zCE3Vfg2Cv/y2+sebyWbnPVz6JXfwaARs7kflVVKJei33nttxQNqMw3TkpLkzJLmORKw+BQn3qhsZHJ89+gQXYEBdRECA1pfesVL3LPv5GIyfJrp8vfLfdV9AP19A/z49hFVKcJr5yfqkEp0TPZsv9q6TQUg1xmKq5icm0rL01DvC7Ym6HKob+JvWIwjBbrDaTj67CJX2ButOgzWH+D9xRxoaRBerNvdaETkC0MonairNDZdFZvZBgVJ+HP+zwg9p4yQ0ZAy/ahWByaAirZZ8UW2Unumblr39bVtnWo1CvUQyTHUgTZGjWf X-Bogosity: Ham, tests=bogofilter, spamicity=0.232230, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 08, 2025 at 05:40:41PM +0000, Lorenzo Stoakes wrote: > > > > We tried THP around 2012 and rejected it. The latency tail became a lot > > longer and fatter. Various things have changed that might make THP less > > bad today, but I am not aware of anyone reevaluating it. > > A _lot_ has changed. Try it again :) > > > > > I think the problem with THP was the mmap_sem. Given a heavily threaded > > process, the mmap_sem tends to be the one dominant lock in the kernel. > > A lot of work has been done on reducing mmap_sem contention. Again, worth > another shot ;) Probably worth it, agreed. But unlikely to happen in the near term for various reasons. One of the biggest improvements was actually userspace. Glibc malloc is very eager to call mprotect for reasons that imo never made any sense. Replacing glibc malloc with any sane allocator will significantly reduce the number of mmap_sem taking system calls. Another hard-to-avoid problem is all the variations of "ps" that take the mmap_sem for every process in the system. Jörn -- You can't do much carpentry with your bare hands and you can't do much thinking with your bare brain. -- unknown