From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217F8C02198 for ; Sat, 8 Feb 2025 10:28:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73FEE6B0092; Sat, 8 Feb 2025 05:28:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EF6E280001; Sat, 8 Feb 2025 05:28:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B7EA6B0096; Sat, 8 Feb 2025 05:28:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3D2866B0092 for ; Sat, 8 Feb 2025 05:28:40 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 977E8A2159 for ; Sat, 8 Feb 2025 10:28:39 +0000 (UTC) X-FDA: 83096403558.02.3A6524C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id F3944120010 for ; Sat, 8 Feb 2025 10:28:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Zl4lqPRj; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739010518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=chV+V/1hyB9NCSlidtKvi7BNSE4pN5TuRrXwlZvsFbQ=; b=KiZg3n1mPOSe1e7ubWX48ngZ1BLAwAmXtOSc28JT62Ytd9/2G6M7z0iCRtT1pS067YO9b/ /G6G1R0Gu72gAZib7GGAOEvlVRj6oxpZb3d6eYEEjA9LzLCZ8EYu226Z/3WzO4rgA3AjY3 BPoMsl8590ib2hr7a/ppqezs2bvjHek= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Zl4lqPRj; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739010518; a=rsa-sha256; cv=none; b=Nj7a4n0iwOmsYz5LmUjTBBOq4uWFdmt96y+hhKMabd5dyRROzWONt440CZ0YL9ZHSNyP0K wF9RdPz/K+/TVn2wPernhavFDKGd8cfV65UcPo5gzSYCeYPqvd0UoCIdG8lGHMAiHk81ON Zrb9izypSe5Scm5TGAujNQy+9f8ozsM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=chV+V/1hyB9NCSlidtKvi7BNSE4pN5TuRrXwlZvsFbQ=; b=Zl4lqPRjoGbB3bhHs3O10FsvIy kwXVWum5S7ABvvPbuopdcenQqWDMbSK8l2HjM2QxFjiRO+UZnXBeEwQTrTQ+IcXEQ6rOyWiGfOUkW C2YogVtYdMho6uCfp7InFtsg/kjzL06C1ufjUgqWwPK0H6hOb7zwmnYc+3Pi+EKT/xCMJUtWO249w /YeFqvPS8YUe6MGf+TDTs/1eet/Is7jQ5f3GEH8lCXWUc3Lg4hlqm14J9HXNE4+uBu/5imIsUyvkr cd+umA4dZUTETdH7FKsCM619u0BFrhtptDwGPQrUXaZU5RWNg0cQDQiPyRhXTMp27kOZOoVRfKdaa rhSSZOeg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tgi4e-0000000AAeU-317i; Sat, 08 Feb 2025 10:28:32 +0000 Date: Sat, 8 Feb 2025 10:28:32 +0000 From: Matthew Wilcox To: Bart Van Assche Cc: Andrew Morton , linux-mm@kvack.org, Ivan Shapovalov , Vlastimil Babka , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings Message-ID: References: <20250131191231.1370466-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250131191231.1370466-1-bvanassche@acm.org> X-Rspamd-Queue-Id: F3944120010 X-Stat-Signature: qm3ctkzorn9ww7aw3armmhu5t5a3axa4 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739010517-899196 X-HE-Meta: U2FsdGVkX19GxEO7wejZU1HIMzhYmwSRw8yMwdagg6GfkAD7ICoac8/TNeZATZfZDk8+fyOOw7rXdoNk5XsQboSIF8ws9/hZhdHZLGZNQ5qoXPLeK+EpkqN1KIB92A94w6IAOuVQprQJg4eLuW9VaPAyP7Z44ZB5P2dKpKzrh4aTpBiUSfV9a4fcMRSFu2B2uTjluBecKt3dsWari/b+gkZbQv2ftGZrAeCbyqtEnLrcjlxAwJtmHaEGTlXALBWKS7e9GjlzqRu1bpV7OzRLP1eoIDKelnYYJUlergSlOM0CsR4ncbxYAhCNXbmZ4hFIz0nM824mSQj1fcC0f4D3dea8Ttpz4BUOoPJ177GpX/XSnWLLxZLPj77n501t+nxcp5Hn+D5HMAbXekb0hidttJ+H05oZcU3XaRhSOmhewl+WnoaXUv71qryDV2hA2TZ9nl4uBFF++jkMunDAboJeW9EXqDQYXiWIioDWTqGTl0dvD+AfOIGOhGRCdo+cj+DzHUg5LruPgJBu94lEpxl++gl6MUujFTFp0cKaibcFj7bgKJGWPYiNk2RziGMt+Esma/HHrDE1PMnDvj/aiWbmsZ79gUaDt38z8trnTaelY8Ip+QGlr6MnDD5Xay5+55LUg+KaMCNsdKDGdY6FH0+WrGrV+fOmtd2fOpS2QWwvJ5SGloZaj3h4kUFjNDfczAX6vzpX6FWqtmH9Ca8gFnFh8MkqpM2qhOMAD6Y9EAQe+bTcy34/MCVxfF7kL6yK5dUkCPDE7zhJUoNRoxEnst4buXXCx2s6MUch79ZzzA4ie0s5uDxQ2JvqUbQO2JDIQvJ0Bmz9B0u7Glp0ZQbGLF0uLRdAJvx0mJ9JSDPOGqO4lVAY9hIadUT+6ggFlzKYLFeJuAgWwAd7B+LtZK+AnTA7opI0ui06inVFZ/weWNStMrqnuw5HnzNd8fNtcdHW6pLO1EeUlRD2JJPeE/+5xEQ 8wy7li+y 0m85da5nq7vodX4MrjNL7AEzbxxrjmW4wgAKN7CMFd5wF93rfcDn9ZA8cnKswdY3kndbSFP29wuUk/ZNwuxoelWZR84pDzd+mAypMvggyN4B5tjS5cvYA3yK/c2z8oMr+TaGZ0G1Kdi72RZjUSOjheXvRtDvdQ/ErN7AAlohYcsh/YwuNuAc+/cfGCE+ng663X61zKx5TKwzaz91xXsBIi/mJWvIvyXtXoU9nsLueRfBFVGtReN2Hf/r8BIre1a1C0PuV60dGQmJx/IsksWFuCsLyVAAnLflcu6no3jyJmf3TJr4Y9tsmk5JpVBlCl4XENdSl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 31, 2025 at 11:12:23AM -0800, Bart Van Assche wrote: > Commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") > suppresses some but not all compiler warnings that are reported by clang > when building mm/ with W=1. Hence revert commit 30c2de0a267c and instead > make NR_LRU_BASE and NR_ZONE_LRU_BASE integer constants instead of > enumeration constants. Additionally, convert the item##_NORMAL constants > from type enum vm_event_item into int before subtracting ZONE_NORMAL. The > latter constant has type enum zone_type. this patch was NAKed last year https://lore.kernel.org/all/ZnXC5Xa4R0Mp7FCB@casper.infradead.org/