From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B5EBC02198 for ; Sat, 8 Feb 2025 10:11:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7554F6B0092; Sat, 8 Feb 2025 05:11:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 704F8280001; Sat, 8 Feb 2025 05:11:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F36C6B0096; Sat, 8 Feb 2025 05:11:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 46B176B0092 for ; Sat, 8 Feb 2025 05:11:54 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E026816219C for ; Sat, 8 Feb 2025 10:11:53 +0000 (UTC) X-FDA: 83096361306.07.AE1AC62 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 2468D4000B for ; Sat, 8 Feb 2025 10:11:51 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="NU8jo/aU"; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739009512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g3Z94bETGQeiDOIJu0r91P2vvPEJCA5AYCK0Qiv6LYE=; b=YZQzA5myVhaWylek4vhb/kuFAHXiDr5pRxQE217/RdwkwzQP/+5iNdAWb3zwH5oKcuNzEe d6szFjLuYcGRu7qQU9adCRdrP/L3PVnHtgkBpPn19FGnzp9J+hT+C5JkDTmTxEJ4dmhWFQ IE7/GDoy96xVpiGfP+DT4raGX6YUJyk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="NU8jo/aU"; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739009512; a=rsa-sha256; cv=none; b=1LbSFGbcrFNf6uIl62eUjM5A7YsLkV6wrmSQaznoiQ11c/nLJG5Q2pjvd44y4jLnOv/M0x LYPFCj7mPXvg5BvmmY62IlaTJMPSWn2NvaH3WPmtoAG9X0hHK6SqiXvAYD5XVUAcxWRLlp E4e+m6cOyHwKzRmH/bgntE15bIbr6R4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g3Z94bETGQeiDOIJu0r91P2vvPEJCA5AYCK0Qiv6LYE=; b=NU8jo/aUuMYlL2bMSPJulrSSFS Kz9EhAwK1QsnNlf8Bu5FQJoBrR+SF8RZs/jjxHDIZt/wHZIcCzSmBgQzL10ISIQV0yxh5ihCkaifg stTtauwYH0SPg0QB3G4T2ld6GHKGCxdQCd7AP8ySh063u+eymiFc5gK29quNsuxT+qCremQV92JNi Vlq+HmT2ihV0qN9+MEbf/uia8gjUOky9f/BpArQeF7G+oxDVl67E3TrA367gW5ZXOHRNxq67GICiW /x7Jvo2Ij3xpQ5gL6tigzRr4pUDs5BJcNTUkLMhOFB8CUlAWeqWpXLtrXctqDcVXLvswVdPszNYu7 tfGooJQg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tghoQ-0000000A8iq-0fM5; Sat, 08 Feb 2025 10:11:46 +0000 Date: Sat, 8 Feb 2025 10:11:45 +0000 From: Matthew Wilcox To: Joanne Koong Cc: Vlastimil Babka , Josef Bacik , Miklos Szeredi , Christian Heusel , Miklos Szeredi , regressions@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm , Mantas =?utf-8?Q?Mikul=C4=97nas?= Subject: Re: [REGRESSION][BISECTED] Crash with Bad page state for FUSE/Flatpak related applications since v6.13 Message-ID: References: <2f681f48-00f5-4e09-8431-2b3dbfaa881e@heusel.eu> <9cd88643-daa8-4379-be0a-bd31de277658@suse.cz> <20250207172917.GA2072771@perftesting> <8f7333f2-1ba9-4df4-bc54-44fd768b3d5b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2468D4000B X-Stat-Signature: rcpz7cqkos3mfp3ui5jakyusd3pqyj8a X-HE-Tag: 1739009511-576617 X-HE-Meta: U2FsdGVkX194QTdIJfeRGtUGTpcupnH5rOlndq2vt1fCKt8SO3c36s8j5oAlajyHsEOB1PjBr+TSC4hauxNIJ3NJuO6rDoheScfSvM1h70gxcPkPX4ye41Q4KuKe3xrR/A9pkDByzVNM01UA9+8g9reLyFBbIiQanXFQxW2ISbPTiWCXEJhjSOVjoxKKCX3peoS2gR9IQBWnbPezNfPeW0z/CTNDNgJyQUbYBoZ4hLedKU8Zc7G/Hv5WboLWD4OXWnwavevEcHO5jbJwpLvb5f37r3dmCPZ8e7GNVvhIcNVHZOLbqDVDyImGd/H1lHr+jgBZy4Lcy3/L/4O3ETX4O23I2wvtg5G6eW47v+mwSf4ue5ZYeUmysESzMw2OlqmjQI65lMGm6YM+NKmPc/kSMblhXTwh4h/IVR4ltfJWHYm6SqNKb/1pIEf0Od1VFo2YBnttw4AUPDwR1NkORB3ajOoVsZE65x8iSYe9ua8PCxLiL+EjFa12HejJRSsrn0PM/c3cHLI1npyGj4az0++3VEIR8yiOiskmUGeaDg5AWfeOZu4HpW9jXnE32rdZ2rJmZGCqyOEMlMmX4BbZbrlxMYSLVrSaO9B5IfdNUAWRPaqFy4yt4x8gbDWGs2cXTB72SiawYt5UBb2drYp2Nfz4zspfEMajFfnqqr9DgEyZKs8s4ZhYcsWHMfmt22OM1PvmU0PGr5tCw2ycPCaKjiPBt2+2movXY+KUo0I3JmIX2s+733TC6oxIIuM66ghyCm3b3ux1fab/eELZyvHUeR9CtOU3l2CZFyszalLC8/4paG7wFkygIfBWHbr4NY6d1ol6CBcmVsmtEC1uCFESxc9iXo5rPGqF75mhFc/2h2uPBtu4ibeDBtvse/TZVRTGUacPGjUvWr9vCGm3EkfWLpsBPe6rrbTOMVuN7q0ePoen7O6r6DKiu4j+mE2Mw2XgMjr/oZTQL/Qmhl82gg/QFtx OUo2zLbc udVMoVAfmwXQeI+aYSWDV7J0sxNWiQfGF7FNNjL5D6UENrYAlRhWAxUM3VC9/zb/9ekppBnZEZsNsymNLJxt7ckE/+2dyQSrA4QFo2AGXWm1XbjKh+3ryj4kYhTNDuz71JUIu3QcFJUp/sUXkgGcj1EfTtM3Xm6GFRdICeJuwK7bBY2ujQ2TcZdyeHHgd2T+lJcuFENHPFGeUAZ+pshSHSKxXtcrYGkZ+bOTr3G79+hNrkOxHjG8fE88TmAV0+XS+A4QF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 07, 2025 at 04:22:56PM -0800, Joanne Koong wrote: > > Thanks, Josef. I guess we can at least try to confirm we're on the right track. > > Can anyone affected see if this (only compile tested) patch fixes the issue? > > Created on top of 6.13.1. > > This fixes the crash for me on 6.14.0-rc1. I ran the repro using > Mantas's instructions for Obfuscate. I was able to trigger the crash > on a clean build and then with this patch, I'm not seeing the crash > anymore. Since this patch fixes the bug, we're looking for one call to folio_put() too many. Is it possibly in fuse_try_move_page()? In particular, this one: /* Drop ref for ap->pages[] array */ folio_put(oldfolio); I don't know fuse very well. Maybe this isn't it.