From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD811C02199 for ; Sat, 8 Feb 2025 01:08:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 157E6280005; Fri, 7 Feb 2025 20:08:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10778280001; Fri, 7 Feb 2025 20:08:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F114E280005; Fri, 7 Feb 2025 20:08:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D4403280001 for ; Fri, 7 Feb 2025 20:08:24 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 53186812AD for ; Sat, 8 Feb 2025 01:08:24 +0000 (UTC) X-FDA: 83094991728.04.F2FBDE9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 54AF2140007 for ; Sat, 8 Feb 2025 01:08:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hAwsm5Wp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738976902; a=rsa-sha256; cv=none; b=dcXeVyP7qN648cklH9B5fraAup+b5sDffEKEGoWG6p26njM1q017EYD7CaR+OPLcl6GC3n hlrdJ2gX1QrgAY19bSiYcTsJQH1P5xjiu+YOfKVcAdxOqtfb6cAus79shCdBTMs6v7ck3W VhcvZzTQc5s9eG4iKuzBWWVSyqeswfw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hAwsm5Wp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738976902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OtfwWOpr+HlJ/Tgq015gNWog2ySCjFtiPCDlievL+/8=; b=pej3e8g0TMHkROzfQsP08Ib6ABRhXjpurEFzWUokDsjEQ9Fy6d5tCOkAKprUeU9LjS2kvI xH5+1JJdxp1j/isAAw2DpT0beaG8RGL7sPCrPg7fsDL0aAmKRjXdwQ/5/P25h/Q8ho0//P FRiBjTDzcWm/K+xlfWUfZHSmZtEaikw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738976901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OtfwWOpr+HlJ/Tgq015gNWog2ySCjFtiPCDlievL+/8=; b=hAwsm5WpVm/9LGN5QI29kMKUAsmnci0gviWY0x7Z+NXYsrN0gE+dl2bcbgQA3bX1a5Mo2h 9INPpw2F2zik0eN6DokEV/2VsDwmgcnOtT/oDnai0uaNsGFvW03DpmKdKaTejO4REmRQf2 cQOz+7AeB7BiS1TFSF+t3qz29Il/yGQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-KVbfTAv_P5G4VeEzMLVtEA-1; Fri, 07 Feb 2025 20:08:18 -0500 X-MC-Unique: KVbfTAv_P5G4VeEzMLVtEA-1 X-Mimecast-MFC-AGG-ID: KVbfTAv_P5G4VeEzMLVtEA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 25B2E180056F; Sat, 8 Feb 2025 01:08:17 +0000 (UTC) Received: from localhost (unknown [10.72.112.20]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9FD130001AB; Sat, 8 Feb 2025 01:08:15 +0000 (UTC) Date: Sat, 8 Feb 2025 09:08:11 +0800 From: Baoquan He To: Kairui Song Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org Subject: Re: [PATCH 00/12] Tiny cleanup and improvements about SWAP code Message-ID: References: <20250205092721.9395-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 54AF2140007 X-Stat-Signature: p1p93mc1er7kwnifnt3azht8pgbrtmb8 X-Rspam-User: X-HE-Tag: 1738976902-510859 X-HE-Meta: U2FsdGVkX1/YrDVqPyv7onDt7tRjCC+TNbuHcgNmyJJtJss0XvPdA2+kwnGaeK1EvIk6SSkmC73oA0UG2U43UcMO9Z6fwGksmo7OVoHTrngwujSnF5jljb/ZRafo1kZ522ZWTEg4cCK/jlF+nRXIuzit3xSgZTGljGQeCtjXC0P5TmLnTF5NZayLfkYydKXZYVKQYHLb97wBfyfeCbeRkD/5Eff5oc+gQPF+hvDdFva2FbIaBUZPg0U7ZetPha8hN+bf4V9snZo9RYY9dd7fs+lyMep7iUr7wW6VxjTFejBXIbsKofsaZ5z6HlSQloi4T76/8LSs6I/a8STS/Lfrk6jfRshr+U8SBQ2I7S4K2ZHF40HTF4q4ULaixd4qRMMaTBv1gGVtHOt2iRx2IEzBHfmfswVpUuN6v180wNojg7XBL88zUkdsj0G2cZOkB/x5JzOWJAbaLq1B3YN+B3awqfzszT8/LsmIhIVS35lWd+wHthqmv3ZhQtwpAcwBd9370y88i14xM+96piAVYZg55AKHdf78Xxmb+bA7y+wbImngGHv7kYnFSNk2L2nhUYaO6TPpIWXuh5FEB7Z4vdJ5o7XDZ61YjDXEO4t9p2cd5k+swQfanyICPjrRPmCHDs8uyNnlzU+Jdf8SEPUIgDqbQmL2dvVWCSeIzJJKmVfqQh0xext+wYxSGr+Ope2ZcVeJL2XBUloVlIdDkICm1jacJVyDULlKBwr/XIhZAokUcVdWQfKH+Ej3nncNW1cwYHSKjgGjZARiWBdH6Ui8DuRzo2etkkYq5GdetPL66AwmDgE0sPE6sCJHGoLRFJQWwXBdsieK79MyWPoghVxsgtGM0QyrCNA5AUNQbZ2HYEkJWtVPTN03dKMlfmDRiwwCiapeNovNtjxL87jJ1B/Ik4BO42eV1NtZDNUEwjYQ6iCWPuQ8pGrmzy1vPEBOqZ2oNsVtMf9UBMQNvjQfX8y4dyf XedOn4fe rj/7NZu7m8r9DxXzGOrmUK5GRt52Pft4fZ2l3pXB2+QSz3XsN+1Ccw1aQrDST8blMk8PF7C1viJv7nLdF63I0EY4pCgMeTVd+CfLFj0f8X54jsI+QT/e/gBrY+pW57vlHkBiwtJlWxzhIM8DGslJBEON9DmTSrm5BavzLMPlPGNW3MzjXufQnwfK7wZppdb0mj8mU/2ra6RZ3kJWy8qyznwUoyO+nzyqka590op2DBDrJ6VLu3bhvFqG5hwsbVaOU+nI/jQHOmzLJsDrdQA1dbqGMF1CeYm8FWdFNtSyJlPVoBOY1qs7ihW4qD4tGq5e2X0wqaoHX7ch52C34pXcCTtOOfmpSMZ1At8vp2N11Pzvg7MHWzAn0MjXW1gxCrNbCMh1vpsPMTruC9SLG0EdO7USeUf2vcsJMxZVCndqoNFuYcCEWq02gdpUbJajNJa2rBGfhgGYlqyyPVe16X350gS2dyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/07/25 at 05:36pm, Kairui Song wrote: > On Wed, Feb 5, 2025 at 5:27 PM Baoquan He wrote: > > > > These are all made during reviewing and learning below patchset from > > Kairui. > > Thanks, I've noticed some obsolete comments and code, currently > refactoring many parts so some of the functions would be just gone > someday. Thanks a lot for reviewing, Kairui. I have a queued patchset to refactor the old hdd/cluster code, it could be made about 2 years ago. Then I heard you and Chris's presentation in LPC in last fall, and your later rework patchset, just began to notice the big change in swap code which is not what I knew. Sorry, didn't know you are still refactoring the code, so will stop touching swap code, look forward to seeing your new refactoring patches. I will keep an eye so that I can follow the step to update my knowledge about swap code. > But this surely cleans things up and is good to have, refactoring will > take much longer time to happen. Thanks again. Please help add me to CC when you post, I am interested in the new change. > > With the V2 update of "mm/swapfile.c: update the code comment above > swap_count_continued()": > > Reviewed-by: Kairui Song > > > [PATCH v3 00/13] mm, swap: rework of swap allocator locks > > BTW, I noticed most patches here are patching legacy code, and not > directly related to that series. > Just to clarify, so people won't need to worry about missing "Fixes:" > or things like that :) LOL, right, at least people following the recent change of swap won't misunderstand.