From: Baoquan He <bhe@redhat.com>
To: Kairui Song <ryncsn@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, chrisl@kernel.org
Subject: Re: [PATCH 00/12] Tiny cleanup and improvements about SWAP code
Date: Sat, 8 Feb 2025 09:08:11 +0800 [thread overview]
Message-ID: <Z6aue/RyKYL1Rzvm@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAMgjq7C_93Z8abbBb7Jfjd3iMAAs8EeLBmPOeXrR96NaVgz8cg@mail.gmail.com>
On 02/07/25 at 05:36pm, Kairui Song wrote:
> On Wed, Feb 5, 2025 at 5:27 PM Baoquan He <bhe@redhat.com> wrote:
> >
> > These are all made during reviewing and learning below patchset from
> > Kairui.
>
> Thanks, I've noticed some obsolete comments and code, currently
> refactoring many parts so some of the functions would be just gone
> someday.
Thanks a lot for reviewing, Kairui.
I have a queued patchset to refactor the old hdd/cluster code, it could
be made about 2 years ago. Then I heard you and Chris's presentation in
LPC in last fall, and your later rework patchset, just began to notice
the big change in swap code which is not what I knew. Sorry, didn't know
you are still refactoring the code, so will stop touching swap code, look
forward to seeing your new refactoring patches. I will keep an eye so
that I can follow the step to update my knowledge about swap code.
> But this surely cleans things up and is good to have, refactoring will
> take much longer time to happen.
Thanks again. Please help add me to CC when you post, I am interested in
the new change.
>
> With the V2 update of "mm/swapfile.c: update the code comment above
> swap_count_continued()":
>
> Reviewed-by: Kairui Song <kasong@tencent.com>
>
> > [PATCH v3 00/13] mm, swap: rework of swap allocator locks
>
> BTW, I noticed most patches here are patching legacy code, and not
> directly related to that series.
> Just to clarify, so people won't need to worry about missing "Fixes:"
> or things like that :)
LOL, right, at least people following the recent change of swap won't
misunderstand.
prev parent reply other threads:[~2025-02-08 1:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 9:27 Baoquan He
2025-02-05 9:27 ` [PATCH 01/12] mm/swap_state.c: fix the obsolete code comment Baoquan He
2025-02-05 9:27 ` [PATCH 02/12] mm/swap_state.c: optimize the code in clear_shadow_from_swap_cache() Baoquan He
2025-02-05 9:27 ` [PATCH 03/12] mm/swap: remove SWAP_FLAG_PRIO_SHIFT Baoquan He
2025-02-05 9:27 ` [PATCH 04/12] mm/swap: skip scanning cluster range if it's empty cluster Baoquan He
2025-02-05 17:07 ` Kairui Song
2025-02-06 1:40 ` Baoquan He
2025-02-06 2:14 ` Kairui Song
2025-02-05 9:27 ` [PATCH 05/12] mm/swap: rename swap_is_has_cache() to swap_only_has_cache() Baoquan He
2025-02-05 9:27 ` [PATCH 06/12] mm/swapfile.c: update the code comment above swap_count_continued() Baoquan He
2025-02-06 7:50 ` Kairui Song
2025-02-07 2:46 ` Baoquan He
2025-02-07 2:50 ` [PATCH v2 " Baoquan He
2025-02-05 9:27 ` [PATCH 07/12] mm/swapfile.c: optimize code in setup_clusters() Baoquan He
2025-02-05 9:27 ` [PATCH 08/12] mm/swap_state.c: remove the meaningless code comment Baoquan He
2025-02-05 9:27 ` [PATCH 09/12] mm/swapfile.c: remove the unneeded checking Baoquan He
2025-02-05 9:27 ` [PATCH 10/12] mm/swap: rename swap_swapcount() to swap_entry_swapped() Baoquan He
2025-02-05 9:27 ` [PATCH 11/12] mm/swapfile.c: remove the incorrect code comment Baoquan He
2025-02-05 9:27 ` [PATCH 12/12] mm/swapfile.c: open code cluster_alloc_swap() Baoquan He
2025-02-07 9:36 ` [PATCH 00/12] Tiny cleanup and improvements about SWAP code Kairui Song
2025-02-08 1:08 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6aue/RyKYL1Rzvm@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryncsn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox