From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA1FC02199 for ; Fri, 7 Feb 2025 23:52:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE379280001; Fri, 7 Feb 2025 18:52:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A92BB6B008A; Fri, 7 Feb 2025 18:52:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95A4F280001; Fri, 7 Feb 2025 18:52:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 785AE6B0089 for ; Fri, 7 Feb 2025 18:52:36 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 088051A0E9E for ; Fri, 7 Feb 2025 23:52:36 +0000 (UTC) X-FDA: 83094800712.24.0A47849 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 222191C0002 for ; Fri, 7 Feb 2025 23:52:33 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=gbUQvMIh; spf=pass (imf18.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738972354; a=rsa-sha256; cv=none; b=n9No/TJM1eky7g3geXMtgGvC1T1Zc5zmVs5wf2BtbonfpcLUshjedJw+IDHEoS0ngVHuvM TzN8MYfeImYlxE3fpGbUplCikI26Jg4mUkZaMte2LpTJhg6LTXAi9AKdRjxyJNTmVbqZHJ b6b/Ot378rf2d1AQChyxn6q+eNW4JDk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=gbUQvMIh; spf=pass (imf18.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738972354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQcVjQRwopmrHuG7wgsXbQFTOWJLCaxzXjS7jJ9aNqc=; b=nGNz1ZjdOuN0MHyQwvOdvftryVZSSdN7w8X6agWz+VzpF/Ti0eX/q5Ap7qok+6CmxBINeV i8gjL1J8Fr895QxrMW3vaSVDSEVFUC6atSwpv6A4MczHLfilwYbq+wFh1owF8Vrd2njLFs BCBcM5cITN7wKF1dQQjBzlTU16byjrU= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-21f48ab13d5so37920605ad.0 for ; Fri, 07 Feb 2025 15:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1738972353; x=1739577153; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oQcVjQRwopmrHuG7wgsXbQFTOWJLCaxzXjS7jJ9aNqc=; b=gbUQvMIhuvcfjFMUItjap4+KlwDiW+d8UxThPScoSMAuJMlRXx+Oyrru0o4wrSOfCu rDAF63GE72glzAQKfzaqPp76KSpd5Ape6Dw5usA3eI5MD2Yi+xcLubO79CILHQhPGleV UvSWXugDRX45/1z2gyODToHJpRta3H6Pylsqxu9wfu0DydXOMOJN+o/GIS+oqN0dtfr2 YzGwBIqTdAN8VMG3GDI6FkBS+jN+UosVBJ9EsiNTHCTNHtPlfoHxt3nIZqooEmu3mMrq L/e+XE+3ZKXx+pIwgVzAHKS7mcNYagA3iRLhnwBhn/cRQy0rHsHuiRdwNiJGp0xzdcmi PgVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738972353; x=1739577153; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oQcVjQRwopmrHuG7wgsXbQFTOWJLCaxzXjS7jJ9aNqc=; b=Ty4sigyfPZJIypDtiVoPBIO37iYxhhV7jObrnT24ZfaIhOW1wQr9vTaZn8WyhdC/Ij M6kFmz6wLjNjkkvlCd0L0D3V1lH3KUDaiDq3zq5BkTXGqvKsy24bRE+g6EqhHiR5Tixb pAxQdH6ms18i5BaED0lSmXqAprxKWpNFU+HhLQdc0xMdlcXZ56ZvlK1rRYjskZeOhqEw c5aFK7nLXCW/VEowHrQYVPRPTc8iyiMK0dKXexjI73gR7Kbq9s8sNXhYKPi2FXP+J3UP JOp3q1qB1psXVA2PJNxDnsV/a9pG7hCo8HW0IwMfbBCPi/c7pGu0YzqSlKcIGmkLDaAs P8eg== X-Forwarded-Encrypted: i=1; AJvYcCWUhfITIHLc+dwgz4ztpeZa11mL+Eqz5OhfOXwTqEjyUdodeDgRHOpIamz7uiBB+8xR4C1jZC0/5w==@kvack.org X-Gm-Message-State: AOJu0YzyPDfZoM+UEA8qrZ9jcaL4o7aEW4+brzJlACYYBErn1zyOO31l ryvqWTYiHvzb6yDe8rQ7OQz+4Mp/Vxrm2gFDA3l+Qomy9RzZPoP95V+1sUUHbgU= X-Gm-Gg: ASbGncsqpicgisFTIfsdR0Sgb4fqRVSF2xUftKaYog/WnJ1Il0i7a15u3pUoBsvJnTZ /UnJ8koHN7D+iipKHQM3v8U6VA9X2Kny5kgqre5yEWVFbfaHqcRIWOsne8BRthEjyYs4woISmqB oV9xgdkupe47h2p7mHe2ioiHsPU9uRksT10c/RdmKkWE3uR98yMgYwtuCf2HxDSIaVXa6ta6B0x Xkwdg1SDWUPeQvdGPmJEYnikaevltUlxpuXEhbVSzjwntSh58jYdHUoZhCxNa7KvYSTwepgPEHl QdhSACzEbUoAEmaaX/coN5MwDg== X-Google-Smtp-Source: AGHT+IH5jRZW/ovSUPH8eJRvmKh5nXw8ULDIWD5h4+evTSN5U5cvmcLVFvRfp+GmY1NLadqVCxbddQ== X-Received: by 2002:a17:903:94e:b0:215:9470:7e82 with SMTP id d9443c01a7336-21f4e6a035bmr94058495ad.4.1738972353039; Fri, 07 Feb 2025 15:52:33 -0800 (PST) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f368da60bsm36436795ad.258.2025.02.07.15.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2025 15:52:32 -0800 (PST) Date: Fri, 7 Feb 2025 15:52:28 -0800 From: Deepak Gupta To: Vlastimil Babka Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com Subject: Re: [PATCH v9 01/26] mm: helper `is_shadow_stack_vma` to check shadow stack vma Message-ID: References: <20250204-v5_user_cfi_series-v9-0-b37a49c5205c@rivosinc.com> <20250204-v5_user_cfi_series-v9-1-b37a49c5205c@rivosinc.com> <6543c6b6-da86-4c10-9b8c-e5fe6f6f7da9@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Stat-Signature: iceou95kk676fpxdyzpigi5zswm1z3x8 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 222191C0002 X-Rspam-User: X-HE-Tag: 1738972353-484844 X-HE-Meta: U2FsdGVkX18v87mjTNfDBzhpJRzSb+CMG5p32xiTbZtbjWj8jgovNxUSpsCi5EfPEMQejxcIOPrZ8BLfl7JrUlhKtchewRSifNykPVAzF2LFPAVL+9xs7NMoCf5S7FuxJI9rwMrUd7ysMrI3Q8uX/xTLlCVbvcxt+y+JhMzrSmOcZJhGip06iye2B57y0a0N1BpY/cPnZ33r30wsuaWUPosSbbxnUjgdug4uUkGrUkBkULevhkvR/hU8gyzjHCK8vhgL65n9JB8pN/LBxK4eUcEZJsdzAqy+Fba4uWCTWKTOrQtJD6FFq5eD/7k8UaqOiHZV2u5Cnf0ZwJdLFNylCyl0xKCPEST/AbeFGb/IVGORrmhzBvSnC3hTzWMfjNHplgrbLCOTKaB734FYwaAF3SKWABgZOVSOyHHYZd3TtQGZNyItzgrX0CsY8u7XFFR9/XemPqFIGfRdOHsOkQo8lEXDFvT+TyRyeWL2nYqX4ItjvzZEwyAsh5RwYACwTEUKi91/GkBI9dwHQ1Yo87aEsjAFCQKltYw2CtDkdAOMGLydr7HG9I44U00m+CI1PqIXShav9IdOU5a6ENmK8Wb3opSHhqJoaKJNIBhmyKUWeKA4DCCJ2knpolws6s6oyef7C+HTK38+kTVdamQ2pTrkyif+7VOpL7Q/I6ew1rJ5q86lcUGiIR0XpfXc70RJup49EO3nCmZicYLnhg2gBQ+FGFAUGZx0Wqf96Afxw60W+wCLHxRj1E4iiEPzDqxSGCaVS/YhmLUaRN+XkUrr3cCqpbTeIhI/4/6FLbbRBuyLopOlWhPO56C2yoxieKrgjyt5Mx8cjtDC1HVwGJ0xdu6mLrH6CIzfcGK39eyIctc7VM9Vz/Dk6RZ5Ku9psZULnCZ6eZjzRxXvLi2YndsKOoHyuQqKmn2GpDPPBLiHwaiW1TSzNhQE8iJaIVADPTZ4sR+xjKRRITqlmU/djXj5Lz+ aNEAATuk vWFgFX10fhk+J8FZgiCG6CxFkjzRHan753BRaHBSJfTFrQKWJ+lbuIDcgpTBwxKWgEhnctkxnVlkSJ50wKR+OVQebvWnN7OQkwZZ2NB+JmLmEupmwfenvzv4Gmqtl8WnzS75ZwvRBw5UaLvriNTpK1wa+9/IS9KZpsGVcteyKQtjokCl9nlY/23G3Wr9suW2YLzAhzD4Ky52thFgyiQHJvIonJjAQbG/g+DrzX9SgT+Jmsl/2Dme4M/xAa48ky5QgH2iOmIJW8LNzIOljiiCbNQZ73CABUifO9IafxaPG6i2sSszo7zOA8t4gEpjiqh0LrtjR4im5oB99u9+r50/2K4WdHsdWXDVleh600teUavkf7gUFKroVtHG8F/RVB045I/6UV3r4H2pT1gi0IFq9eh1+FKIwGmwP09Jme4IuDaubfm6DHpRFqczoUrkugoWBaJ3Gl+B8ZGJubFBoVXCHpSAIqAKNknExqJMu71jPmj1S4FZwHkhKskR+lD2tsmOmHG6/CFX3tItns5c9mA8JZl+ELoIukIFKx6mEKid0QIo8N+4TBGZ8B5eQ9wt/R/cQJ0Gi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 07, 2025 at 03:44:27PM -0800, Deepak Gupta wrote: >On Fri, Feb 07, 2025 at 10:27:10AM +0100, Vlastimil Babka wrote: >>On 2/5/25 02:21, Deepak Gupta wrote: >>>VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack >> >>I see that arm GCS uses VM_HIGH_ARCH_6. >> >>>VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow >> >>And RISC-V doesn't define it at all, not even in this patchset, or did I >>miss it somewhere? >> > >hmm... >Something wrong in my workflow and rebasing. >Thanks for catching this. I think this is the miss on my part. I had this patch in last series which introduces `ARCH_HAS_USER_SHADOW_STACK` https://lore.kernel.org/all/20241111-v5_user_cfi_series-v8-1-dce14aa30207@rivosinc.com/ As part of above patch, `CONFIG_X86_USER_SHADOW_STACK` was replaced with `CONFIG_ARCH_HAS_USER_SHADOW_STACK` in `mm.h` to define VM_SHADOW_STACK as VM_HIGH_ARCH_5. It was all fine because all 3 arches were using VM_HIGH_ARCH_5. However as things progressed on, arm64 ended up using VM_HIGH_ARCH_6. But arm64 gcs patches also landed the introduction of `ARCH_HAS_USER_SHADOW_STACK`. So I dropped this patch from my v9 and didn't pay attention and actually missed the definition. > >>>stack). In case architecture doesn't implement shadow stack, it's VM_NONE >>>Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma >>>or not.