From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D90C0219D for ; Fri, 7 Feb 2025 22:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EEEA6B0083; Fri, 7 Feb 2025 17:44:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D746B0089; Fri, 7 Feb 2025 17:44:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63DC06B008A; Fri, 7 Feb 2025 17:44:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 473186B0083 for ; Fri, 7 Feb 2025 17:44:18 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E8B9D140CC8 for ; Fri, 7 Feb 2025 22:44:17 +0000 (UTC) X-FDA: 83094628554.08.D84AA4C Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf14.hostedemail.com (Postfix) with ESMTP id EA31F100010 for ; Fri, 7 Feb 2025 22:44:15 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=xqFTqLMV; spf=pass (imf14.hostedemail.com: domain of debug@rivosinc.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738968256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o2ipDsFh+4Wi6+DfKBkgvbX5MRHqphXmotwjlbhmRh4=; b=yR+7YRcPtFHvkt3O0j+82DUbkO5M/zHQKE3xXaz7Evadn52SIB/ax2V1uKwXJ3lJHSuLy4 sm3CAM1Tyr9j6kaJbFMTOJSjaeHxoPpX/G/yrRu+2kc4zLJ9uM160s0C/lf6dhP4+QoXpV 4Y5BjGH1uoE1tCXm5Y7ultpVVa5Wu9c= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=xqFTqLMV; spf=pass (imf14.hostedemail.com: domain of debug@rivosinc.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738968256; a=rsa-sha256; cv=none; b=afHjSrdu3YF+NwfLbRDvhIC7WZXwffeySq4Z1akEIMLIuuYJvUZpuhvYUE71wGEvm0sHQ/ kkuQrnFDzLWamvorBxnY9BPWjA3/judOhj34gNBZimdNlUKe05lBWN+cQn9fZ9LVx4RcqT jqDB2ASHfGJIi9wp4WPMmxE3DN1BJNc= Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2fa0f222530so4449021a91.0 for ; Fri, 07 Feb 2025 14:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1738968255; x=1739573055; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o2ipDsFh+4Wi6+DfKBkgvbX5MRHqphXmotwjlbhmRh4=; b=xqFTqLMVQYsWnBo0NYbwApCNeq7hH/vuUibS2fiAovU7CFQnIsKM7xUlMK+KkQ4vUf KcMirQZiXSDlbP6eM6UF1a15SSNqt/UV0x8+Lsq/d0WNE5RmqGPu9KEjpE4S1hgD34El RrJBhR+td1oIK7laK6UbopqwU6AW6mVr16WceRH3Na8nol8eVOBBU04LHWeF0upBduXM xr0CAHIrwaFxfFRmVnEYNA82mg/LMG1jKO7m5WaGpR/eH9YiS3oaihwMSr6pCW1ujTv0 s1JmZmjD7bPjlHvtkpOpZExzQeBiqwcHVxqJ3mYLovxpX7y3ugbmzh3W7wNCB0522+vX RZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738968255; x=1739573055; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o2ipDsFh+4Wi6+DfKBkgvbX5MRHqphXmotwjlbhmRh4=; b=hpyhdltLBHD8kbtM/Cms2NOt0lG260uR9904iofeBPtjjFOlWNAm1J6vPKAfcVpgzl ZCSY5K48sXS9aDbYL2V/H4qEscorn97s91NnWstZN5Feb96zRIaDriLoB0Bhvj6AsgIz z/WB4o2KPpXUb3J4792ENyfdM40UfC1kuMRDhy9mrmvUrQY7YiDVvNU5CjyuMGa36ljq hp23X8/MxlBzc2vATOQKl/3KYFlo6ODuASN7rvQ4a1dbDxl+ATIKJ4HYkbPgs57dmBEz dXrFfFjfXv6NiB/emptKixKiwZJIrE1mrCGc0EWEGmcWxLqgFSiN1KZdYFEFznCT2oTZ 41BA== X-Forwarded-Encrypted: i=1; AJvYcCWpylW3cSpS2a+Hbm2GVH808kYQXxRpTe4Bc12K1OCrXg7jT7dcKMzZL+e4mjTBwbR+dx6sMOfrMQ==@kvack.org X-Gm-Message-State: AOJu0YxAaBdJ7qnIilFolYIgMItQIIe33zk7Y2qQfcW6JpZVtyTsaVuE 6Ab0noSdfbTHvXtnbXLlVhm8gF9SGjd6m9QZ41weEeHoE+U8WU3ppCFRryPDRCQ= X-Gm-Gg: ASbGncu1BSNKIiEF/7l28aqmMkrUpmuNkH4UjnsNnktjEt0V/mgkBR7FlMhVTwyS77Q 8qXxui6lwKXMXu7qeiYkWxwPPfwspH15/JG51/jgg9AZl1LpUXHu2+Bnukgyu4Av9gKePFmX/bA 7DrZPV0bbSwo78WmRSjyW3g1hdg9X7YEajLwvFesbedkZeIQKzS3dZXEWxGiUkJ+hK/9tZPZDi0 AhH7P8X2tgxdOOHhg13LdsY0oUrrDbNfVuZaSMJkLpKbpwM7FYzbUnM7R4Sx5qfdzKJAeuVpkA2 sr0hOlPq7ExKpiSmV1Yl0IFAyw== X-Google-Smtp-Source: AGHT+IH0ObGSX9Z5Li4uWD9lYbrpJL6WiQ/fR0RPEu4WFLYzu4KaceG7QOyaNMgDiAsQ/fdeHHOGVA== X-Received: by 2002:a17:90b:19d8:b0:2ee:6d04:9dac with SMTP id 98e67ed59e1d1-2fa243f02dcmr6699334a91.32.1738968254644; Fri, 07 Feb 2025 14:44:14 -0800 (PST) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f9bf6f268fsm5069384a91.0.2025.02.07.14.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2025 14:44:14 -0800 (PST) Date: Fri, 7 Feb 2025 14:44:10 -0800 From: Deepak Gupta To: Vlastimil Babka Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com Subject: Re: [PATCH v9 01/26] mm: helper `is_shadow_stack_vma` to check shadow stack vma Message-ID: References: <20250204-v5_user_cfi_series-v9-0-b37a49c5205c@rivosinc.com> <20250204-v5_user_cfi_series-v9-1-b37a49c5205c@rivosinc.com> <6543c6b6-da86-4c10-9b8c-e5fe6f6f7da9@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <6543c6b6-da86-4c10-9b8c-e5fe6f6f7da9@suse.cz> X-Rspam-User: X-Rspamd-Queue-Id: EA31F100010 X-Stat-Signature: 8xb1xk9h3xg98ugw61thjerbhh7n5esi X-Rspamd-Server: rspam03 X-HE-Tag: 1738968255-955673 X-HE-Meta: U2FsdGVkX1/Qc2IoFNKvZ3q0hMXz4ixlWAVMhzPMuiJAhvOPd7zHH/xUOGvgkMeZqKnMVszyBTf+TO7ZNsWZSO75BGjJPG2pgqmTZPQfXjXiOeaL6kX/wpy5ftNRyd9NDLcUE4H9MLC3295ynLenMhLSPBDeXWaVhqaRAhtRNCXxji2yzcFS6Az8a2f8PqOGJEblXFITPE/UuWU+GlCxs0WcggY7hZ5hoXmh73yhjSzpc/eRJ2Mjg2zDafE3llshChCgaefqSLYIhyay73AR27RhihE84xVJtE9yLW4ZfPxfVqdaOJiH9BBcT0EFyZsT/FTPBoW0tA4EC1UyEapkAkN7BsnyDoqdzTkkisMgVLAn+rSY1Ox+oBaKcZxgVfAGI5H5vrnZcR8U19EJCaF8PAiwpXOk/XE+i9J5GbynGn3HWHp2NfP02OJRxrbA7dq64b1BZdSOqYCQYFYst1oTf6FHKRy+R7dgJ78Em+I+oe4w+ELBFeZdsOZuBaWhu5gbnm9XEt2ymkmMEWAG4cZYOg+xiJx2SRVrlOb5QMq0eQjgTyPu+J5/Xth2c5+9B4E0Bd65SPObvJ9eI4l46EQehrMWQDTEETdoy9AVIIlLPu79qGS8lbwKOK7nT1rEw1askjrfxZSOooj5yRHrURRJfZX0T9lODgbzf5zQK/ftpedKcTkreUYOXXsZTiTR4xdsHzHJbwrX0sSho26TdK5umTjx65i9FjXKBcEPZ8dOWQkOvXziWovBEaxf9047JyZtFWi8pHQA9qm/fGnoIvpI7Li41fgnX6bynRjYCs58jqOBiTlAicu9c3S0uRaWYmyi7o5Qp/3hNZjo2ReYn+n9ZzvvdH91BWd+2Oz53V0dbwO7CLjl2WiLAIjrIy2RBlQsZQFcRz2gTTSqu/q/7NDCtFvXh2V4IIP3darcHOEbveNEbGJ6zTffCXHbIn4LSshZ5NWIS/hmv5dH0Z0OccF jj6R4v+d n4AyGRErLx+HWGqtoExPQqh3YqOSOU9U6hE3Nq9+5I3/q0MTG1zz47XjnmQSujo2Y6kg34FdIxptiCPsIhm0dh6EhrT/LQ0IEL9LV+N3eWm24FDD6+ZnRIrKsx8CC8dwdG6rLFYbgMvH5qpZOWaKWER5ZtTISfDnqGCeqnb0t0/jQmW3L2iPIaID4rb+SeaXWuO0yB892zSuUl8y19C7LzHPRwd3HbDTaIa9fqd+f7u0D/p2Zvcf7DVOQ93eojHh8YwlOXrjmdmJ+iJuUrK4v3zw1AmmryHPIgxrrqHQIMnXX6p1H9R3eO9ag7bvwmy6pFRWf6RUoZCP5WfJFeQVbSYnwLDUtvF3E4mTD9Ttp1WNRipfM1fASvuhNeNkYy+dMLtCQf6xAoH0INFqpCZGMLmz36fU8pX0lr+KviOqcLWs6mddBqIaeJEVyWSK27hKoysxgxLwxm1wjysfkCM1GEKi8iLx8RlI2WbZTJ6Z2ItK1SztmfXpPzWZI/6iWgxDfN8A0tage/ZXG1ZHffbPXFNLWoUCouV7MdxXZfbv4TUQcKy1hjXIhzQYmRfRg0y7cMA5Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 07, 2025 at 10:27:10AM +0100, Vlastimil Babka wrote: >On 2/5/25 02:21, Deepak Gupta wrote: >> VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack > >I see that arm GCS uses VM_HIGH_ARCH_6. Stale commit message. I thought I had fixed it. Sorry about that, will fix it. > >> VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow > >And RISC-V doesn't define it at all, not even in this patchset, or did I >miss it somewhere? > >> stack). In case architecture doesn't implement shadow stack, it's VM_NONE >> Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma >> or not. > >This looks like an unfinished sentence. As if it was to continue with "... >will allow us to ..." what? > >I'm not against a helper but this changelog is rather confusing and also >code in arch/x86 and arch/arm64 isn't converted to the helper but testing >VM_SHADOW_STACK still. Yes I didn't pay attention during rebase, will update the commit message. > >> Signed-off-by: Deepak Gupta >> Reviewed-by: Mark Brown >> --- >> mm/gup.c | 2 +- >> mm/mmap.c | 2 +- >> mm/vma.h | 10 +++++++--- >> 3 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index 3883b307780e..8c64f3ff34ab 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -1291,7 +1291,7 @@ static int check_vma_flags(struct vm_area_struct *vma, unsigned long gup_flags) >> !writable_file_mapping_allowed(vma, gup_flags)) >> return -EFAULT; >> >> - if (!(vm_flags & VM_WRITE) || (vm_flags & VM_SHADOW_STACK)) { >> + if (!(vm_flags & VM_WRITE) || is_shadow_stack_vma(vm_flags)) { >> if (!(gup_flags & FOLL_FORCE)) >> return -EFAULT; >> /* >> diff --git a/mm/mmap.c b/mm/mmap.c >> index cda01071c7b1..7b6be4eec35d 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -648,7 +648,7 @@ SYSCALL_DEFINE1(old_mmap, struct mmap_arg_struct __user *, arg) >> */ >> static inline unsigned long stack_guard_placement(vm_flags_t vm_flags) >> { >> - if (vm_flags & VM_SHADOW_STACK) >> + if (is_shadow_stack_vma(vm_flags)) >> return PAGE_SIZE; >> >> return 0; >> diff --git a/mm/vma.h b/mm/vma.h >> index a2e8710b8c47..47482a25f5c3 100644 >> --- a/mm/vma.h >> +++ b/mm/vma.h >> @@ -278,7 +278,7 @@ static inline struct vm_area_struct *vma_prev_limit(struct vma_iterator *vmi, >> } >> >> /* >> - * These three helpers classifies VMAs for virtual memory accounting. >> + * These four helpers classifies VMAs for virtual memory accounting. >> */ >> >> /* >> @@ -289,6 +289,11 @@ static inline bool is_exec_mapping(vm_flags_t flags) >> return (flags & (VM_EXEC | VM_WRITE | VM_STACK)) == VM_EXEC; >> } >> >> +static inline bool is_shadow_stack_vma(vm_flags_t vm_flags) >> +{ >> + return !!(vm_flags & VM_SHADOW_STACK); >> +} >> + >> /* >> * Stack area (including shadow stacks) >> * >> @@ -297,7 +302,7 @@ static inline bool is_exec_mapping(vm_flags_t flags) >> */ >> static inline bool is_stack_mapping(vm_flags_t flags) >> { >> - return ((flags & VM_STACK) == VM_STACK) || (flags & VM_SHADOW_STACK); >> + return ((flags & VM_STACK) == VM_STACK) || is_shadow_stack_vma(flags); >> } >> >> /* >> @@ -308,7 +313,6 @@ static inline bool is_data_mapping(vm_flags_t flags) >> return (flags & (VM_WRITE | VM_SHARED | VM_STACK)) == VM_WRITE; >> } >> >> - >> static inline void vma_iter_config(struct vma_iterator *vmi, >> unsigned long index, unsigned long last) >> { >> >