From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF32C0219E for ; Fri, 7 Feb 2025 22:30:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2882280004; Fri, 7 Feb 2025 17:30:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD8D9280001; Fri, 7 Feb 2025 17:30:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9FD1280004; Fri, 7 Feb 2025 17:30:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ADAF7280001 for ; Fri, 7 Feb 2025 17:30:01 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2EA95160C83 for ; Fri, 7 Feb 2025 22:30:01 +0000 (UTC) X-FDA: 83094592602.10.B168696 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 2B98C40007 for ; Fri, 7 Feb 2025 22:29:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TliR2Ibm; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738967399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iwyiGppbNocaIaOIGmwIgHsJ5j+0ZIA7Ss/btyu1daA=; b=SDuU8quv7mA7PSWbWQ3WoMbMJ4VdySwVR1stObcySboeUkzIsYoN1irYLdeaGtYXOuwoJ9 oJ1AiwPTCtOHIFBAaAD9ZWH5Oef7yKZWOnqc8fWtWxoBQZIWH58Ugbn9Vg/kd+UgOFXG+M pCxkeS9rjB/uiMEk2LZFf4r439hvEvw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TliR2Ibm; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738967399; a=rsa-sha256; cv=none; b=srXUmFtEqvDX8KmYFtpos5FGu1/V0w4lGUR1j8tJVf5kFH6OiOgkeP5o3F5d5esyihbJqo TV8q4zJ19KpYtc4lu7w24j+pHOTkd7pe390hIF9PMNepEp4KEy9FWE9zE7QMPPL+bHc/f2 d5VaMPYkLC4iXEPSP36q8BZPIZATk8M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iwyiGppbNocaIaOIGmwIgHsJ5j+0ZIA7Ss/btyu1daA=; b=TliR2IbmHPe+my3kZwyOEfgQyf GC+ekNottY+PZcaFE99Lmx93J+PvUdFIUlwbYT+kn7nUg5+H4QFzKYBz4btuUvtMeacr/sT60HT2g fncT0uFdZYFf0r+5GFQnCayQ8jyURcbo6znfGVljWO/bzdVKUN4BUS59ueuBwpSh94k8ZyK9sTRIa A7/KrfD6rXOWD1uY0F/arTQWorjSo0xzzmfnO/akia3FnZzoGvR7lyBgxM5XpxtBXTiD9Bs+TmQdv lWEX75AddXRjoAh2AJZd3Oq4W+2tfWMLQnJIg0g2bxDbrqnZ603zIbNMcYmOuQ70RWK5b6/denmxs bd6InkoA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tgWrE-00000008m1X-29MR; Fri, 07 Feb 2025 22:29:56 +0000 Date: Fri, 7 Feb 2025 22:29:56 +0000 From: Matthew Wilcox To: Vlastimil Babka Cc: Josef Bacik , Miklos Szeredi , Christian Heusel , Miklos Szeredi , regressions@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Joanne Koong , linux-mm , Mantas =?utf-8?Q?Mikul=C4=97nas?= Subject: Re: [REGRESSION][BISECTED] Crash with Bad page state for FUSE/Flatpak related applications since v6.13 Message-ID: References: <2f681f48-00f5-4e09-8431-2b3dbfaa881e@heusel.eu> <9cd88643-daa8-4379-be0a-bd31de277658@suse.cz> <20250207172917.GA2072771@perftesting> <8f7333f2-1ba9-4df4-bc54-44fd768b3d5b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f7333f2-1ba9-4df4-bc54-44fd768b3d5b@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2B98C40007 X-Stat-Signature: np4a4arxuzhobbyhkx4bcyxke8wftarj X-HE-Tag: 1738967398-426402 X-HE-Meta: U2FsdGVkX19lBHXiMLvFwkyXn+uTfjP6Gf8yBrh95u6Un8vJHehLQdi34tM2ZkFyOBMXoVWLRE9niWEiHQBYJsYOlCORZFFHIDVCNvcamjkH6BaPlHM/y8/g2b2SJsnQxNzHQiRXEzX1ywbFzuSH9qdJD9b0L2V5+CbCN9D8lcXYPRt5aykGa/RV7hloCVG/RBvVNSdmuDsB/s/m9KGap4WU2eys4xoTVFCtBjA60PsD+PHxUXDof8SkK2y/u/V5elT/1/v2MCb19V58ivyDKlUMQHsf1C8auYP+TYuwXsf9mSqFzm+KrrHqxeaFBR21Sz/2iZnWN60CMNSeRckMp64RwJJEvP9kvR2zGyaYHXw7yymnzT5k0P5nrFJCP9T8D92OKdnkLi9KqKhr7Ca4O1rUdhYrIM7HghPzGy7PtmpVn5zvkorqCVB8GPm1lwAxiSoq9y6eaoNBnKdUeGqBZhCpWl+mpWzxwzk/l6lDwLhwH0UiXW50mqbpn2eo4XWrIJ3XT7jXnQ2XAPa3of0NlepSEZCe50Hr1ghQz/iPJ3xAcMoqMOzZtDkjOmNJG8O8e8dtpzcUpTsntfYLHzEiyjbSf1Ih2s2C1Dov2wK1JR+N1AT8XUZhjOV8RDHTsIXywQkB5uqJ4kQr353ln8231c17b4KEWqZZIzncJij5aLOajo5NCrhirWoIy3ysKAMm70E6zL5Tv+cloDnbMruzC1z9662iBRQFOW6qZuYj7/zysUmXHTGk20X+mj7JIrRdM/NQFx5muBf6echEr4ZE6sDMp3W3QH7pGVAqHxIIzGz8OJlA7jDMKvccpxozbmH3O2nnbP+Ee8uXcPRay481H0Z4l/gqdHjzl3r/Gf+FacGM4RhVeHllqFt+epGzlrLYUXnp8il2di9iheEF0RtPmkQ/slsR+V45sbXJ/TYMZ7ARPZwd0z3AVlFHWmDqqqXe2Fe8GCkQ0v19Lue/jC5 guforuu8 CYqn/pofKWXmneGbOBKvlPbYawrXk7zpMXaKRY0Lg3FZg3o4YDcVLEmA6NclSrgz4b14d+Cz6QCvakFbdjXPESkeklQtx9q1Xzod+FScy9vMacK+HfVZfPbmvlgRpUpA6dMPX72OE5BE1Gs4PjWnigcDxwSgEwHgAlL5PXZSUpxscY0oIG2du/fXUGLcHRnZzOytsYCsGAoPCCOBKmW4NuRfyQSa9HQTCDJub5AUQZmzAgeDX6VyX9YFxNCimI7kjgDQ1zzKQDPG8fk4IDDzk88msuktuDCwI5//w X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 07, 2025 at 07:39:02PM +0100, Vlastimil Babka wrote: > On 2/7/25 18:29, Josef Bacik wrote: > > On Fri, Feb 07, 2025 at 05:49:34PM +0100, Vlastimil Babka wrote: > >> On 2/7/25 10:34, Miklos Szeredi wrote: > >> > [Adding Joanne, Willy and linux-mm]. > >> > > >> > > >> > On Thu, 6 Feb 2025 at 11:54, Christian Heusel wrote: > >> >> > >> >> Hello everyone, > >> >> > >> >> we have recently received [a report][0] on the Arch Linux Gitlab about > >> >> multiple users having system crashes when using Flatpak programs and > >> >> related FUSE errors in their dmesg logs. > >> >> > >> >> We have subsequently bisected the issue within the mainline kernel tree > >> >> to the following commit: > >> >> > >> >> 3eab9d7bc2f4 ("fuse: convert readahead to use folios") > >> > >> I see that commit removes folio_put() from fuse_readpages_end(). Also it now > >> uses readahead_folio() in fuse_readahead() which does folio_put(). So that's > >> suspicious to me. It might be storing pointers to pages to ap->pages without > >> pinning them with a refcount. you don't need to pin them with a refcount. the folio is locked, so the page cache has a refcount until you unlock it (possibly by calling folio_end_read()).