From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13CD3C021A4 for ; Sat, 15 Feb 2025 02:09:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D3816B0088; Fri, 14 Feb 2025 21:09:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 683706B0089; Fri, 14 Feb 2025 21:09:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54B1B280001; Fri, 14 Feb 2025 21:09:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36CBC6B0088 for ; Fri, 14 Feb 2025 21:09:11 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B4441A10AE for ; Sat, 15 Feb 2025 02:09:10 +0000 (UTC) X-FDA: 83120546460.11.CA51ACB Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf13.hostedemail.com (Postfix) with ESMTP id A61EF2000A for ; Sat, 15 Feb 2025 02:09:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=W7aDMuB1; spf=pass (imf13.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739585349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xo2P5E0/M5KD94XnehsexSIOx+TwWuT6jmlBnTmKr1U=; b=T4Wy6vIBVJf0bN8spMXCp/dKXpKx1N3RuQBFBpi/CaukkI1fr4uZUdXRoMr5NzoWYKbTjR JoEK0cnVm/1zmMocwWq1hl9rEo2P92077JCp7DzXW+pvyKpHW0Dbnszzn6lIdnViYVX+sT kABlCJ+D5lk8EJQzfbu59oNBbaPP1lg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=W7aDMuB1; spf=pass (imf13.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739585349; a=rsa-sha256; cv=none; b=KW1jdKDA6r1mOO3ofZUVm3Ne+xaNszpYt13/ByqoF5A7/mCzaRx4f5Ngm8TBt4oaDzl1bw AuESjpV5Ev/zZCy3/eZWNca7LPtFwKHhcndDagSiqJrEHD2tehVyBcM+lVjR3B1//VQaG+ e//oPIfuM67+B3d2kEG2aqS2Ja3mLD4= Date: Sat, 15 Feb 2025 02:08:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739585346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xo2P5E0/M5KD94XnehsexSIOx+TwWuT6jmlBnTmKr1U=; b=W7aDMuB1A2dThwnDfWQmN/GuOK5BptsezXaBoE3Sths+AlpeoMgxTO8F/FVWJ5jKkCGS9D nifQjL5HdpIVWVXzjPBRSHuuxibZgglj2rNZQTZ1ISRJpDQkBygg3/DbVgsClFgnTiDJVI HtUpw2eZphXN1fG7hYfobPnWAi9sWgY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Rik van Riel Cc: Dave Hansen , Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes Message-ID: References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-7-riel@surriel.com> <20250214194013.GA2198@noisy.programming.kicks-ass.net> <3e26626aa1c01aaa5d1e7b42d3ffbd632c3264fb.camel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3e26626aa1c01aaa5d1e7b42d3ffbd632c3264fb.camel@surriel.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A61EF2000A X-Stat-Signature: 14h86ax49m1ma8m4xbx8np7fixtqoa3z X-HE-Tag: 1739585348-947318 X-HE-Meta: U2FsdGVkX19IkxNYJIWiDZhx7q1jvTOtozFtWwF3KnYbVuK0Z2iAuZqQCcPc26eCC05glqMyPEn1exzYGfyFhd30Zdo20KWtRbIQM+HRHT4Rj8pHEAw2q3F2w1zcRbljSgmvQ5vA1GWzayIZaabLrwEfrQtV6X3nHFBfg7zFdriw7Kas/65NH41HNkLXiYzjRR4BbRuwzXOFzjaDcbYizL/h1XCGOULTK95HjIhKTHEqsPWsaIDpkBUN4SFf4Vis7BhMohRaTS1cHDGFGKwgFW+7V2LVd33vFz/OcFe6i/4E8NI3e3HHeK8ul94m++6mhmI6pd9MEsHzpAXLGAWdxz2yEGA4OkwYQTVOOsj61S09wSHxuOzdnAN65hvhG/xS+DKiK6xZw/Ad+kE/ZDozS5V0g0Gn/I+g9r9KHQGJrMLAIot4IX9/9+whirhJRYDur7ZZbcv9Q3aiMctyJrIJzcuYtg9ASb2mplBToraYDnHk6nEO6MhQaGaNhGUqH9TtzBJEaUjkn2lGi7a9eF+/2kPz2mc6U2hdPbmmr1Jx8o+Be4q2ZXmdyxBPPzLv0NVSGNOmYS7iEofLK4jEgICHeRk/Bxsom28Zj0ITNQxvFCxB/2r2zjUivgccw9QyuFHnppkAbDy3Vg6P/bH9uGMMTpeWoI+1clQa/uOEZZ0amnZtlTH7fquoRkgnyQpBgs4nEz7TKObPeeBdyg5dxHdDYgpx7CnKyc/5VbdvkSjqqiKnh4itBt6oaiNebtEmxSdceAwjYrue1FgyPpOEdR/sGSgMghfcb93t27GThXNyv9pKqo3MXsfy+4aSh0uDYN5LsHUvQnxGeRRMKdH+QGUKGcVtpMcBwa/aPb1OJ6SZRB7PK1CwadG9bto6r0SJfyXnZvYiTbb6LPLs75ZRevz4pKo4/GPJWpZuudLjs3VyzYBDBTT+ODZ5thNStmAh4mdAEGfaebPIGY5I5Tfkl9z JcSqI4Bj pKT33bhHBzy8fgsxGfE2yBXamxCe5FZM6sGafTIRs56XHWeagU8oCoQnq7ioR77we0DKCLVWDJgdU9JAgfw+wZZ3a3rVNj01RV7eIcWGEqHLR+L5hEX/Ab8HmqlgWuRRNZ/MwUzZggFueyotrbbduFl646ZJuC3FfW4Ox1qc43umuP/5IpD1KSICTHl/MVuBIRg1bHxFf73puPT0jErj4P15eGKz819NMqTIvCkfNm+TS3779eWl9w084Eg5eaeie3otJ7+nFJDwgCSqcCYO4hJyUPRyuV2JOiOiAwYRoQF/1AQv50PhezanDOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 14, 2025 at 08:25:51PM -0500, Rik van Riel wrote: > On Fri, 2025-02-14 at 11:55 -0800, Dave Hansen wrote: > > > > Fair enough. If we don't have a better name, we can at least do: > > > > if (new_bad_name()) { > > new_thing(); > > } else { > > old_thing(); > > } > > > > My real heartburn is with: > > > > if (new_bad_name()) { > > new_thing(); > > } else if (need_thing_1()) { > > old_thing1(); > > } else { > > old_thing2(); > > } > > > > Where new and old are logically squished together. > > > Do we want to group this code by history, or > by function? > > I would argue that new_thing() and old_thing1() > are closer to each other functionally (they both > do remote TLB invalidation) than they are to  > old_thing2(), which does local-only invalidation. > > I can organize the code however people want, > but I would like a second opinion on this idea :) IIUC the discussion is about: if (broadcast_kernel_range_flush(info)) ; /* Fall through. */ else if (info->end == TLB_FLUSH_ALL) on_each_cpu(do_flush_tlb_all, NULL, 1); else on_each_cpu(do_kernel_range_flush, info, 1); In this case I agree with Dave. old_thing1() and old_thing2() are both sending IPIs, the difference is that old_thing1() is doing a full flush while old_thing2() is doing a range flush. Not sure why you mentioned that old_thing2() does local invalidation. broadcast_kernel_range_flush() also decides between full and range flushes internally. So the main difference between 'new' and 'old' here is using the broadcast flush vs the IPI flush. So I think what Dave wants (and I agree) is: if (!broadcast_kernel_range_flush(info)) ipi_kernel_range_flush(info) Where ipi_kernel_range_flush() contains old_thing1() and oldthing2(). > -- > All Rights Reversed. >