From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F966C02192 for ; Fri, 7 Feb 2025 06:47:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9499F6B007B; Fri, 7 Feb 2025 01:47:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F84B6B0082; Fri, 7 Feb 2025 01:47:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BFD46B0083; Fri, 7 Feb 2025 01:47:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5F9A86B007B for ; Fri, 7 Feb 2025 01:47:13 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C1FE11A1677 for ; Fri, 7 Feb 2025 06:47:12 +0000 (UTC) X-FDA: 83092216704.16.31A3DB0 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf29.hostedemail.com (Postfix) with ESMTP id EE19B120010 for ; Fri, 7 Feb 2025 06:47:10 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WLzm2ADl; spf=pass (imf29.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738910831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aaqm0+WcUbtSSV6iiLRU9EnxIGnO61h8+rTTV2ydAn8=; b=AtlcT4BXZkONnPsupM9aQ3AUeXOjpT+CB17bJ96Be8zgF2tGmgJEgCrUQK2FhWuUG/Bjgc kl6pgKx3d1Te9b2L42V28RU81IvOg4x7Qs5nzKksjQY0ARYuy/veWFRri9L8iTFdZYWxfj gRCu0R0qTSy/3y4Xef9f/PQfIKob/V8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WLzm2ADl; spf=pass (imf29.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738910831; a=rsa-sha256; cv=none; b=MyrcxCKN6eVqtXJ8I02QBsXoUE+hGopqvOxSzjryr0/VT3zsqZlU+OnD49uRXy53TGtJf4 xzIrawYZUQGWuixkNHlvoMeoc4OhnkhsQHKlD5qT7TwMZKpijm9YnZGzFlVtiPn/uqGZp6 isfJQqv1VMtWUnpNHtJfDl0k8NVTNmY= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21f40deb941so27037385ad.2 for ; Thu, 06 Feb 2025 22:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738910830; x=1739515630; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aaqm0+WcUbtSSV6iiLRU9EnxIGnO61h8+rTTV2ydAn8=; b=WLzm2ADl1rhCpxPSGVBIkfa2A8LggT1RilAFbahH3W5jPebXiouKEv+ZRj7ZghG3rQ ssI/8qqa/adeFI5p/QffZnqcwcqzJPlxgnudb9PaFKNXZ90ARoLBfhIT06cFYkda1XDP X8YP2qGl+7mSRo2A6oDbawoxf7mLfzdS1z5A8Q6RiF8J8Jmw3sNBFVWL9HCZH9axU+17 GglsAQkXfAxSIt9j5Q57cRK9GracBG8dedv73m6vHc6zJzTuagH6TZQfRYRa2wiLmqtI SHWFsKDOz0BYhUQQYgH+CnfLNkhaB91GMCk8EJZlOZmvLbNJbUa48+2+ivxorc7FfWeW L0NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738910830; x=1739515630; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aaqm0+WcUbtSSV6iiLRU9EnxIGnO61h8+rTTV2ydAn8=; b=phDK1xk2nWfDQTKI+dVWj10sbBjA5L/NWcsU3sPwvGwTng23OooPKbnFcLAe/Fsvom 1+M7unN8WTIKPQGYZI53/hdoN5sF7+TM2fiOTsIWGpFyLVlfmYcSq4Q3NSU7medfvLix xDF8CmTl/SywF6yoeDkg5xNsUZxp/1lKYtu2G4GgGXjczYyObxuUhvnhDSW6LvyOolH7 gI1ZYhn4wuS/77Yltm/Mk0SZLVSik5z0kk9MYZu4peNijpt7V4cpKrmX57C+ZyUJOrov gugr9NwY7B5fc1THSt9/Z3acf8YIaMgUauGKWrczJO1qWv/H8kXS5wy1RMJWTguBT57o bFQg== X-Forwarded-Encrypted: i=1; AJvYcCXjQPySpTS+xrPphxhdTBfZ6t+w9EdexcNglTVsJPsVC9CRUv0CHn8sb5/q5XR7E/g8C7cjGdtNGw==@kvack.org X-Gm-Message-State: AOJu0YzyA7P23zmIJpPzWOi7jjCnUPTPa39uoUAcLEDFOMemOJcXEUGH w6HsW2v1abR2tCSYsyVrTL+2SFAZu6Qay71mjccgQ68tYbmt4SNjelIc4A== X-Gm-Gg: ASbGnctlFwIotGQ0+W0omSDcfoE4HsjUj9BTN4ZhmJvVHKrINLLqP6pshgEb0aBcayz u/qWWYIibIVUlhE7473+at6M40u39Mi9Ybm6iOYebCIGfSmEXz4Y7/FmfzrBrtkJYm7S+XfLjDF 9DzvEpuYNXgipn9+HUbbvqgxaOwyx/t3c3NZCBNn/wZhUOf4uqfNhkRki8qhD9a28oW1aIIiVZl CIt2/bVX5BPINY9IstkYJU3uMfYvVTI3YDRNcFH0U0OCvS2g//uq/8TsdcYAgkuBQt997cZ9AR1 6OhHiaBZXbTR2kNzi0EvmlaeUH1xa1f+txV2A1kQbo4eROsEGZw= X-Google-Smtp-Source: AGHT+IGPGbQapsZ2i5BXeJiIzl3WQzLR76hcGtjOFymt7TFJZ3ZcGM8HPzw8As7XUfkOKBuufcVw+w== X-Received: by 2002:a17:903:240c:b0:21f:454:953c with SMTP id d9443c01a7336-21f4e800da4mr33884255ad.52.1738910829652; Thu, 06 Feb 2025 22:47:09 -0800 (PST) Received: from MacBook-Air-5.local ([2001:2d8:6903:f392:3d3f:70b9:7f75:3b50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3689aa2esm23098305ad.217.2025.02.06.22.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 22:47:08 -0800 (PST) Date: Fri, 7 Feb 2025 15:47:02 +0900 From: "Harry (Hyeonggon) Yoo" <42.hyeyoo@gmail.com> To: Liu Ye Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mempool: Use kmalloc_array_node to replace kmalloc_array Message-ID: References: <20250207055213.141890-1-liuye@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250207055213.141890-1-liuye@kylinos.cn> X-Rspamd-Queue-Id: EE19B120010 X-Stat-Signature: oi311whq47iz54ytaz7a6xe1h8db57fe X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1738910830-656548 X-HE-Meta: U2FsdGVkX1/4JBef7w5FSW9XueFscbv9oDpF8x21/xDyplGaX0bMxpRo6/9PKvKPU4Prx7iXiKuXmPu7UjXIK9Vdruy7v47cjHMBhh8pouahZPBgz/LDBPn5F+o73PRwORVCv7u1ag8XQ5vXrV4bSXZDg76XqyW5dAzZNqNFFmJ6nPyJjJstM5BMSj3Obxdm3BLpGUe6y06h/Cjt3sCzfegVZTJzAXkfCpBMYb3ZHGdcOcv0UG4yUo2x23gquKzD6PFqRdeDlDjWXjlqC+xyj/hTVnPoilKHjj13Ifh5cbKmAm6faNKi/Bwj/MUgZXxL5TIUycegG6t9dSg9hgvP6dXm4EyM7K0/cORFB1bNdqKNpfCpQVYupM4Nb9HIdCRWaXdHCysJ59AV3OGuvDhhNvDsRzUushHcZklOZxFkb0IFAk35rH+8yMkBURLaaAdkQpP7s4K1M+ABrGm7vrspZTE/gd1U1hifHWsmG68+lU5uImPx4WlPJjWAqwQPhuZDLlTJG3rnNcf1IZut47d26DYa91pHrihyg0pcc3cQByP7CTsuK/H1TUjXqeEhrJiWLM0OkqpF3F2sy3l0Fgjy9ZkZIWa87LkdXk6gdeaCu+Wwy+jA6hxBzTShZ+oGCrUb/zWIdM0BPN3M7SabS4GbHyyHmVdQQ0YmeKgcj1aMoQG4pL1KKjMsQpOkbcDTHuK69WoNMqETUKX9wYPX3wjmiS2KkeP95G0foqSQSPd2pLoBtpUiPFMwkd2cfI6AoxdD/f8Lz30IzzdyXtwAldLUwZPazyuCb6ChmEne4h95ADFMJXOVSuMLpzgWxw/J7qzcIymWz/C8JjjOrI7FeXV0JkXTO1DnfMhoGNQbYkx1k4e/z4Pg9y6vTGDYDDKuVrFGwf+A71VWRDTncJ2IYpc4LtuPOfrzlyNfm3QamPMjQCBr3heOzbjsmRMOccxsZ6h1kdAFDCLRuQA7O8qC0tj VLnUrYAF OEbI4oOpshKP+yMoecVn79Ow79p4uNhCA3IoKPcDlSYb0ijh3dU1vQpUg44A2QVuA8IjXsjPRCCRtJjIK9tUIsa67dnCnhynA/alEpDlWkSrDkYz/t4FSOnIPRYs8QrFTf8kGHnTBU71jO4sjkSDXgzLG6GoEp3zSzUUgWS8Fb0LiaUdBHWLHxl5H3pdn4CjJWFogkE8MSuTSabkmbPOpAff17UxllJVsf+ljshN/ArSnfROmpZsMpiUjWMI9ipuNgfoNdNkE4gmirykOqXXNujybqOh6R3BAl4IgsD7M1M8rQVyfzoY8O/S6568Id32X9xHSUqfuidRRwj3coce/jqIJ1cwNCm0i/IXaY+9XMsJGEmhN8I20/Bxl1ZVf18DVS9tb6JF2kf+kRyocTYjKTAXdoCdMQeFzBi6g9nttGYdRPviUs3dKGJkd6GOXe3x8PjCI5pM3jKCHjEH3t7vr2mpi2JlYIHP4CytTUF6P5w/AQxh4Km+CC2I2aE1f6pA6Ok6XSZJZbiimpvs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000324, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 07, 2025 at 01:52:13PM +0800, Liu Ye wrote: > The kmalloc_array call could be replaced with kmalloc_array_node > to allocate memory on a specific NUMA node. Why is it useful to replace kmalloc_array() with kmalloc_array_node() in the code? > Signed-off-by: Liu Ye > --- > mm/mempool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mempool.c b/mm/mempool.c > index 3223337135d0..51eabcc87177 100644 > --- a/mm/mempool.c > +++ b/mm/mempool.c > @@ -328,8 +328,8 @@ int mempool_resize(mempool_t *pool, int new_min_nr) > spin_unlock_irqrestore(&pool->lock, flags); > > /* Grow the pool */ > - new_elements = kmalloc_array(new_min_nr, sizeof(*new_elements), > - GFP_KERNEL); > + new_elements = kmalloc_array_node(new_min_nr, sizeof(*new_elements), > + GFP_KERNEL, NUMA_NO_NODE); What do you mean by 'allocate memory on a specific NUMA node' when you pass NUMA_NO_NODE? It's essentially the same as what kmalloc_array() does. -- Harry