From: "Jörn Engel" <joern@purestorage.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Uday Shankar <ushankar@purestorage.com>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [bug report?] unintuitive behavior when mapping over hugepage-backed PROT_NONE regions
Date: Thu, 6 Feb 2025 10:11:30 -0800 [thread overview]
Message-ID: <Z6T7UoYcBA8WzDwF@cork> (raw)
In-Reply-To: <Z6R6USWFfyjWljth@localhost.localdomain>
On Thu, Feb 06, 2025 at 10:01:05AM +0100, Oscar Salvador wrote:
>
> That is because the above happens after __mmap_prepare(), which is
> responsible of unmapping any overlapping areas, is executed.
> I guess this is done this way because rolling back at this point would be
> quite tricky.
The big question (to me at least) is whether the current behavior is
correct or not. I cannot find any documentation to that end, so maybe
this is a new question we have to answer for the first time. So:
In case of failure, should munmap() change the process address space?
As a user I would like the answer to be "no". Partially because I was
personally surprised to see a change and surprises often result in bugs.
Partially because the specific change isn't even well-defined. The size
of the unmapped region depends on the kernel configuration, you might
unmap a 2M-aligned chunk or a 1G-aligned chunk.
Are there contrary opinions out there? Would it ever be useful to have
a failed mmap or munmap make changes to the process address space?
Jörn
--
I don't care what anything was designed to do,
I care about what it can do.
-- Gene Kranz
next prev parent reply other threads:[~2025-02-06 18:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 6:18 Uday Shankar
2025-02-06 9:01 ` Oscar Salvador
2025-02-06 18:11 ` Jörn Engel [this message]
2025-02-06 18:54 ` Oscar Salvador
2025-02-07 10:29 ` Lorenzo Stoakes
2025-02-07 10:49 ` Vlastimil Babka
2025-02-07 12:33 ` Lorenzo Stoakes
2025-02-06 19:44 ` Uday Shankar
2025-02-07 13:12 ` Lorenzo Stoakes
2025-02-07 19:35 ` Jörn Engel
2025-02-08 16:02 ` Lorenzo Stoakes
2025-02-08 17:37 ` Jörn Engel
2025-02-08 17:40 ` Lorenzo Stoakes
2025-02-08 17:53 ` Jörn Engel
2025-02-08 18:00 ` Lorenzo Stoakes
2025-02-08 21:16 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6T7UoYcBA8WzDwF@cork \
--to=joern@purestorage.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox