From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118B7C02192 for ; Wed, 5 Feb 2025 22:03:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6443A280008; Wed, 5 Feb 2025 17:03:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CCBA280006; Wed, 5 Feb 2025 17:03:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46D88280008; Wed, 5 Feb 2025 17:03:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 239EA280006 for ; Wed, 5 Feb 2025 17:03:19 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CC6F2C0CE7 for ; Wed, 5 Feb 2025 22:03:18 +0000 (UTC) X-FDA: 83087267676.30.19FA6DD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 8967DC000E for ; Wed, 5 Feb 2025 22:03:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="GvIpSU9/"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738792997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZKg4hPFtzZMgBZRAUmKo58MUV2/XOMJypO5dCzp10D4=; b=lDQ/GvsaVNfTSqQLQo/Pt2lscd+mpQdP8MtbQS5tYm9FVgHZ8/bChikLSMUdqCmBenLWfZ HK3ck/qPRg+lmn0jqm8mrrihIJK0bOfoXq5CngvFT7rbQLqlUdgH5bU7GcaDosV79gSaj1 96/2vtBw3t4GoOQI/BUqkuVyz0nJnXM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="GvIpSU9/"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738792997; a=rsa-sha256; cv=none; b=8It7mH/WPOD2urvt6ju1euM2jrVHvd26oQ7JoIgwOdBSkaPUwlXWIHS/OB2+hi97fFyVbX MOFyRj4CAKjpwZZe8uQhEXM5xhwgYKd8oePgBvqHZUqpEJMnNKStB0rdsSdF/E4CLsOgSZ mwmIMYDJEOubR4eINpXB3fOtn4TLrkI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZKg4hPFtzZMgBZRAUmKo58MUV2/XOMJypO5dCzp10D4=; b=GvIpSU9/+Miz3nHeqZF/S/6qUu U0klbnDfNsHAUsoN4/TwJybYRzHUMHgTWh3qjS/JgaLJPOJMYToid5s5M7AEU7nzN0OSwgt+cpRS9 wh0fMEhHWd1KO1Ti5LTUsA1IOHVzQhjTO759tN7yOqcbwGW01dq4JKLaYPZS/LjZX1ZuHNNJoLt3v bUFj1ZwIUa1aWPNsOmZ5YkNcgO8b4V1uih+NWjjRfOV8sUQnGcnlNRVaSMmDA4GiB8VYX7Lue///Y qCsya8jkc0UOH5xNxAgTOpx0JeywFgxMUr0KEJwBAhphY9ntVPas0Urv47zLLqk/IOvF9VgdLo0lR EP4EclSA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tfnU9-000000054RU-2K3m; Wed, 05 Feb 2025 22:03:05 +0000 Date: Wed, 5 Feb 2025 22:03:05 +0000 From: Matthew Wilcox To: Hannes Reinecke Cc: Luis Chamberlain , dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 1/8] fs/buffer: simplify block_read_full_folio() with bh_offset() Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-2-mcgrof@kernel.org> <1b211dd3-a45d-4a2e-aa2a-e0d3e302d4ca@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b211dd3-a45d-4a2e-aa2a-e0d3e302d4ca@suse.de> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8967DC000E X-Stat-Signature: e8tp7fsam8brw3nfoib4ka5txhw6ssjw X-Rspam-User: X-HE-Tag: 1738792996-369753 X-HE-Meta: U2FsdGVkX1/t3guNme57w4I3K3wl3kLFXU1/z3eMk/Pe89CE7DcOhfP41Ni1aGZvXh3BhIMU3AdE4zfP0rPsx/fKQ0Yf/wH2XjIe/B8WTzptoHyT+CwVqrvXQ9jG1zaLKh9BGKA3nSXZKxrXzbY5D0nOQlJQyklfAi4aC3NH5iQ4ZEDfUiUEq5S7GpPG4k7rQvIv1D/jb0I5Tl1cu4q5xDgU4fEVzY2rfIjEybMSL97Un4FvoPoGX/GTn6du1dOxrccCjQHkJCMHAbw125BhH7mCmbq3TK52DgHP2cUnc5hJub1CAHjm46RhDIWMlMp25uvOHckAsAPR61NDKFUMI7g4pHy2KzILv2ta+AIrN0MKMQLdOcvdVSAKjpXS7fwd4KaDYNubJdgwiRJ2GZQLusE5Vpx26n1ATdM6cEKNOknaWxNkVAKNt/XxIsqMMT+IA8RbT5qfu7KeSkLHrsNVly96QxYAXucyNMf6uCpyjjFr+xlff244+yeCkiQBPi4t97PYvU9cYKFTY7WUixDsDG3bbIkTP4M0+DQ4IiNBpTe2E2YY1P5P7SD5weQyHf+L/vm2T8nhIIvp2pE/kt83iykIXNnfXlAMO8rNNHQqx09x+67aGWwqMkjUtjNT8OYqfeP2Wb+HdrGH+Qz5YV4gOos4M7MY2w5LymtsKv+Y4HvQCaGwNWN+l0wa/88RjfUOfsYalto3WHyGlhMa9k2FTrkN5MPaNU9k/5zT5n1PiXFcKMUf67r8FA8w7Y+fKtV8b9XLmiiv6gGsuBfzIDZ7xbRf0QtJ5iL4RBRkbtqUWO9DJZ6HP9XEHADapkPiOLCjPMT+G6AnBI/oLsBOC8MurdB7U5L1/y9vKv40GAm4Vw8ZgcK9Ey0Hhh63UXip4rztOgeguCFy5SQuJqN4XqkdGdmOw2lOizYlpMl9j3aXaM+m8Hwy91MzlxR2sX55k+3wvvfEkQ8njYQQN9guZxn Aiqyt9TV wlrE4xtgDOS3elXXGbdA6DWukdwj7SnXSOahUwXQPKj6jNVjLGc7eVlom3TP+h7Yz1GPfWzWQVLb8NOZGk/YPbqNxoG/awlH03jl6cvCide7S08sApAfa2qVPj9v8HbM/s5rQAU/IiwKNf7lHAPqDNcd5V5ZcFdSoNyqR5JkSDVmBivnALpgLHKnVKz5TmMdFkgWwlc0hPULhZvSejLDNAxKoTpmS5b8ER3H7eER6X9uzrlOY5ZL+tqzsz22r01YJ6DFzKUmfUIcJ1TjsK2ZnYPsasMUh5WLYlmxMr1ie+PrWWeHGvbllerMotZEwwHX96tc9E8yRbFbT7lNGVYo0QMs1mBHngiNLbNvW X-Bogosity: Ham, tests=bogofilter, spamicity=0.009485, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 05, 2025 at 05:18:20PM +0100, Hannes Reinecke wrote: > One wonders: shouldn't we use plugging here to make I/O more efficient? Should we plug at a higher level? Opposite question: What if getblk() needs to do a read (ie ext2 indirect block)?