From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C0AC02194 for ; Wed, 5 Feb 2025 09:40:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE52D6B0093; Wed, 5 Feb 2025 04:40:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C94EC280003; Wed, 5 Feb 2025 04:40:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0DFA6B0098; Wed, 5 Feb 2025 04:40:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8DADC6B0093 for ; Wed, 5 Feb 2025 04:40:18 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 06E051C7DFD for ; Wed, 5 Feb 2025 09:40:18 +0000 (UTC) X-FDA: 83085395316.23.CF2D0B3 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf20.hostedemail.com (Postfix) with ESMTP id 321AE1C0010 for ; Wed, 5 Feb 2025 09:40:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EMnJjhtt; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738748416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qjPw3Npe2yQ2lWhiZcLUlLMtJQlIVo767jAtj+2FQG0=; b=c8jgZdeJf34ZYHdcfYQQDGk3GljdG2chsdJ2xomTAk1nPzUbby+Qkensn8E5ceU8tu84cU i7bNLAYYSv8VL5sCrPs4ebnR8YzJ9B8EqN8j+LZH6vIMm3eCjWom9rOV9KP9GWXtsAqPvQ ik3YXg00xZYcUWs55G83879qC2kOj9M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738748416; a=rsa-sha256; cv=none; b=rAP0I/oVEBF2Hv7Mwou1HtprLKm9Q3Cy7F/CUJU8nEJXlq719Ti18ctXmjRBvjapXc+KaB E9rir2Yiox4H7HCbV6ToM4IlqcCB793jxWJ/XTWQgOluAUSE86tUUCWXFlu4RLe0L9ifwg zslY769XeH5GQLK1tFgBDfuAPOJjSU0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EMnJjhtt; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21f0b5d6c6eso9195205ad.0 for ; Wed, 05 Feb 2025 01:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738748415; x=1739353215; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qjPw3Npe2yQ2lWhiZcLUlLMtJQlIVo767jAtj+2FQG0=; b=EMnJjhttbc3xg+YwpcQZVeXTYfOOO0emGgNKaoqG3UZf1GmTQp6nJbimHopbnKO8Gm YIh7j1yaE625Oypw2UwG85ZPUXoFJUVAuf/Xhl24TA9qnVmxED3kESVIw+LsT6B7KeNz 50SEh/NySF6lVr8pjSN5TDUzH8uraFuAuG9QJBCTxGI21Hb0OnrmZKnL+jrososfpwga kRPWkzifg2CHbVbFiB6h/mADBadWp4Gm1Ig+1wRpVa3s//ZN3CrwTiZkHMCW0wUeh1Zp JBywH/J0PemWBMRwGXiR2i8ccMGpMVhNowtQa5AG9l2d6rjwnqPZ4lqBZzcR/rWLKaaI xYHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738748415; x=1739353215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qjPw3Npe2yQ2lWhiZcLUlLMtJQlIVo767jAtj+2FQG0=; b=E7PVxXU3tqwVTav4T+7vpDSfkZAtDfxX6YIlIAsfFXwYu8RJkkGdeM4frrc8+TL7+z WbufzcN7HR8G7EI3kFR3JXlqfOQIm423BAJOEjD5fFyUE2RV9+BkRk328kprFoQQ8Mf9 kq93ZRSY5HFIuZtTCoS4CmjtYFkZ6In1ZokdlhtdLzFsQJ8LHNv+fc6P/kSaIPE9tQcy KRalcziGgHV3axy+g5MVaVkDW9MY2z9amranEiubsz9EauaK7AateNgMykGEqZY0CE9j GYxxtOIzpTaeyrBoHcvpAUv3jJYbkopYtcsaMdcIAm/cCT1nwSzGUFPbQevdHSn+A9tb CyJA== X-Forwarded-Encrypted: i=1; AJvYcCVExQUisynIjtxtFw5znqvn3gFGjK/PUFPNHIBcVHdZsdJpZm5TJmmDnFds2RybIRZJt0X1mnjqfg==@kvack.org X-Gm-Message-State: AOJu0Yy1+Y1ask/ngwy9N1UF+5a7Cd/C+M1rx8xTQRlcDhvvDp0qSB2r kewoSwKHDF7NK4yTmg1AOphuV25bncVnn5DQRKANWoKA+SdaFw+0 X-Gm-Gg: ASbGncsKmiPRtAyB/rq2ZHQph1xToJswb5gdNj6fZY3z9pOCzEudncE5jflEPXuSETV Z3xgy/1Puwla5ccMtLI9ExljeXo3ksbBcQ2TkyHnMxSeO4e65lMcbz3ASTyqgezqFqErSv5QrnY Em9Lhh7KSiaR1AqKlV8C7dPJF4p4AaNYlAYTspKzqE4piXFT5sxQGmxU+0CQHFHDWMe7snpmmHv B7Ig7FEwVDptBIMrWWmewBiUSeW8h23Thr3JwEkAYuFno8AzqqwVCoAQQ1p5Dh+w12hUwjDX4u6 IbOouRmea8gTUMWYYXkR1du99TTzH4wtkyJd4cg= X-Google-Smtp-Source: AGHT+IFrO2QJpwZa8pq9OAx4k3/Zex9zjfUv3ML+kx5UgVe6MF5bN7W/+iPDXo8nUha74fanmD86jg== X-Received: by 2002:a17:902:eb83:b0:21e:fe55:d3a5 with SMTP id d9443c01a7336-21f01d1584dmr95686435ad.21.1738748414963; Wed, 05 Feb 2025 01:40:14 -0800 (PST) Received: from MacBook-Air-5.local ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-acebe3845d9sm11393548a12.21.2025.02.05.01.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 01:40:14 -0800 (PST) Date: Wed, 5 Feb 2025 18:40:05 +0900 From: "Harry (Hyeonggon) Yoo" <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org Subject: Re: [PATCH 4/4] slab: don't batch kvfree_rcu() with SLUB_TINY Message-ID: References: <20250203-slub-tiny-kfree_rcu-v1-0-d4428bf9a8a1@suse.cz> <20250203-slub-tiny-kfree_rcu-v1-4-d4428bf9a8a1@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250203-slub-tiny-kfree_rcu-v1-4-d4428bf9a8a1@suse.cz> X-Rspamd-Queue-Id: 321AE1C0010 X-Stat-Signature: 675xub8hgickuhyjyhpnq5h48ajtf446 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738748415-786743 X-HE-Meta: U2FsdGVkX1+7dvgkQfIC9zUPZDlIzkNUVYmQ2E6uIK8uZfp0BBHo7hc85g2AvXZ91KJ5uPleZJJVfUd+JeZGhOSBDjQfGJvBPtyxEmab89+DHGFqx7d7ho0KBbxgFk39vKeqid3qDHavUzQ1lBYdIzgA3OTLIOltdHjkJgprzQmw5gZPuJ33l+JnXXjCy9ipmp+eCukwCRfw48vW+vL0DvzHXpN8V8DCjS5W5J7bBg4Rbc23Emv063OkzgUPUvxVb0wpDge6OvkDFkTjBFFlCS3qz17wq6K89MoSRWrdi2xhXQxdtsWl1DEnRb4ZqOdbDMgC/qBzW29I4fBLA23drKFHBa3sScEY8IHbaSlRZJRvfM6ZLEQLYHZDMlEPPEiBe/O3AUpnln2thFs764aVpgtXzZXPaP7J0kzB8b2sNqKdQ9C8Er6Z3z38RsMHgyJLREtkclvtpZPychBtXA6zU5YQquHv3s/nc09U198gV+H7xut/VcvQ9aiwPreg2fdBNNRyUYblMLY6TPn9vwrV0nDU5s1U4HqttGSVrq3pcJJ/we/w1lEuy/A4BwdBD6IR4cTBj/uKvwR3cJdpsesYlmmkh23z90zpTflROqjCeJbJn/+ticyYFxMVEaIzlQMIPMbSa76nhJwXZDplxuhCBTwYbKWqTG3v7a+mPlCCGjHGExMJWP0HRznrx6wN0AjeyZHU0y7ldzm1VntMfMs3acKbUA2zWXfdJi+NJWy/bsxAaaCRW/Irlg9waFeOuBVjGrtIanoT4xjeCFH6IbQwodjlcJoO+xK8cABD0TEvJevleVTqWrvgEUWqjBtBdn89jEqdXM+kJsvcM7mBipVIBmXBYbtKuaoY+3eR9W/tpJ/1vKV3gg7GFZ2FpZ7LeIinQBbJw6Sty6hLoAIk/m/n28SJFsSvtO8DUypecCNJ20EF4vSAqysTBLmWLALFnwLT4I1D/I/eOifvDJfki5z wdA3S5+N 9m2vJtX+P0k+YZJz61+eMz7spRZ6LypAykuvnCkDhi8Tjvt1Bbgh77XfgnDf3CmE8jCEHr3GNWVQ1soihOaCRcd2DwAU9Kqt1xXW40JF89omAwyzxJYfD36s5O32s5nOqTgGSIdDJuEQ8uezX8RA5DNqYhdv4H7xOYxIUtL9j+UovGimGL66h2SEIzEVyp3QMtWzziIg1ph47kWOa6EYvB/63qakpw8PwkBeJ6wOJNDJE0lU7TtkxZpee2T62RssUNbpqWfEborp+m1kvAvPAukmGZEypTSOVO1MIFtJrbua6hyO2DMF4VmQf5oOPdV7nQVd/Du6KGZwtIj2mDZ/DDvDaReaMAiu1yb9RoOUVHTN/qKHpWTqw0uWN6SF9wVMP8uNut+JrT4Vg5SWoh/JIs4BTcS97heIoMBxSB5TyH4Ym/YutGBUjD0ip93p2/hlD2hdlcRlVsiPeojcJtaVYdBiJgJj2zrGqwRS51veQShSsO03oxtDe9rcbuP6CQrA3C9MlIQ1PePQhlBBbLuylJ0FNF3FvznrFtHCUfNX6h22ic4diXV/GJkg3T5wObbddYNZ1EQpIIEdxppSsqMWiQQ0Tu03Ko+tot+5QxiUkd8CiZCKpvtBtPVgk1Bj3bKcyjv5Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 03, 2025 at 10:28:50AM +0100, Vlastimil Babka wrote: > kvfree_rcu() is batched for better performance except on TINY_RCU, which > is a simple implementation for small UP systems. Similarly SLUB_TINY is > an option intended for small systems, whether or not used together with > TINY_RCU. In case SLUB_TINY is used with !TINY_RCU, it makes arguably > sense to not do the batching and limit the memory footprint. It's also > suboptimal to have RCU-specific #ifdefs in slab code. > > With that, add CONFIG_KVFREE_RCU_BATCHED to determine whether batching > kvfree_rcu() implementation is used. It is not set by a user prompt, but > enabled by default and disabled in case TINY_RCU or SLUB_TINY are > enabled. > > Use the new config for #ifdef's in slab code and extend their scope to > cover all code used by the batched kvfree_rcu(). For example there's no > need to perform kvfree_rcu_init() if the batching is disabled. > > Reviewed-by: Uladzislau Rezki (Sony) > Reviewed-by: Joel Fernandes (Google) > Signed-off-by: Vlastimil Babka > --- Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> -- Harry