From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9136DC02193 for ; Tue, 4 Feb 2025 16:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270756B008A; Tue, 4 Feb 2025 11:30:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 221226B008C; Tue, 4 Feb 2025 11:30:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E80F280001; Tue, 4 Feb 2025 11:30:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E3F816B008A for ; Tue, 4 Feb 2025 11:30:08 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9A584120B86 for ; Tue, 4 Feb 2025 16:30:08 +0000 (UTC) X-FDA: 83082799296.04.4A22D80 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf14.hostedemail.com (Postfix) with ESMTP id 9272610000F for ; Tue, 4 Feb 2025 16:30:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=tm8So1Sx; dmarc=none; spf=pass (imf14.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.46 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738686606; a=rsa-sha256; cv=none; b=elkOccW8beymgsFf2zhjJFMltHwJNd+8gpZSRvvKDyyQMH6eU+EIZ+ZrPxXhUjp71h2+hW cySg9hfe2oW9zSYMwLq6YrBEBP4xD/fV+9eJaVXyyIIcqRZQyAAuPWhe7xT9c6LTjLzwNW XdGhKQBEoQ2Gw84vpIQ62kHWE1m+XFk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=tm8So1Sx; dmarc=none; spf=pass (imf14.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.46 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738686606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D71GlxrE7tpGvGKymFaxu1Uf5BNrF3hZ/vpbqLGWS1M=; b=Ee5WG775jIBpn+zVpYEUl8Z7IjSTOf7ABoC/TL+6EhMgiIvMY3VvxyyrG/kbM1pVXh2Cua N/wbJkJERM6EuNgtcASqMxMMGRgVZUXEKKYCsCe6wilqSGxi2VSq/PjWsVxzICjG9pVpjG NlrkrER1uBBKMXkOCsIxsJPTx/GswtM= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6dd0d09215aso43341696d6.2 for ; Tue, 04 Feb 2025 08:30:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1738686605; x=1739291405; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D71GlxrE7tpGvGKymFaxu1Uf5BNrF3hZ/vpbqLGWS1M=; b=tm8So1SxlA/3/90zXrjVtrJXP0YOVht8QZW8ugUTN8QbubBRiDMcy1AsalL9mQcB0/ 3TRxxKLUH4hZx37GfsDRBjmokCJDm7L7x5Sv5dQlydP4jnEX6a2jlzMaLhEObWvfR01Z iY3xA6IKfonRTeEK6/mZTP3aC5j/iD9/bVxP4Cd1q4UMbCLuwQbXP++643jabg3Sz550 r4t5Pw72LjSEX5vQM8veFAsZxzh9nIGlSNoFlRvKglzvtPmgl2e4EHtK9GrW7Emls1qu JdDUu5R9Olcyl9zQunjPh8DtYBFE0CcZAGWYFYNjv9UXL1Hkp96cmuCdA8h85O31GquP Kt/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738686605; x=1739291405; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D71GlxrE7tpGvGKymFaxu1Uf5BNrF3hZ/vpbqLGWS1M=; b=IXbHgAL0qaHJunbLuiVTo1/PdyyzV8lWfst2LCRbvCsH/6nWPhKehHp73yUn/4Dr3j m9KSwZXvYoTw+S0z9Wxghw6f/onlm865hOdxlz+8bCwyxw+h7lMgzqmsLs3ZsKV90ETT QY88thxeEYK9T5HlWyv7DgaXgrfq9FbsdbwLPpsUvpzq7oXTy4QhrZquwqnQj+e3pGb5 6qETjWzuN7SC5toD/O/4MXt3VEFbLN0Yjsi2BQO8OQ4jEhQaWtmVMNCkHfmg/n/5WjaA GtfKOHw4pmJrkgY9zblaai1PRaMKT0hypWXcOyqUjQsjfVOPrUaKCbmlDAJAI0TPExPs j2sQ== X-Forwarded-Encrypted: i=1; AJvYcCV6IhSi0HP9quE1/G8s0eTI6mvh1IGSe2FsYHrKCy8ZI24UK+ZABo9OdpGquEjadOp3GYpcddKq9Q==@kvack.org X-Gm-Message-State: AOJu0YxDZKiNESXXKiAPyhooxAOTtL1Gf62KiX1cbleVXmQkKxahdbXy V6csPZa0QZnPLskqim/On19m6mTy5gvN/6iwbLiDmU0mfkDokf1BnUIeqH94ILw= X-Gm-Gg: ASbGncu4LRyiSN6XADr/fm8NYxeVizUPWwun/xKCAcJpnVPNIWjtJzrV50TMtqznjuM jxJ9SUTkKDCbVybMhVCWvuu/IvplcrkMmfwMshmIfOGOc7oRN/eQcmviGcT1cOhPxJmwLlMwILM COcXO9oXN/6JKgwlZUtE6DiPZS+wo92irG9lXhRHe71YOI6QZhDD/uuCNFtZPJE5RxzIg8MAJbK VnQffi3eNv3mv3fz+J8k4fe6mzVhczTxoylP2UiKOe/j0zmy/Wt944ZbZ6pc15gS6oVQpm8Q3lZ yhowW7pckRsu2TSDVmL4vpqyzAQVk0OrxpfRRrreSjODtKM7DGFdIJR9ojed1NDXpPBSSUgF7A= = X-Google-Smtp-Source: AGHT+IEh7NY7KtYyUy/WcPTOaeu6nFTa5IBV28uuo68I8Z2SH3+2+Dfjrn1+lGtIZSDuaDeya3rq6Q== X-Received: by 2002:a05:6214:408:b0:6d1:9e72:596a with SMTP id 6a1803df08f44-6e243c7d3bdmr431683986d6.37.1738686604013; Tue, 04 Feb 2025 08:30:04 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e2548357f9sm63652056d6.63.2025.02.04.08.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 08:30:03 -0800 (PST) Date: Tue, 4 Feb 2025 11:30:01 -0500 From: Gregory Price To: "Harry (Hyeonggon) Yoo" <42.hyeyoo@gmail.com> Cc: Joshua Hahn , hyeonggon.yoo@sk.com, ying.huang@linux.alibaba.com, rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v4] Weighted Interleave Auto-tuning Message-ID: References: <20250128222332.3835931-1-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9272610000F X-Stat-Signature: wobcqeoebk5p8ipidunmxtk5eywrz7qp X-HE-Tag: 1738686606-105598 X-HE-Meta: U2FsdGVkX19KdDZdEIUmOb8jM1ds7CA0pHffgrQzQnSpKOpxbLCrxMiXGBLdysNDTTF0cQHXfsf3hWXYgThwkC2O/RM4vXg2BSU5SIOJIEMZ6Yhf6GWa2VKlyI8gkJ0Ot6BHTBhi+WkxHQ65AnsVXdfvpLbB4tuCDmBi9gmyXLPyPcmPXne9xwLsF5fIs1l8htmbommpB9aZt5vCW0PLm71MGlkZC8CYqhe9V/DF1Up01U6ASUOagRlmXXE4XHtJJFH5evPZSh0qENovPQRzdTN4rMZLYaBjpw04yMExxXZCQ1UYbUTON2rjqID8knRbIunQH2OuBDrxLkI9YVGdlySelNDeuCNN+nn65Axie3xx6vy1M52UMAZ5jHu9vk775bHdIygmDqtDgsVXiwmkMyoZ8pJ+T/GDMNnk6NIzUQ59chnpHUUusx4DQqdmKMm3aN/x/NNdQCNS4MGdPkAi8OKLLLDRdMkk1DDrtqaHBtlzwjKzX6/diXksX2mvScTIjsoDRFoK7UwKUhygaDdgciUh+m8aQve5RBlfnHO9ZAHndIR9XaqH/oRRNtci8boFSSv76JPAfUEShqSFPZtAgDO1P0kWLWuU47DbAnHkrw88zleJ1Gd4fIMD/+x4xzjYJ1SGgPeFL8H4Jm67wC1gY89KLS3j8NFZWgnBDw4VvqfGpHjD5mhWFP6KeNld/nBBkfxzzDqBZQ6xo1+gOLoGxvWnxtBxmOTCG8iFXNpaukezzomKByj6ScyCv3IoItkYvr1tyt3YNkSNB+wOQbw7Lv9NFJmMcrwwIMQ65YNFoChcc6ZpzZFjVtkZcRg8XZz+nUr+FWNPOIwWo3LY3OtlxIhoeelqvCk50o8ECAoKRsCESHI7s5AmYwqXD600tWjoyglEqjO/ncPDSrnoXkYrvsGqdW5AXkxtKvEu5nI+CG3M0jzsqs70FXWzG0GjIc/tWseTrDRVzik/qBt+TIp V9L2hJ+N t2g92LnMZiWX/Ua9GLNy2xy2B/I7xICzMTi2NTc5KUeOdQKdaI0H3Ii2rTTkG3pxRKcr19E2PKlvCx8lm2pYNDRgaJkzXv8c76A/JmDtS495ncSBJJ8rqioEbz1J+QfNk41GsJG6LDessiWRyzmUcYtIMFVWlBARjZsB68Op1wOiiGa9ut5CVli1PBIWINVEI8yhTitDJr+DlgmY/it4LjkEI8Tb1hJzdm+wQcj8NBCkN1DNWWIFdKHm4CfFg4Gj2njTfsIvyiQkBYajJNPf7Z4DcOkNgc5Wuf0vB0N80IW5hDLyu1usIAQ/gHLHJlxir0A9saWgueEqeB8sBly2kvLYq3eiPsa1lS0jgSgGXlPnyg5ZlmkWq8F2FnP4ZEtbdIqpdhxu1DyB+HNcdTm6GW5PIxSapMOsJUiGV/IJTyHpY8YYjgCxrfotXox7om67/qQju2ICxMjb+1uhG1tMp05aycNCIYxrJim7cC/jH2AtJ1+E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001171, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 04:50:26PM +0900, Harry (Hyeonggon) Yoo wrote: > On Tue, Jan 28, 2025 at 02:23:31PM -0800, Joshua Hahn wrote: > > I believe the author has successfully addressed major concerns > through the revisions. The interface and the code now look good to me. > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Thank you! > > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > > index 80a3481c0470..cc94cba112dd 100644 > > --- a/drivers/acpi/numa/hmat.c > > +++ b/drivers/acpi/numa/hmat.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > nit: is this #include directive necessary? yes because hmat.c now calls mempolicy_set_node_perf(nid, coord)) and best practice is to "include what you use" to avoid hidden dependency issues should another include be removed later. ~Gregory