From: Gregory Price <gourry@gourry.net>
To: "Harry (Hyeonggon) Yoo" <42.hyeyoo@gmail.com>
Cc: Joshua Hahn <joshua.hahnjy@gmail.com>,
hyeonggon.yoo@sk.com, ying.huang@linux.alibaba.com,
rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com,
dan.j.williams@intel.com, Jonathan.Cameron@huawei.com,
dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-mm@kvack.org, kernel-team@meta.com
Subject: Re: [PATCH v4] Weighted Interleave Auto-tuning
Date: Tue, 4 Feb 2025 11:30:01 -0500 [thread overview]
Message-ID: <Z6JAicm5VxE6HKnO@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <Z6HGwq731v+VX1CP@localhost.localdomain>
On Tue, Feb 04, 2025 at 04:50:26PM +0900, Harry (Hyeonggon) Yoo wrote:
> On Tue, Jan 28, 2025 at 02:23:31PM -0800, Joshua Hahn wrote:
>
> I believe the author has successfully addressed major concerns
> through the revisions. The interface and the code now look good to me.
>
> Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
>
Thank you!
> > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
> > index 80a3481c0470..cc94cba112dd 100644
> > --- a/drivers/acpi/numa/hmat.c
> > +++ b/drivers/acpi/numa/hmat.c
> > @@ -20,6 +20,7 @@
> > #include <linux/list_sort.h>
> > #include <linux/memregion.h>
> > #include <linux/memory.h>
> > +#include <linux/mempolicy.h>
>
> nit: is this #include directive necessary?
yes because hmat.c now calls
mempolicy_set_node_perf(nid, coord))
and best practice is to "include what you use" to avoid hidden
dependency issues should another include be removed later.
~Gregory
next prev parent reply other threads:[~2025-02-04 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 22:23 Joshua Hahn
2025-01-31 14:23 ` Honggyu Kim
2025-02-01 16:49 ` Gregory Price
2025-02-01 16:53 ` Gregory Price
2025-02-02 13:51 ` Honggyu Kim
2025-02-02 14:12 ` Joshua Hahn
2025-02-03 12:44 ` Honggyu Kim
2025-02-03 15:38 ` Gregory Price
2025-02-05 2:26 ` Honggyu Kim
2025-02-02 13:44 ` Honggyu Kim
2025-02-04 7:50 ` Harry (Hyeonggon) Yoo
2025-02-04 16:30 ` Gregory Price [this message]
2025-02-12 17:27 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6JAicm5VxE6HKnO@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=42.hyeyoo@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=honggyu.kim@sk.com \
--cc=horen.chuang@linux.dev \
--cc=hyeonggon.yoo@sk.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
--cc=rakie.kim@sk.com \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox