From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B465C02193 for ; Tue, 4 Feb 2025 16:26:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21F48280002; Tue, 4 Feb 2025 11:26:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CEC2280001; Tue, 4 Feb 2025 11:26:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BDFB280002; Tue, 4 Feb 2025 11:26:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C85EB280001 for ; Tue, 4 Feb 2025 11:26:06 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4F3351A0B19 for ; Tue, 4 Feb 2025 16:26:06 +0000 (UTC) X-FDA: 83082789132.05.D942EEE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id AABD940002 for ; Tue, 4 Feb 2025 16:26:04 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B2pPWBAh; spf=pass (imf04.hostedemail.com: domain of jaegeuk@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jaegeuk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738686364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ba6Xpky8Fyf3+tO4aMJ/oeHU/41orspz9L/3yBudjhI=; b=SMnlYcU8+eSRpz1ydvLtRjyjl+3kMAjPIQH4d+r8Gn80k4261EGPkJLKCq53Ky9cWX3wDa kAOgXfsjiZS6Kprq9qrsiFsgAKSnO+87wkX9ggviiFvcG+xKSKEq4atDVGExCUqytlMpo3 BIZoQHA/haf6SC+IXJVZcjwAA5Xe8C0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B2pPWBAh; spf=pass (imf04.hostedemail.com: domain of jaegeuk@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jaegeuk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738686364; a=rsa-sha256; cv=none; b=LIDaHFzglZG4NrexpUI/mf7jRMbSt//jQmZ3kD1PRfFdow/pPofU8I/TNGL9y3RuU0nVRG QMq9uh6R/m1vczdndziMjfG+mR4vug+J9mPwrdPlhjuvche/e5NxjGMN0mfHlvqb9K39rc Gjxfx3XzjmZSQd4qTNjIabir1uwIX4Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D3ADDA429BB; Tue, 4 Feb 2025 16:24:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DA35C4CEDF; Tue, 4 Feb 2025 16:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738686363; bh=L54LXQnOXWaBaK5VCO3A3bjxwgajDXv30wjGTPt+098=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B2pPWBAh1vII7IozOG5m4s4KE4imJgEszqsdtJdsekdCwiDT/t2ls283r81dquCQy gB1rTpS+CFvmUFelHBeZoYpCEh89ao9CHqq3XOIYDoPOEqj3+CuEcEERLhpzkoyjWB HUWB5UH+krcTGZNezD1SBnuhzPkUJZ+Gu/SSKlXOzUKJLizTPVox1e2h5VKIKl83Ty IJFA93WwuupUf57V/AjeGQSPMM9b2fbMA/1a3qU06TSqWQToSwJG8RdikVMJweUYcl KPRnZC0kmQh2NWWMqLbmehulmnBU4qVT4rtOJHvwmyvOlvTAIkWKDB79cpO+H5cnJ9 XStY6fB0R/a8Q== Date: Tue, 4 Feb 2025 16:26:01 +0000 From: Jaegeuk Kim To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/2 v8] add ioctl/sysfs to donate file-backed pages Message-ID: References: <20250131222914.1634961-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AABD940002 X-Stat-Signature: cpoqb9yskaw1zt7cuqsxmjpicb15mzn1 X-Rspam-User: X-HE-Tag: 1738686364-188780 X-HE-Meta: U2FsdGVkX19J9kF/9sxZi7Ivmn5BPqGxKqzcA1yPr3yxftTheVGyvuHrN8OFi7jZJVY9vCC6viDRfKpVpRb2j3KBkRHZLE/0tOIP9Gwn7l1IxvT2ur2n+FNzyvCUpKODF/Uxs6mD7iJrFE51KcLak7q2L267o/9itvdnWnOTGFv33hsw8w4kifj5/f31EhboJm34dmEOewBv1rSc6RSHUsiwHIZa7yeVUlF8+txa/wsU6K+fWM4BpsRJuokYbHCkMIM0HcLpQumUGluEJcz6EUMV1E48qlUFjbZVaVMOauRWMMfhGa1Q3sjzqEyJtzVQ3BDzqF38EcqqSlmWvg8ChZrFxDfIMoBCuxZU7skVxDCjyMsP0vtVZCMUxwe7PievXXHT3n+jc1coUq8GIy8yVkvNGvLJaD/bCWQrcnx/PpfRlP8Fo74IBqIS+U9bq9lLirOYBWf/sGNi1Z28qOKG3PMZ01DDBO9Jp8gowG5zrSlVCwbMvVQdP9jVhpNvLucsZix8/wst6oSzPkpsnXvPxJUwyPBRK9bQJdbW9p/kS0M2ir166B3QPt68rs67jXcSQskrG7gPwfwZLM8bpLQXhwZLT5CdL3kvDnXrWEqORSGr7xKCV5fplRqSUIQWTIksmTS3D4ojAZiHEp0Wt35TW0w9ZZfJeEFgBywIJBPTN/SAbMLRl8W9tIGIvIq4hS1mkhcv6fw9mRYfFHEZcByqOv1tvtSYGNEXltCZORrB2fzm0oNSBLKEUuZTWqBbaLLCMf3pd5EbKaWhSn3utxHLIk0EUBSJEsOoAGjdJoC2yu3R9vwOSqxDmv8Il2/1dNut6pvKkcuV2JocwTYVtDd7CJHx3WjfTHl26Q6pFLmNnP3+qhm/Ah3CNVbblkxQQi+mgUQqrpN/i997t0rhslQr86uWJTgsylvZB9AKbcN9IpMBvRdYwVVwmjCpiRPKUf8nuBCX503UzzAw53xibCK z3JA02qq OVdKJ+YxRV5zmlMkKRXeosVLmCGEyQ2ANdinx73ZIBbNADtTgYCy1GbVgq5/z5qpNC27pScUb1+skLa/fqjIj4gLb4kD0AHxbUqZDg3vFagJxy6rxMG6Ge6CH34yAXElGCuA8qETjoAixLHw9VoeXRn59R63vhSXF6JQENh4T8/FkHpJeVpIlMmXHch0p8VHcLaccO3OPhNBlEyOXwXNW/wTluYnyCkgg3f7l21qxZvmoJ8hTXz78X0rsE+H+49ZfZmoG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/03, Christoph Hellwig wrote: > On Fri, Jan 31, 2025 at 10:27:55PM +0000, Jaegeuk Kim wrote: > > Note, let me keep improving this patch set, while trying to get some feedbacks > > from MM and API folks from [1]. > > Please actually drive it instead of only interacting once after > I told you to. The feedback is clearly that it is a MM thing, so please > drive it forward instead of going back to the hacky file system version. I keep saying working in parallel for production. And, no worries, I won't merge this to -next until I get the feedback from the MM folks. I was waiting for a couple of weeks before bothering them, so will ping there. > > > > > If users clearly know which file-backed pages to reclaim in system view, they > > can use this ioctl() to register in advance and reclaim all at once later. > > > > I'd like to propose this API in F2FS only, since > > 1) the use-case is quite limited in Android at the moment. Once it's generall > > accepted with more use-cases, happy to propose a generic API such as fadvise. > > Please chime in, if there's any needs. > > > > 2) it's file-backed pages which requires to maintain the list of inode objects. > > I'm not sure this fits in MM tho, also happy to listen to any feedback. > > > > [1] https://lore.kernel.org/lkml/Z4qmF2n2pzuHqad_@google.com/ > > > > Change log from v7: > > - change the sysfs entry to reclaim pages in all f2fs mounts > > > > Change log from v6: > > - change sysfs entry name to reclaim_caches_kb > > > > Jaegeuk Kim (2): > > f2fs: register inodes which is able to donate pages > > f2fs: add a sysfs entry to request donate file-backed pages > > > > Jaegeuk Kim (2): > > f2fs: register inodes which is able to donate pages > > f2fs: add a sysfs entry to request donate file-backed pages > > > > Documentation/ABI/testing/sysfs-fs-f2fs | 7 ++ > > fs/f2fs/debug.c | 3 + > > fs/f2fs/f2fs.h | 14 +++- > > fs/f2fs/file.c | 60 +++++++++++++++++ > > fs/f2fs/inode.c | 14 ++++ > > fs/f2fs/shrinker.c | 90 +++++++++++++++++++++++++ > > fs/f2fs/super.c | 1 + > > fs/f2fs/sysfs.c | 63 +++++++++++++++++ > > include/uapi/linux/f2fs.h | 7 ++ > > 9 files changed, 258 insertions(+), 1 deletion(-) > > > > -- > > 2.48.1.362.g079036d154-goog > > > > > ---end quoted text---