From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A49C0218F for ; Tue, 4 Feb 2025 05:49:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B30E6B007B; Tue, 4 Feb 2025 00:49:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C836B0083; Tue, 4 Feb 2025 00:49:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC356B0085; Tue, 4 Feb 2025 00:49:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0B8026B007B for ; Tue, 4 Feb 2025 00:49:35 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 77BA51C7AA3 for ; Tue, 4 Feb 2025 05:49:34 +0000 (UTC) X-FDA: 83081185068.05.5FF7FB7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id D09DD40004 for ; Tue, 4 Feb 2025 05:49:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2teENuLy; spf=none (imf12.hostedemail.com: domain of BATV+ea2238c820210655d397+7835+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ea2238c820210655d397+7835+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738648172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s5Zhk5Xv/to3IdCo2qfEM3Rd+KIEFauoYnzDJ0mZZUM=; b=78oJr/3YrCxo6c8Avdld8qj79B0npm+MxswsyuoAZAcP7KdEfa9O5OLDLQnXbjzuGuz6E8 ecHfUQRF5R7j5pgwIsQ3UldszZQS++lyGj0dpTlg7XW2N+En1XtjeCOu7K/rxIkRq+Kg9J tNs0N/dANwCGgsaFRYs0OlpUrCAtZzs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2teENuLy; spf=none (imf12.hostedemail.com: domain of BATV+ea2238c820210655d397+7835+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ea2238c820210655d397+7835+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738648172; a=rsa-sha256; cv=none; b=Geg1zrqV8ivsDcOPAu1hk48+9f86Xmc+eo5xJUDcQ3vPTIAVE5Dd+lENOsbMgOovrq78tt 3hJZu7CRw9Ns724KWsD0IoBBxEbwffPCTaXE2lGUnd0lvAiO9fFTEZprGkNvaqruLHbj4k JeBREJHarJpBeJWUVfaTvmd1UjBSbN0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s5Zhk5Xv/to3IdCo2qfEM3Rd+KIEFauoYnzDJ0mZZUM=; b=2teENuLyXvCrs6O7KUZeOOB4IB Bn2GJi+MbkopSRPect/FNTGL5iDJOzvTmAoo0YT3ykWhkSffKRAZdI2SL9SPX3PfcKh9fCpWcmN4d W+K9CnK+Qb7vzSYoz9fB4ZyA2+6QnfieF+7nheA1bWJ1Wid2Cs/PU5NqTptK7SYqS2w+5X4xBc/fS mnfThaeA2Xm3zjtcU25OnvMxrhrsD4F1kBYMXY3lLX2X1NEcdfMqZnWbqS883n5GeNzNlasdXmudK 8uUsWqpbESK+d8HEyHAPmiPoaTqjf7d5mgO/eQ52PqS2rmEZvpziJMquLjq0xEfLeiT61Nnx7ULit yCIzlXZg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tfBoS-0000000HIzb-0ClL; Tue, 04 Feb 2025 05:49:32 +0000 Date: Mon, 3 Feb 2025 21:49:32 -0800 From: Christoph Hellwig To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/2 v8] add ioctl/sysfs to donate file-backed pages Message-ID: References: <20250131222914.1634961-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250131222914.1634961-1-jaegeuk@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D09DD40004 X-Stat-Signature: wcaugo1og8ky8a1s4ejstmgw5onw9wc5 X-Rspam-User: X-HE-Tag: 1738648172-833807 X-HE-Meta: U2FsdGVkX1+lvtvCkQ0PzuQRCaJ3pR0BgT4DCi0gGmYQp7cOjiPDKJB12sagntyn24o1xyoHV4vc1fQbrJRMBLtDx9WO0amtHGBUIx+S5fdnHMNteBULYYgDtTQ08oeSunpV70Uo1OO3yebVjO+zmKw+/cBvrJYJD0YwQzIS93ILC+z4om6rc7XpbPeO/N6fZBvHMzYGoppgdL7AWJdVIzYxOWzldA2882lxWxa6lTFNE7+a1LDfzUfCPvT5y45GFEVFHMtDsy+k5IDDMv6QXD9b+BexCMLexvF32vg7FL4tzpddi+OF9BUHLq0IKgfW5YnzMgXV43A2hAvPi3lPg93GUX0FFxvGIalJR1tj9uqsinTn5Ha6kiKNXDb0fyoC8thmLHym87JBXQbJ/9xM5uGSaPkpHBmO5A4CfSKwyPk3jdhz9AxtEOC6htHMQk4eeV22IZwzcoNqpLky3fnh0Lsq0byMG7qVMYnVJ6KEaJLt4MWAh/0pQq/FU7d+sOCtNratYImUEhxKSbzyD7kW6MY3HuYuY1nf3MKRYeAKq5AcWVzpPaU0VJZ6JPqiN3kCYaBMwHRS+jXuZggMaUdGmb0AiVMvru9Qj11e340XFIftBSGnFjOLclxPc5lYlWorAtte3++bubwJlWcjzddU9ZqRJNyrOHAqG6mfup0o9LiwwYVN132TkXPvYR9JgXvxBDDoCY2JlSbPh0H4pyKcfRYuDGDBUOXD64mbHEA7iFJ12bRWZSypabmNTyQzCWM0m88j73kp4CbU3tw+zpl+Tv3GwUw5oPCkHovC0MjHKmSQPoYYjmZL2S5pm0dZnlmODF1psDwpJS33AALJjJ5LXOn/PPMV2wXxKLZ4f0rYCYhRbqGB0MDLLpPgnolNx5eqn95UvSSrTIFDriN9xc/aYp7RG92lQ0EDasVyq7byab2DbnhV/Vof33HdU49ZAlV64ES3YBucdKb9ORK7PcO 1l990O6C /Xxpf5mfsXCJQEga+GpZ/xHR1y8FLAh1Rs0RvyaG502bKpLdq9EeA1NliIKOvbH50fISQXLSEOcC72X1vYGoghf5acXdQWTgVDbg5oGKy/w96O8ru9FJSKwm4TPPtiM3u42O/InSyMq2WzklvzsAT/yW5CgCpWaf4CqydKz+0TfmiAwBy05CPuV0VVJNpsB9aGuZ6BzeUGZ5D14I5kGnGyIE27GqCd8ElxIZ5XMDUfNIVs1KfhIerK1m+ZV7o11pqJ+De2Kuwqbzy7TmAfao6Ya6SUMXxio0D/8CfU7m4w+MjgqDbf06nft3j3BtYo++0va7tG+9Fmjlhhofmbx2IE5FTXMy5fTgHBf9banyK4WcSILmJZf7TflQOn4FASN7J9eKQbDbAVVGrzZ89UXoB4W8AcRepPRzwsLxu34ZFGlwRw0v+nBcMG2KzJv+Xt2oTtC9pNa4uXtL+YF2UE0vbHVIcvSa7ls4Mb+sSr054z5yUotgyD77SeMe6rqcqbRTcrYdfpY1dCOpInYhPvQNyyLpRl3Sl1rIWJD9zX0ANZCTPwh3bOV2nLgZXadAk3ybXFGGkFvmVwlV8KjoG2mLEz3zsSx/CfyHgPvD0w0SqFtd0wg/0datt7a/XX2YGd7z89prgV/VN7v3YC2yBfWflOfvOOYtJbdXgCMNwolzHEW5fozoP25YnNiKArica2Gpi2HMYceu5LyAGoR5QSmAMLr+gWnhiVrstBjumQIX6w80tZfoqbOAWhFmaYTO4I+3/VZ2XU0EX22Wqrr7eBD/xTc3HqYRWBOe2Z3eHw3g/GJLq1035zQ+LLpOHiqhDZj6vGexUDhfL9DKXwjb7q6t5CizA4zOis/r3V0TfOljR6UzG4USO8guh/0HPiJ9qhsHsIrbcHuD9Q97E5BDWj5ffeyY3Tt1/kdHzJwFS6tH1Yh0juMeSCkU821mM3Zc/X0J60aCaM5dP031q+LZzMU/HGiBF4xr+ 1ryGhXD8 i8B5F6iO949uYq7oAbjYoP0+uL5dozrd5BxUc19rzG0eXqbaIYXfn/hxw940u7rQ6FSeEzznbFFhQWhjZo3/Is9lh9FUKmheW1S4/ME1Nb0wsDPw3TMZXhzQ7Xe8+4O1Tp0mfH3ZJzZetcQN3XC6CIftQdn4cZMKMnUTY5Ow0pJrUFFDNzaW6+zBShL2YWiM1Rgmw8iDE6QtAYL27tGZMv7gkBGA+VUfC09o/jxd/qEvOHVcdEj6VdN9R88DM9hTDkVM/TzAQFAqAI3NZYkZRr3Ye1aRytbNxStylVVSL2NT8oNf3qFMv016kW9HRMET0VL2WtwSBfpfvXTctlu5zzVqvCwv4fZlgNDxmA+lMsO8wFTLAFzQouMBE1toSQWJjhhpMo8KApnkBoCTNZAd5Z3a9hAARUJK/brMmqCxuQj8a6UI4MDs7Xyx0flvmNgnmavWr4KpAd3entvmpkL912PHJKUOkl9GgVvcejOO+65dBvdn9M3aCou2jNMB4lwOhGUDfQHTJ0yIo7ZVpenQVuUuo9pP0sFSOiSx68voOIa5hYKHbc356FjJ6ogNW45j/xH9h9ZIZhb8QaEx9Fm4L1G1K2mNbfYKZ63KLhlsSi+imoT/56QrUG3LE1+q7AcpeF3C/6/DVdAdZJRgetGw8bfJsqy6fZfapwgwUNslztTy8RUpygzr9VS5rMy5CW/LaqmwcuWw/w9p526aeUJGi5u4VriTIIddrNQ2M0S3xD/qOyrK6Gvna/6AQx8rDEGGkFsX+6GMtHm5N415Pdb28adgXyUBJ6hXIbrHuJntmbyoklcYldCBpgPf/1eJxYLMGgxqmMwln+tt3qtW92o8RRXVpQ52LoRiaYAhjNXUYjRASTmW0UPlLqRNJpmE2ZyqYTk4v77+B7sbtGZemJ4vqnOXs9rL58V/oczLkbhG5YIf9uGb6ElsPbWNa0eGvYG4wKGfb0TvFf7rPmgdJhQr9Jcn10kE5 H0aw5VW9 i3JYRYEu69nbiHIWLppncMrnAtIaIcCtM15ez0s3UZa+mYF3RU1uJdtxlHFUTcjBNXJSd31V60XPVaCXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 31, 2025 at 10:27:55PM +0000, Jaegeuk Kim wrote: > Note, let me keep improving this patch set, while trying to get some feedbacks > from MM and API folks from [1]. Please actually drive it instead of only interacting once after I told you to. The feedback is clearly that it is a MM thing, so please drive it forward instead of going back to the hacky file system version. > > If users clearly know which file-backed pages to reclaim in system view, they > can use this ioctl() to register in advance and reclaim all at once later. > > I'd like to propose this API in F2FS only, since > 1) the use-case is quite limited in Android at the moment. Once it's generall > accepted with more use-cases, happy to propose a generic API such as fadvise. > Please chime in, if there's any needs. > > 2) it's file-backed pages which requires to maintain the list of inode objects. > I'm not sure this fits in MM tho, also happy to listen to any feedback. > > [1] https://lore.kernel.org/lkml/Z4qmF2n2pzuHqad_@google.com/ > > Change log from v7: > - change the sysfs entry to reclaim pages in all f2fs mounts > > Change log from v6: > - change sysfs entry name to reclaim_caches_kb > > Jaegeuk Kim (2): > f2fs: register inodes which is able to donate pages > f2fs: add a sysfs entry to request donate file-backed pages > > Jaegeuk Kim (2): > f2fs: register inodes which is able to donate pages > f2fs: add a sysfs entry to request donate file-backed pages > > Documentation/ABI/testing/sysfs-fs-f2fs | 7 ++ > fs/f2fs/debug.c | 3 + > fs/f2fs/f2fs.h | 14 +++- > fs/f2fs/file.c | 60 +++++++++++++++++ > fs/f2fs/inode.c | 14 ++++ > fs/f2fs/shrinker.c | 90 +++++++++++++++++++++++++ > fs/f2fs/super.c | 1 + > fs/f2fs/sysfs.c | 63 +++++++++++++++++ > include/uapi/linux/f2fs.h | 7 ++ > 9 files changed, 258 insertions(+), 1 deletion(-) > > -- > 2.48.1.362.g079036d154-goog > > ---end quoted text---