From: Matthew Wilcox <willy@infradead.org>
To: Alistair Popple <apopple@nvidia.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] dax: Remove access to page->index
Date: Fri, 14 Feb 2025 16:16:02 +0000 [thread overview]
Message-ID: <Z69sQl-iq_d1YQSE@casper.infradead.org> (raw)
In-Reply-To: <ivwl5yqx7bfa6hw233gaicmdb3tvqmy6tqsrfbiyghzwlrghxk@yifmg7leosa7>
On Wed, Jan 08, 2025 at 10:24:00AM +1100, Alistair Popple wrote:
> On Mon, Jan 06, 2025 at 04:43:13PM -0800, Dan Williams wrote:
> > Matthew Wilcox (Oracle) wrote:
> > > This looks like a complete mess (why are we setting page->index at page
> > > fault time?)
> >
> > Full story in Alistair's patches, but this a side effect of bypassing
> > the page allocator for instantiating file-backed mappings.
> >
> > > but I no longer care about DAX, and there's no reason to
> > > let DAX hold us back from removing page->index.
> >
> > Question is whether to move ahead with this now and have Alistair
> > rebase, or push ahead with getting Alistair's series into -next? I am
> > hoping that Alistair's series can move ahead this cycle, but still
> > catching up on the latest after the holiday break.
>
> The rebase probably isn't that hard, but if we push ahead with my series it's
> largely unnecessary as it moves this over to the folio anyway. I've just posted
> a respin on top of next-20241216 -
> https://lore.kernel.org/linux-mm/cover.425da7c4e76c2749d0ad1734f972b06114e02d52.1736221254.git-series.apopple@nvidia.com/
Looking at what's in linux-next today, there's no changes to
dax_set_mapping(), so this patch still applies cleanly (patch 2/2 is
obviated). Can you look at this patch (1/2) again and apply it if it
seems good?
next prev parent reply other threads:[~2025-02-14 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 15:53 Matthew Wilcox (Oracle)
2024-12-16 15:53 ` [PATCH 2/2] dax: Use folios more widely within DAX Matthew Wilcox (Oracle)
2024-12-16 17:49 ` jane.chu
2024-12-16 22:25 ` Alistair Popple
2024-12-16 17:49 ` [PATCH 1/2] dax: Remove access to page->index jane.chu
2025-01-07 0:43 ` Dan Williams
2025-01-07 23:24 ` Alistair Popple
2025-02-14 16:16 ` Matthew Wilcox [this message]
2025-02-14 23:37 ` Andrew Morton
2025-02-14 21:44 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z69sQl-iq_d1YQSE@casper.infradead.org \
--to=willy@infradead.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox