From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A451C02198 for ; Fri, 14 Feb 2025 10:02:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2FA06B0089; Fri, 14 Feb 2025 05:02:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DF536B0092; Fri, 14 Feb 2025 05:02:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A7316B0095; Fri, 14 Feb 2025 05:02:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D6FB6B0089 for ; Fri, 14 Feb 2025 05:02:45 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 102BC1C93B9 for ; Fri, 14 Feb 2025 10:02:45 +0000 (UTC) X-FDA: 83118111090.10.63B87C9 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf18.hostedemail.com (Postfix) with ESMTP id B56CA1C0015 for ; Fri, 14 Feb 2025 10:02:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CVwsWe5H; spf=pass (imf18.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739527362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ra/Dx+WxOY1D7TZc+vQhA7pPWzHT7UffFBZk9LGvtVs=; b=Yjd0hPOY7PVIo2pX5xmU++zEks3HX/zPwcvnKZkuAWp0U7lMmh9yLoZsg1iY+L2aIyMzI1 wucK8DC8YvtRQGsN21wFDja02XHVazvRa31mjvw+gAlvfr6t1oAm9ydkVnydXc0dTR19dF YJWMr0Ds4rwdRmFu7TEnTZwRXTjJh+Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739527362; a=rsa-sha256; cv=none; b=QCfq57ZrxB+lndYcAFL8roxyhZEs3qF9vqm3xnljws485CnVk0z6rXvSGUDtgIXx6G2u+p awzw3MLtZkGLrT9lTijZ4Q9LYFhkQ/gQx3vxlF+zpEzHe5hhjfvY3gAnd7HT6e06WJSgy2 tRQB3xy2nFjTsTTneVx5j7AzP7UqW1M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CVwsWe5H; spf=pass (imf18.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51E2nlN8016442; Fri, 14 Feb 2025 10:02:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=ra/Dx+WxOY1D7TZc+vQhA7pPWzHT7U ffFBZk9LGvtVs=; b=CVwsWe5HmaN7MxHB6a/tRHrUZYu4sxkab46TGw25hnKi9S rhNByw8aqMUcqYBu+5A279T84f2ec5gz+fRSpKlLtRCJ/mRedvbJIptA0yhOu2lP COoIB4iEP7P+GXGxG8m2N0CHDf1V8R0ejCOvIUUu62H+IufSPlhU6RV4Iw3NaOgg uy0yWLoMR8nJGrBpq6xTXvAyKsQndYhcAuMrHPITKcgTRQ6akqrhGnwg+ma+FzXO jCRvxMzKueF1Q7oHRt+mSPlduEdC3ch3jxbODQj0MmAJkro7xGiv6ZP8n8F/c4fI 4nTfJI8xKT3sY+bpQw4Y0+7Q1tFNwkXhGUCRy8ug== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44skjuvk3x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Feb 2025 10:02:41 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 51E9xeF9031418; Fri, 14 Feb 2025 10:02:41 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44skjuvk3v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Feb 2025 10:02:41 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 51E7IJup001051; Fri, 14 Feb 2025 10:02:40 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 44pjknk0ay-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Feb 2025 10:02:40 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 51EA2a9a55378420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Feb 2025 10:02:36 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 71A6F2005A; Fri, 14 Feb 2025 10:02:36 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48BF920063; Fri, 14 Feb 2025 10:02:35 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.2.165]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 14 Feb 2025 10:02:35 +0000 (GMT) Date: Fri, 14 Feb 2025 11:02:33 +0100 From: Alexander Gordeev To: Frank van der Linden Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev, Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org Subject: Re: [PATCH v3 03/28] mm/cma: introduce cma_intersects function Message-ID: References: <20250206185109.1210657-1-fvdl@google.com> <20250206185109.1210657-4-fvdl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250206185109.1210657-4-fvdl@google.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: t-In3U_tmNjyWhY_yTRmtH3LI7-89WMB X-Proofpoint-ORIG-GUID: SYQ8donj5--N2ryoZQafKeRuOJfV_YtY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-14_03,2025-02-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0 mlxlogscore=501 lowpriorityscore=0 mlxscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502140067 X-Rspam-User: X-Rspamd-Queue-Id: B56CA1C0015 X-Rspamd-Server: rspam07 X-Stat-Signature: pcjbooy4o4z35o7zifj511w1h18k36oz X-HE-Tag: 1739527362-28503 X-HE-Meta: U2FsdGVkX1/34+HhISW67/yEAMEaQWJJx/2py1S3aPidnaqzKLFa/j2JPu4CddV+6GAjIcHGqydsgVY2E6N+b5SaoaCv7qV+gL2dXfVzaHcP85cHWBNdPJpWeyz+LNwD2cehf7cZ9n4ric9LYAJgg00VJQbq28NfItFx15I8vnr/UsHqjz4NfiNSj2Wvam6Qe3eBuaDdVJ3u1b8QIoFQDZJjvV5XnsZLsKEkoGTy0PH6Kq5YlBcQqI/xw/PqbpZZkM+gfCsRsxTCqW2SJqVs0b5jm2NYDkuW0r5bigUvEf0a90Yp+sNZHCFS+/3lJwIDtV8jH683kqZEnRzmpVWTZ8MaHvbjOO8qSXR0lvI3eDQ7rbYshjnpJR20aQ50V0mlKraw13LxzNqqWv02W5JCJoMHWrgyyn3MKCsJizhdbeiIjePsTbGE5GbxKxoS0ApYFipkt1dnSxpAQoj88hfT7IgiicidBmXsIJKMsa/AlGdoY3MhB1RE6zZVWCyVFKfPiGnoqS+zKzlNqn+UUjG1jOTrv2eIN8t0nOes+AiJeMrpT07W5X/gflSMhTTliBT9jNXW1X+sQ+RwY2sUERSGITtCiBhEdOKl+zYLSVbHdxz1tqXF+Gn+5OSr2LJF8kQBI61miAFxwvECi6h6B606eoHFajufm0/HzKlLqpr8GXv2f5KTjaQ5sNDLSzc/7eckCJLjOXVCHE5PLGAB1qy/uxgWE6WZytbft7MFZI0+LZyUZhYReWEtlbfKOL+36NmdSg5wrTd5T6hpsCRVfHmzZkVQrS0LkY/EUhyqt+LDXLBJdYMRpqFZVYimmvfJUJqel7yUF9rttWfimfvuLT4CjGeGsoJL+5zYilaYVhj7xCdsVtmbjhkWjCanwdY6d76TeyeNiYDgn9txV74R1/sFf1NSUdfHecwx2r7ogAAFz4ihFr8X8FSgPMeuDbNStNZarGQCg8IwgsmeG4RdZfD XWQ1osJu OTIcD4u1346JhUFSaCxwevBNtB1+butTUyR1O42fAuxzcOIdK9aRaGc4j6zmqdpIvDi0FglcO7xBbp2AhVyPEosbCTcGwlgWwbqThAwJ+fX0RSMQ3bsBSYr0OqNnZfPsNEW+jkEphr3JeqgoJ2xFXphsZJAaxdH7KoSZK/zgrLksPiGFmOB/2JraQBDOPWQkj9XAJi1I1Wx91dhV+8udy5d6W3nR6MfvdTaEsHh9Ks0T6+dap1DgeuNTWXTvuDrBK4sl1Gg4wPZa5xqbIQDkG3lEcuJlwOxb0uYip6MCp0e2Vr0ttsPl+JlH7BkzU92PEac5Klue+MkShdYOVmQp86PCZz3zCAvFJOZqH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 06, 2025 at 06:50:43PM +0000, Frank van der Linden wrote: > Now that CMA areas can have multiple physical ranges, > code can't assume a CMA struct represents a base_pfn > plus a size, as returned from cma_get_base. > > Most cases are ok though, since they all explicitly > refer to CMA areas that were created using existing > interfaces (cma_declare_contiguous_nid or > cma_init_reserved_mem), which guarantees they have just > one physical range. > > An exception is the s390 code, which walks all CMA > ranges to see if they intersect with a range of memory > that is about to be hotremoved. So, in the future, > it might run in to multi-range areas. To keep this check > working, define a cma_intersects function. This just checks > if a physaddr range intersects any of the ranges. > Use it in the s390 check. > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: linux-s390@vger.kernel.org > Signed-off-by: Frank van der Linden > --- > arch/s390/mm/init.c | 13 +++++-------- > include/linux/cma.h | 1 + > mm/cma.c | 21 +++++++++++++++++++++ > 3 files changed, 27 insertions(+), 8 deletions(-) Acked-by: Alexander Gordeev