From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA61FC021A4 for ; Fri, 14 Feb 2025 09:33:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51382280002; Fri, 14 Feb 2025 04:33:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C1CE280001; Fri, 14 Feb 2025 04:33:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3627C280002; Fri, 14 Feb 2025 04:33:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 177D2280001 for ; Fri, 14 Feb 2025 04:33:35 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8313B1C9AF9 for ; Fri, 14 Feb 2025 09:33:34 +0000 (UTC) X-FDA: 83118037548.04.18005AA Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 904B7180005 for ; Fri, 14 Feb 2025 09:33:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lNFHSEBz; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739525612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ouJI7+lhuUO5Y4jaomCd4wqj+zZjtecA9f0o1ku/ObU=; b=dX5iNQnqVG0ViIFmT8GNldTRcRLZ8W1UVpl5nCjPGfBYoAX7NkCsrr8ek9gSm8M+1Uturv abQAx8E9yhNxi8bmNl4S7NCAs7jdee/v+r4CqsNnuCe1Btqa4XaH6HJwcBR6z/xQ7x/ZKE CU86399/twmPqk/R14aDZKcixi5QxKE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lNFHSEBz; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739525612; a=rsa-sha256; cv=none; b=O9bLCeEkxJ5ZJooXx96hy01jEJcgTSmroVkonAPkY+87XGRw/04LlnakQWrtJv/zu3nyqh 9PVgNuWT30sE+3nmVml6crozPp9hQIUvkeGyjakdzFe3WPXQj6fxOMh63a05KI5noiP9es b8ilvPgu1yRPugchTV+hbSprpJKNEpA= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-220dc3831e3so22330495ad.0 for ; Fri, 14 Feb 2025 01:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739525611; x=1740130411; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ouJI7+lhuUO5Y4jaomCd4wqj+zZjtecA9f0o1ku/ObU=; b=lNFHSEBzeJHPJmduDXSB4GJrGxJKLxXOvQkdcpoSEVdBmYd+9vN1Q3jE6H+u8C+B4p atv/IYvA2X7DTGZlPGJnr2E/b1M+5lxp/mqPeFiD6CNGTNldGMyZF9a6QnxrJLTZEMcJ qgVwoAAHw33cvDprKlMR5Rb46sl2FbYsvtL+TTAkq9mrSo1QKFWa799VqUPpYioQM0G5 Qss3bHTtuKa/s6d2H5MzmenfjgnFaawrOF4lcSCPgY1fJkyAmeR4TQSxEmSznAhKkwTm ppJtc/G9JYB5YSAWM/KCF+7Q4ZQHkOrkPlegEms2BloqbTKCJbajVRWyCmdRt/K3MzAu bUpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739525611; x=1740130411; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ouJI7+lhuUO5Y4jaomCd4wqj+zZjtecA9f0o1ku/ObU=; b=hBdvenK6aZ4k9o4jJ+m0SluQZsh53PIEqWHDybxF0R0d3KYdCl0QBpZV9fTGtEf4G7 HnUISowmdBdOTxVZB/43o+shoMJjnx88tLDzdZncOAIk75qMmDUlLyVkyCEudjjOdBOg bp4hmOCzKV8+cvKczeoiOk3gyoTDhVi043KJcKSCiZkgpfdue89rRJd+dP1UHmr0H0je midA6Udj1CvyIyDAf2RjbdQ9svwy5lT345vrANzk0oS+FjIuw4LBvSvkWtAgK6/7IrcY Rn66mesfPQcohl7gXg4X+1+wkfi9iRG65NbqrIcJs1hq88dWtmc2zRVXCBOsRDMx3Rlf P8lg== X-Forwarded-Encrypted: i=1; AJvYcCXSuhU6fwjTFhL7s3J4VaBeydGjgJetEyGjSCoq6a/52Hz/2BFOzBi+fTbbHzZZFam2X9zxWsMIlg==@kvack.org X-Gm-Message-State: AOJu0YwDb7l9iGnTPiywk+TXHJqi8Urm681D1lprvuGn4yI09gPljsXl k+OmDNmqh/QuWnfIShVzBT4TDcgyd0k0YqkyKJE2oZOb2Rnt6aCF X-Gm-Gg: ASbGnct7vCMXJ+6hgJ27r+o0mHy6WxsqepsnCK1APKiiiXhVcEegb5gbs83D7RrooKk XUdym//0oTQrEEFQwme82a689fX1sbqOzLfUzXIBcJNB6FPBuLxlSxHe7SUSNW7a0BQfjSSoehW wnRGBOABr4VTM9RJ0kZLj5Kf2B3QzmC2MkRLjbbL084h+XpSGBZnlHEZDYlmhvr1nZnilMFASNm cGqATTZiAE5HdqzzQN6Z3gpClx0wXTH7HP3dvJeZcVINc1mlAyiPU29RIXb2bHDUB8PUlmHUg+J G7hhs5t6DpOE+VwYTIGh+N248Snxpv4yap2T8Es= X-Google-Smtp-Source: AGHT+IGCGMGYkSnLBkbFtTxZW9P0kSJEuD3l5IL0wepaRidtzXfKw8D5KPLXBAJs61+ZGx7yFzk5jg== X-Received: by 2002:a05:6a00:4643:b0:725:f1e9:5334 with SMTP id d2e1a72fcca58-7323c751ab9mr12977111b3a.8.1739525611225; Fri, 14 Feb 2025 01:33:31 -0800 (PST) Received: from MacBook-Air-5.local ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-adb5a52b07asm2178575a12.53.2025.02.14.01.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 01:33:30 -0800 (PST) Date: Fri, 14 Feb 2025 18:33:22 +0900 From: "Harry (Hyeonggon) Yoo" <42.hyeyoo@gmail.com> To: Huacai Chen Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, "Rafael J . Wysocki" , Pavel Machek , linux-pm@vger.kernel.org, GONG Ruiqi , Xiu Jianfeng , stable@vger.kernel.org, Yuli Wang , Vlastimil Babka , Christoph Lameter , David Rientjes , Roman Gushchin , Pekka Enberg , Joonsoo Kim Subject: How does swsusp work with randomization features? (was: mm/slab: Initialise random_kmalloc_seed after initcalls) Message-ID: References: <20250212141648.599661-1-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 904B7180005 X-Stat-Signature: y3w3gnpjfb5coq33pc6ao3umpwqspb8w X-HE-Tag: 1739525612-643301 X-HE-Meta: U2FsdGVkX1+iZNcoYRcgyRQpxFaSr065Q8zKX0dL5YGZLLf/SDmWn7VPzG4EAc+gXDyUABiJ9BEo7dK8jSx9lbaNfhAKT4I2MUi8GJEZj3CBvPGZKYzvnnfWzIg9aiMJOlTcR16gaM1G15xD9DTVGOGg17hpkvKQqcn7yOkkkvdlOQ1i45PggZk2eaPq/R+VIndw9/7S5YUdfWp3eDZg/RpGbMpaL0Ukp7vUQiT4rZTd8yw2sL9V1V5DCgJ9fMF8bOH+MxiRUWc5sLZEDa8yHpKsYSZQjPYJRiQdZ0KIhcw8lkgEqsDKljyfnogKw+4IguON7uOFCOtweN2O0oLvX8odaZQvnb+9i/xMxAuuNbPrvQ/2EfUf1yhfFVTJTVbyGJ4m5NZzJuEjJOQIth18M8+UJ5BkQohlS9clGCw/Fy5wNKQRMnd1askME3kmWDlG+mRz23d96Oe4CzUxrmai+uduAZoFxcilc+1t7q4r7OeAoRdiLpDrpIrYPfJDgPqfnFdi5IfFUJVI/y1kxdF+rBda4YoDffeapBntzr21+UkXprTUqGavgTntEpavF+Z9VmKlD6c6nLzEIf/UIWluclxmBb1PmL4+bOCbEaBmSogVVbvIuSduludH/x8hcx8rHRgsaffF4MEKAUPdHxSyCVgg7V3Trtib7/S7mVxU1qQYwMMlZ+a6uB64Hk11h1uYlZ+jc1haknIIgGkU5KXq6faXv1700zd1g5SkQrdsWelF0d0kzlp6PHUcZwi9OQCzZ8bWWu+LXmZqFQavFc18iO+LC3UTuK90TfGysOM63b55ETpeh83Se+fcSRLFhC3Xq96q30+ZivyY4dUXHU7/BeaIVhKOwMMQpcb4/7pKGPiQ2ocTh8fNf72mvhjFQSPtdtKEAqbdR4BCYYffaVafy3i8gS5D78lynVqCcMHvucKUXiTptDkKiNy5gfeb0x9TkP6Np/W6xUeqDzjwBgb Yz1J/x5/ cNX6ftVUCLeOoobnqLA+dqzVSU+icoRICXPmTKH268QlJjV9TkePknlaLuEyguNLn0adCcaJE9/G4Ar89lwktfYJ0+GCmmRJfA5IQfiJ3rqmrL5CfxUW+TLN8ZLisd4vAgnQ2MfQZkfZelbeEeZnuoeKQqMfPeAc8wGrRC8ygnlfKbiPqg3PLLmQlZ+96wA0m+ZeFYzwVEN3FwNquA4HopkWuOV30FBU5L8M6xmouSNucp7A+xj0eAED/OmhFG5koWCgTt2DJJs1mePMmxbz+P3FePj6YshJi4ykw1UGMWxJsZCKFLCX8dEpbrc3f3k5/mARYONB3mY8/YbTojgkwh+nFtLP/36URGi+1optnP/IeXOjohI3KlgxmwbRGym/3CVfpqCgkCudA+Q5n9pN2TacZUcLQ/9q41Pqeci+hxlLwI4QxVaTSNb5VMbJuq51pq4aovqD9Tpsdsq2klgbMkd9AKW124upCLTskEwBPX4PVc6bx9MalZ2yHlaRCj5waw8Oj52pCK6YEVpw2GTyr9cTo9IVr1L7FOzkmFAbnlJvPlcFLqo6LwuXvdezQ2SCsTmih X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 13, 2025 at 11:20:22AM +0800, Huacai Chen wrote: > Hi, Harry, > > On Wed, Feb 12, 2025 at 11:39 PM Harry (Hyeonggon) Yoo > <42.hyeyoo@gmail.com> wrote: > > On Wed, Feb 12, 2025 at 11:17 PM Huacai Chen wrote: > > > > > > Hibernation assumes the memory layout after resume be the same as that > > > before sleep, but CONFIG_RANDOM_KMALLOC_CACHES breaks this assumption. > > > > Could you please elaborate what do you mean by > > hibernation assumes 'the memory layout' after resume be the same as that > > before sleep? > > > > I don't understand how updating random_kmalloc_seed breaks resuming from > > hibernation. Changing random_kmalloc_seed affects which kmalloc caches > > newly allocated objects are from, but it should not affect the objects that are > > already allocated (before hibernation). > > When resuming, the booting kernel should switch to the target kernel, > if the address of switch code (from the booting kernel) is the > effective data of the target kernel, then the switch code may be > overwritten. Hmm... I'm still missing some pieces. How is the kernel binary overwritten when slab allocations are randomized? Also, I'm not sure if it's even safe to assume that the memory layout is the same across boots. But I'm not an expert on swsusp anyway... It'd be really helpful for linux-pm folks to clarify 1) what are the (architecture-independent) assumptions are for swsusp to work, and 2) how architectures dealt with other randomization features like kASLR... > For LoongArch there is an additional problem: the regular kernel > function uses absolute address to call exception handlers, this means > the code calls to exception handlers should at the same address for > booting kernel and target kernel. -- Harry