From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E4DC021A5 for ; Thu, 13 Feb 2025 15:25:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C53446B007B; Thu, 13 Feb 2025 10:25:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C04006B0082; Thu, 13 Feb 2025 10:25:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACBC76B008A; Thu, 13 Feb 2025 10:25:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8E6556B007B for ; Thu, 13 Feb 2025 10:25:31 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E2D69B1D29 for ; Thu, 13 Feb 2025 15:25:30 +0000 (UTC) X-FDA: 83115295620.12.F2DED21 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf30.hostedemail.com (Postfix) with ESMTP id E1C3C8000C for ; Thu, 13 Feb 2025 15:25:28 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DIs7JKMt; spf=pass (imf30.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739460329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qn2aq+FZ3Hyqy2TbNenZIG+7osbs9ZE4AKyqzZGbbyw=; b=EEEnMY9lZNSQv8DzcPF4NUDDG3QrveSZjGlwuMKc6EF9kEU2bMBkgf/i7E/3Gtu8TEiTNw Vqn9XG2AecDKxwV4CWdzoG+KpRsXe4m60VZw0PpDCgYcmnWModDy+D29P7qw4MCcMW4JGu nZW7bL3BtkU8N6XYx7WdfXgnuE40bYI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DIs7JKMt; spf=pass (imf30.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739460329; a=rsa-sha256; cv=none; b=6QlatiQjhINmCsx1Z7GTUUBX+qLAWMmTUDwymCXPMcnkCvd4bCM/pH6NDQTy0tDXRBpR55 2n72/bXKZUtA5dL/1TsbVid5TTXURMyb4tRw/ZcdJEn9UPxsd2BAXUaP3GpPcDmBhsT4Wh ojSIJDMm8RbhYsEdm3XuhQ3og2QxGGg= Date: Thu, 13 Feb 2025 15:25:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739460326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qn2aq+FZ3Hyqy2TbNenZIG+7osbs9ZE4AKyqzZGbbyw=; b=DIs7JKMtT/YsgYOIQdrgvaPADhWvCup7aZLxJ2zgyVcB3izlX78OSJl+ACBmh0MhI3Rwaq BLF37xY4f/7vnNOdhOx1S9ULcX+GEW6jwj+E1oaGNOoBzcMqqHLiDHrC9Ov6cGmiKNLqpi ujNrnsjYiy/tZxWUdw/g1BtppKJAgC8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCHv4 14/17] zsmalloc: make zspage lock preemptible Message-ID: References: <6uhsj4bckhursiblkxe54azfgyqal6tq2de3lpkxw6omkised6@uylodcjruuei> <25268fbedb82a06ba0c13e2c490b164846ef508b@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E1C3C8000C X-Stat-Signature: c8ijtpytj9k4yymta17u16yh8qs37aww X-HE-Tag: 1739460328-767709 X-HE-Meta: U2FsdGVkX1/qcQREZN7/hXucn11cmGI7CqDOKiPiEGC63iy2pBWTUeFwW4d/bRMEXa0j+7DTv5+TxHTjaxdAax55WpNaZ4Shu272tH5phdqFNw8KTJq6bxANBdwaPqNF+hAPLjkWtNumuC/WlRY+RfkYTmLSADgFul9qcyELG9TSoxAYUOrbdZqu8e+t3l6wXrrP6xybIqZOk4cEYfDLZPdmVE7viFq1OwUSbDuuL/joETBKqTnH8hXxidKQuCxEx72GIhJcC4LnSa5yCt0BQyHoPSr5/mqh17XhMMP2sCKR/vMLxrgeNvb1CP561sdJhhXbvJDN4EhyAb0UUADb4n0Px3VTAGiduuercdsPRSWoanB009oqaE9EQZweT1VmbU7wZL4fclxQDukbfbvluiSVo4S4xllnCRytJWC/s2x5HzTixKquvnriz3KeKZ5TamZBpVrR1C4DVmLJM6vMLkNbd5HGvdbFNlqtuyvs90wHnoaa9Di8g2pMo0QfNHiNXl/8pmbP1fBtHa87e1S5nHFPOpwL4QN8qzJFs9zg31oA0mmLj07sA5GqdbzryeCEl41vgK7ReRKrriutnlaVbbNMNHIGQBLU7tlfoGHxNRJY8IbJHb0OZxPGmH7dKgmQvwgjmJ090pPZJBeM6wNDmnWAqy+rNu8SQIXMhOxxr7epBu/pch+m9F/Sa/Zgu1ouGXKlve1SLMECs2RIqe8hCvd1dIJ+4Hx2EgD3nE7G9f/BKop7zZHuLu2O+9Bcy7Y8PG1OzDUDYRtFkUJXhd+/KemLysShy30465nJasp86yYP3HalqNEr6b+yL4OJ4jl4nkxXF1OOTdoBSbqjHt1oNcbnSFMqnriSYMf9Uac+5FsCG5XSoKm0LdnmbiH7ln7l8JBp4AvBuqvivr5+rkX8kvsSsmxFmWYkCqeRmdf1V/3VdZeS1aGaVJ2Ps7fLjvwD3QcOVbTt4jBU4yBjdT2 YKgqUwmU xLzDtbA7fWZfT4dSyi6oPOyLEZQ78XzQi0K0+ELij24uG8orn7OlCAhDx6msra4kZRIowtrSdE6f80fBHHMuekpj57dgbF99F+QL1GS9vzaY6zVFZyST5H5s+3QHVdoTZ5DtIjTGHmJJIYw650VmfIZM1qP77BLapU+fIeiMGMpqAtKUqZTJg/UKES13enqMRVfwwXtthAR4TMzfGuCmAM315iQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003125, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 13, 2025 at 05:22:20PM +0900, Sergey Senozhatsky wrote: > On (25/02/13 16:21), Sergey Senozhatsky wrote: > > BASE > > ==== > > > > 1363.64user 157.08system 1:30.89elapsed 1673%CPU (0avgtext+0avgdata 825692maxresident)k > > > > lock stats > > > > class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg > > &pool->migrate_lock-R: 0 0 0.00 0.00 0.00 0.00 10001 702081 0.14 104.74 125571.64 0.18 > > &class->lock: 1 1 0.25 0.25 0.25 0.25 6320 840542 0.06 809.72 191214.87 0.23 > > &zspage->lock-R: 0 0 0.00 0.00 0.00 0.00 6452 664129 0.12 660.24 201888.61 0.30 > > &zram->table[index].lock: 0 0 0.00 0.00 0.00 0.00 1716362 3096466 0.07 811.10 365551.24 0.12 > > &zstrm->lock: 0 0 0.00 0.00 0.00 0.00 0 664129 1.68 1004.80 14853571.32 22.37 > > > > PATCHED > > ======= > > > > 1366.50user 154.89system 1:30.33elapsed 1684%CPU (0avgtext+0avgdata 825692maxresident)k > > > > lock stats > > > > class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg > > &pool->lock#3-R: 0 0 0.00 0.00 0.00 0.00 3648 701979 0.12 44.09 107333.02 0.15 > > &class->lock: 0 0 0.00 0.00 0.00 0.00 5038 840434 0.06 1245.90 211814.60 0.25 > > zsmalloc-page-R: 0 0 0.00 0.00 0.00 0.00 0 664078 0.05 699.35 236641.75 0.36 > > zram-entry->lock: 0 0 0.00 0.00 0.00 0.00 0 3098328 0.06 2987.02 313339.11 0.10 > > &per_cpu_ptr(comp->stream, cpu)->lock: 0 0 0.00 0.00 0.00 0.00 23 664078 1.77 7071.30 14838397.61 22.34 > > So... > > I added lock-stat handling to zspage->lock and to zram (in zram it's only > trylock that we can track, but it doesn't really bother me). I also > renamed zsmalloc-page-R to old zspage->lock-R and zram-entry->lock to > old zram->table[index].lock, just in case if anyone cares. > > Now bounces stats for zspage->lock and zram->table[index].lock look > pretty much like in BASE case. > > PATCHED > ======= > > class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg > &pool->lock#3-R: 0 0 0.00 0.00 0.00 0.00 2702 703841 0.22 873.90 197110.49 0.28 > &class->lock: 0 0 0.00 0.00 0.00 0.00 4590 842336 0.10 3329.63 256595.70 0.30 > zspage->lock-R: 0 0 0.00 0.00 0.00 0.00 4750 665011 0.08 3360.60 258402.21 0.39 > zram->table[index].lock: 0 0 0.00 0.00 0.00 0.00 1722291 3099346 0.12 6943.09 721282.34 0.23 > &per_cpu_ptr(comp->stream, cpu)->lock: 0 0 0.00 0.00 0.00 0.00 23 665011 2.84 7062.18 14896206.16 22.40 > holdtime-max and holdtime-total are higher in the patched kernel. Not sure if this is just an artifact of lock holders being preemtible.