From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A08CC0219D for ; Thu, 13 Feb 2025 10:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C51F6B007B; Thu, 13 Feb 2025 05:11:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 674C76B0083; Thu, 13 Feb 2025 05:11:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 515726B0085; Thu, 13 Feb 2025 05:11:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2D9366B007B for ; Thu, 13 Feb 2025 05:11:15 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 44DE51A0918 for ; Thu, 13 Feb 2025 10:11:14 +0000 (UTC) X-FDA: 83114503668.02.5DCBDB5 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf25.hostedemail.com (Postfix) with ESMTP id 05358A0012 for ; Thu, 13 Feb 2025 10:11:11 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QZaxwkOd; spf=pass (imf25.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739441472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U74TuyLY5AFY92KaNCGYKAz8R/LTgsX6KqtfSKDyU1o=; b=3MY3JTsK7MPY3/HTRYeAzQhh5BsHSE+8ZKVM7/5zQCCqL5hv8RXrERr8iMEbZhVomfG86V TZNU2NbL8QnA9OXULcs04gGQMVDPigP1odzPSCa9zZWpCaFvPKh6qrvybTrRzvFISFhuQu 7XKUm0sliVi1nY77h0zC9PC2TLdfLlQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QZaxwkOd; spf=pass (imf25.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739441472; a=rsa-sha256; cv=none; b=PmWYuJObhS+LQ3lnxYJYUfb0u5Vjmdn+RfTCiSng6i6YHnFXyWd3i95f7MtYKC/45R7hMx PbymhgtPkeV7iEsS5n0FJz+6iqHoQfQSkneF67/rTvEUrOH9XRybLtupHzMwJyORouL4p3 BtigU3CFssRcHd58aX9nPtWb4c7cP3k= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51D9muVw015181; Thu, 13 Feb 2025 10:11:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=U74TuyLY5AFY92KaNCGYKAz8R/LTgs X6KqtfSKDyU1o=; b=QZaxwkOdw85j9Se0f9lFoCNeL1+646+DW0iQ9bHd+2mPPY vWqtGD5BwxqpUxMC3zkNQG6+jdpgq0sEH4netftKyNmLYF0AqjSGG8qSZ1uAFMTf yYXJ5vd/nCGKCSPisjrpkrFa0t2CwNoxqPFCh7cV7LL5zruKqtMA4JsEmSnKfsRY VTrm8bvV8FxOrbK2QH9DJayp8jbFWDM0VNbQomc6h+4HG9plUjyeurYGWWSbm1tE bfk5w58yHm3q+rgUy2LAQrlvjBR3KWyb4ONn6eNv8aFpEN6WObqjisa6wVZUQEd7 CIOdoMIDAihTrxKz55PhvnQ4yqut5eE0CtRRkelw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44rxfu4u9a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2025 10:11:10 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 51DABAlR007340; Thu, 13 Feb 2025 10:11:10 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44rxfu4u99-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2025 10:11:10 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 51D7LWPQ001358; Thu, 13 Feb 2025 10:11:09 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 44pjkndpd5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2025 10:11:09 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 51DAB5CT29753996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Feb 2025 10:11:05 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B348E2004E; Thu, 13 Feb 2025 10:11:05 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA4E820065; Thu, 13 Feb 2025 10:11:04 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.6.230]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 13 Feb 2025 10:11:04 +0000 (GMT) Date: Thu, 13 Feb 2025 11:11:03 +0100 From: Alexander Gordeev To: Frank van der Linden Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev, Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org Subject: Re: [PATCH v2 03/28] mm/cma: introduce cma_intersects function Message-ID: References: <20250129224157.2046079-1-fvdl@google.com> <20250129224157.2046079-4-fvdl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250129224157.2046079-4-fvdl@google.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 4-Nzm_kfKbiYH4HhdkDWG-rtcGAVd8YX X-Proofpoint-GUID: Vzn0MMqmK8Lalyo1VKVejFWob49y7KWE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-13_03,2025-02-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 clxscore=1011 adultscore=0 mlxlogscore=491 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502130076 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 05358A0012 X-Stat-Signature: hxibygqziqj4meycnc3k3urckbheyma4 X-Rspam-User: X-HE-Tag: 1739441471-286732 X-HE-Meta: U2FsdGVkX18PugXVr+JnHRkDGNdxpjccUldQyqvlQFyugbu+iXPBu6/0+b6deC1r2EwOBw6LcIH7LpL5+Ht5B81EXBYXVwGTvbFIG5tHo0NjCygdpd3JxUrp8XwGorVlBqqvDHobPcUHWMPAGAYlAler8I0CnCaA6NCNqxqIlLZaAG6l/1556BdFlSvC2VvC+Tn2bYB74DAqp2+mBJ3BmICG4PxdzbqhjYCssW/mSmWOBkzPU2uHeaDSAD3WQt6I08KbNPjcN/7FL22qG60iyr/O8f8SsEkAi8ED6TG4T0U5W+9GVOxInwdGwWeiFAIobdQCEJIXeTsQ1WRtDv0jfc91Ow/eoEgcfXTrGGsGJWpWOirxhkuf44fpoiPM+dmWMX4TA+t+jPdQ0aW8Jy0srMcCR4qQf9jg87zyBepst1GQuogNwZti7bgZ9oqRkfN1x+7lRr+daPKVFzEx0MycEiChDHSfU37jYQSaMGJ7pznagNXHlYrBjFVpZi7vuYnFF51UNwemnihFl9uBS3e2yUfGhnh5rrJazS0OR8PRagCV2PPiKfwDWwZcCupuu4WGNKeXiXfhZFu/78rj0GFi3tLYvbZGZJZAdiFj1BZYO9a6KdXrzoXgYrGN43yfK7Cnc00FDAhifM/LMznbc7vuO56YZsDL12A3J+qB7x7g1oUbf/Fog5/tAm0CsuX8esOAZjUw4VbqipwjEIjCaoRFIB5ctu3p9iJrqsovwaA7ww3cLZJkiK2j1e2ti8opQEuOrSZqQ0mdQwOSzN3jAEhu+cAEmzzO69nGm4Ljn1nIr/0BkBPVv4Bssb0UEkpQqEu9neAPWVzDUCuwdPYzQ3UHf8/k35OziDmO0a1kNAv0ebtWtgaAcEp/YcAojqiqvSt5hSumGXWUF5ivtcJvz8D4JaustJ8AfxM8jVZLJm9Ptk2dt/Q35s3mFpMbF90fZc8mU/GuRojpolBZt21/Obc s5eDdu2Q oTmFnWUCARPsAbXkONk2k+AfLiMesZIqFGWgKNRQ1qkOGsAWkVodD8jfVQfnSqvLsws+2ITAmWkS0ekeX3OigqdIz1NoGjS6AcQBTZ0i0EFQMUlOrTvVncBJgGuzgnnUCvZ2LnyDYxqjGwj8ez6mbykLwpc/+AwPiu6nmakxyU8tHO2hcBzok4Kr+6TSdMv88I21qC5uDKya+yp5R5mxPEcgOW4suv6aV2z7yCUX9S4RU+GWQ4N74gX/81NHRzRFhttlqF26Ynvrr18RdNm5KgLEXeroxteqZlN9OFLOQytBS0fJvTOKMePvPoPbEglueBwxvrBY5IwjJmKJxCcYcMveT92YjzskxWiqv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 10:41:32PM +0000, Frank van der Linden wrote: > Now that CMA areas can have multiple physical ranges, > code can't assume a CMA struct represents a base_pfn > plus a size, as returned from cma_get_base. > > Most cases are ok though, since they all explicitly > refer to CMA areas that were created using existing > interfaces (cma_declare_contiguous_nid or > cma_init_reserved_mem), which guarantees they have just > one physical range. > > An exception is the s390 code, which walks all CMA > ranges to see if they intersect with a range of memory > that is about to be hotremoved. So, in the future, > it might run in to multi-range areas. To keep this check > working, define a cma_intersects function. This just checks > if a physaddr range intersects any of the ranges. > Use it in the s390 check. > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: linux-s390@vger.kernel.org > Signed-off-by: Frank van der Linden > --- > arch/s390/mm/init.c | 13 +++++-------- > include/linux/cma.h | 1 + > mm/cma.c | 21 +++++++++++++++++++++ > 3 files changed, 27 insertions(+), 8 deletions(-) Acked-by: Alexander Gordeev