From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3589C021A7 for ; Thu, 13 Feb 2025 06:30:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DACD280003; Thu, 13 Feb 2025 01:30:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 489A3280001; Thu, 13 Feb 2025 01:30:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3780C280003; Thu, 13 Feb 2025 01:30:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1AC12280001 for ; Thu, 13 Feb 2025 01:30:10 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B783B80605 for ; Thu, 13 Feb 2025 06:30:09 +0000 (UTC) X-FDA: 83113946538.19.FBF739A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 277C8140008 for ; Thu, 13 Feb 2025 06:30:08 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DELBrdaj; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739428208; a=rsa-sha256; cv=none; b=honpdGGDzVOchFZl3gta9V/uONzxvmnkCU8phuNx86N/j4wcxolSrMpUAVC8SF36Jovfgl 5hkUjEB1h5RFerTZ66I1DsAMbqcUDKXbRMh+aasw0Iz3Nsj4u/01zF4vqht4OUSd8tWDCu C5jlvvvO833kYPQOoIGqIjWKb2tc6vw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DELBrdaj; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739428208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fnVKjV/1m3bh0wtCPLG9Y4g+Ip7U+VlaTj0Rur0o/BU=; b=1Bo2hfxrq593B59IWasU2OGINuBJycBvhQtoZXWAz1/Mc0x+bXBj2+0F8MNAu+eKgN8GHL odCR5TUFc+B+PUiWm1ZgXaPzQlvbFxVuZMAUKaQxL33ALsIMk4LSjaEBZ2ZL9UNtQ5Y1mS ryIXmjjXn8XZhFpU882s84kPmiLoJck= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0BE23A41E21; Thu, 13 Feb 2025 06:28:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7A89C4CEE4; Thu, 13 Feb 2025 06:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739428207; bh=BDTEbTXqj0IEjXAWZlAO+MGqcZ7esoewjgwdPbfzNRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DELBrdajUNBEWexP/DpuiI/laBtWAKjQ5lng240QLcwCcAl0b+jb39wCGwbw4CG1t 5xtslMvrK1sdYYfxsqack9GPZQz/uRRz9A/WBO5T4ttaCHmKMO4U+o6pOCCsmHCjp4 dw/s4gUI6QMOx0Qbu8jcg2nM1E8rd17hhSQhU1Cp64iNBUlydwcmwl4dvNeZHWFhYy onVtXlelDWsmg7arW0/Ivr/G4RNlpoTRNYFL0FcWs21P0O7SHcIWXXuSgMMBR11M78 8uXvrEm/kaP/dMXWNoXt8m0zlqIY0YZAY10pY9pusaivFnM5AXWWw0dj8o6aexZZe2 Xhf52XBsAUhQw== Date: Thu, 13 Feb 2025 08:29:57 +0200 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: use round_up() to align movable range Message-ID: References: <20250207100453.9989-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250207100453.9989-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 277C8140008 X-Rspamd-Server: rspam12 X-Stat-Signature: pwaa9bkmcdq4qphnrb4yeu75rocmbsyo X-HE-Tag: 1739428208-885515 X-HE-Meta: U2FsdGVkX18DdujrrCwlJF9cGUfwjeLeuTLOS8kLJ//HCK6+3bUguwx2Zi22MKnimuP65GkBNyddJhJvO8WxbyPNLxPCZ1eOmh7QoCUfuAFyf649+s0O7FVF1JSgokiPwpHDRQROhHXD5qK9j2OlyhIXGFHWLpUbo0KqUC61F85PbtdrdMcA8FSCqIrfRcmR1BLhfFRRW28LHAUVGp4E8/6XevtMrLiSiQx3IQrH1dJYDKZdPO1hP8297C3kkePEbjFGHglF8ow4ogA0GZB2R3vCC9jnZfCD03vcE68wAxo/xKmsLx/G+oP1CE6dO3iAxNnLAg7cCqgxHNpwmcpP25UDv5uFYbkJGUjgAmRXU1M4wxUlPA6aNqmBBk6fQnyNvseaw/ghgaoika+EJahv5PG40mQWPn/TtbKIlXSZ5LtWvos7WtFyktbOc+4esbhNgTFzyWU7Ej+bPjTX2LE7gXoFQcuCECBzeos8+vV2TB2WjWM6th4zzQL/2MKVSwuMHipJ+XmQ8AwGdTcArZP5IXwt/mocwsRFJ+c5qLZON045IN7kCv80FfTum1OlBbxykT4HsbdLlTW3rszLuAJBAGG6Y0MWGNHL3BTeqMh5tNU9kcEi0TugEWso+Y9UKhNaZ/Z/W0xzc/HjZ1yxTj8kIVMMKuBDNjcXaLDkstuAobjgW7XpwaUH23QYJXP5G2odm3gBva/VTDNHTxadquZKVBnj2pxBDpnV1ErRQhqI0RghdKltog0x2dBlgDsOqCVie3SlVbTCJiT/jkhH4XvnpHRbxn6eYjEqzFV0q/k15FO1XbDuI5lgLwuDOjuBeTEUT0G76sRyG6smhkCRIcrzozORGc+/kYEZzT4FunjtCHMYbbZpq3xcH0VN8lGf6SumJ2Fg/YnsZXxVnR3NVUS+2lFeWf1DxE3SEMB2r2+4PCwUXIShYJI0PQzwQlEscs2+4KAKMR/ygzrus6gxjso +7MaHDYE od8I0tHMgooqrFGwWBxnOO0DH9QFJtqVWYr5VYgHyDSdRnQTL4qrA8m/I2Dj9MxJVBmmxhhhRqNxX0lBUx+z7koJiyZxebgK72NMEe2qx7aolhZNVDHa4zji4zQL0Uanx5Rd9666+16SARGFHzS5aAU5Xzv6YrAxkMxOVXfqUWqAdnczNQvlP8QH4CQ4+Dcv/RXruhsui0K6kylzn0nsLT+fh18SkbDqll07Not/XZJjvkAeIxb5FSzAtRmL7ZkGVCHo4tWM7sgFOXtgBUssscr/BNolFpHx/8HFVQfIKDamo8OojM4rB37wvU4pQe1C6TG2ltl3qrei+AuKzzMaILCfejYE8meng+OKbIZH4TBASiBzOh180fOG0yg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 07, 2025 at 10:04:53AM +0000, Wei Yang wrote: > Since MAX_ORDER_NR_PAGES is power of 2, let's use a faster version. > > Signed-off-by: Wei Yang Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/mm_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index dec4084fe15a..99ef70a8b63c 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -438,7 +438,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > * was requested by the user > */ > required_movablecore = > - roundup(required_movablecore, MAX_ORDER_NR_PAGES); > + round_up(required_movablecore, MAX_ORDER_NR_PAGES); > required_movablecore = min(totalpages, required_movablecore); > corepages = totalpages - required_movablecore; > > @@ -549,7 +549,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > unsigned long start_pfn, end_pfn; > > zone_movable_pfn[nid] = > - roundup(zone_movable_pfn[nid], MAX_ORDER_NR_PAGES); > + round_up(zone_movable_pfn[nid], MAX_ORDER_NR_PAGES); > > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > if (zone_movable_pfn[nid] >= end_pfn) > -- > 2.34.1 > -- Sincerely yours, Mike.