From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22C9C021A7 for ; Thu, 13 Feb 2025 06:32:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A7F6B0095; Thu, 13 Feb 2025 01:32:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74A866B0096; Thu, 13 Feb 2025 01:32:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639CD6B0098; Thu, 13 Feb 2025 01:32:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 432E26B0095 for ; Thu, 13 Feb 2025 01:32:32 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 01A21160640 for ; Thu, 13 Feb 2025 06:32:31 +0000 (UTC) X-FDA: 83113952544.22.EA0CD3C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 706878000C for ; Thu, 13 Feb 2025 06:32:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OYsuEnrq; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739428350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Go52u/tTpzKWi5MFEStRrdWMa7hsrvao46Do1vPPiEk=; b=cY7qbNF4UNxwaqhxHMr8HVmkqI9PhMtTg3KT2ru3+fBcPrk4pG5WtsWHeeNvcc+5knoP+2 ZH6+w9MwgNCZ110Mp503/uvvLC/FxJKNuyPQkmjdRvBoagZvRPg7cDrjFiohnAy6QOhVgy zjjsoPhU+COao9doJNoHt+nZlpR4Z9A= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OYsuEnrq; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739428350; a=rsa-sha256; cv=none; b=FTpgXQI9JHBFpvBEbAAeZ2+uKMWgwObCvYGEGuSXLEvJCFyGRbeAvZzQMb+I5vyEjYAUql VImnqoqEv3xoyflYJzC3EFlXkK1gGCYY2XIQr5qCX3FeIBBjHMnl4d8ev1AJKpQTNizO3U I7ILjx9XqPuS0ykxGraXQsiyofpXbtQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7CAB4A41DBD; Thu, 13 Feb 2025 06:30:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E297FC4CED1; Thu, 13 Feb 2025 06:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739428349; bh=ihfzGnLeol9hv3yyW5QQCV+d0oNNMphLzq1zoxAoIC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OYsuEnrqtAUZZ17DEAkny0NHF32a6YIkNi2S+RJGIgBid1py9iN6PPhMTpCkkNN5t 6yYKvRq6HpXT6zxtM9QW7xVSzQVc4I1co0wkcBYHKLMVOP7zzMMXN4Ej8pP6cG1m01 +7aStrOugLja/wUmA+hGxjX72WOxQwFYgnczcbzsPTk3mclfTqk7kE58jTRyEwjoGf 3nNlUlBqdGHP5HbcLibl0nb7eFIE10d/crW6OMwc4N/PuOV1aPE+CztkBtimtcDORA GmafXfRAJJ9CZqOQe7jicB+bpB8IWGIGq8jxBLaF5zyGXPeRy7TkIIyU+Krb6ErTsW A5c5SqR3jUxbQ== Date: Thu, 13 Feb 2025 08:32:19 +0200 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, shivankg@amd.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: use round_up() to calculate usermap size Message-ID: References: <20250212013818.873-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212013818.873-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 706878000C X-Stat-Signature: nxoh3ompe6b7dc7tbi6xefibzoh47bw1 X-HE-Tag: 1739428350-689407 X-HE-Meta: U2FsdGVkX19f4cHLLsY+knkgyC//J7eQKOdaiXet0SpJ6KJLDp8I2ees0GbWflYCP2CI8/0A5ooDVbGVdRGKc+g/ATv8bPNzzPIi3uhchyQq5cvBF5NQ7sWKvBSWAQPyBI3RH1sQbBgUXPmIhKhhLoDIf9BOVlB4Db8cOexh6tuoB/JZhO3WgMuEksuCwoRjZJtdGBLf3dW8vgba2gH0OKHtMVHpdE9k5AIPtQ6ObIqHFXss8uUwMq+m6/nHWN9EOJygOl4/OQtqHSZhI7eETyHLfQhB6SQ2QbzQyh552GpTuKVAy0kWYkCpX8cmcl4EEgc00CO2XZ7qt+j1u5rOswTH5XPK8hwauKIo5J271ktu3WRZruEZ8nDlL6/oD5h6HFHmqLdHaoPjltNL2mhOIv1x3tJOT5r2Xe4qaddD3uMVLwbMXZ/VSOkO6JA8rI7MWuiOO16x7od0mi2/pygGfpNP9xJKtU152G0X8gzPO+cLpQ+bcHrJmUjtyOqfAGniOrbPhGqPhAkKURJ4VFB+yynkaiWOMoL2LdNfdmyRSoNJqUw/VSV1VVOGrX6tNsYusC+4+01yOHolfeJnijUuXRocFsAj62yGWvqynzY3M6L9eMA+qBWThvdS+gW81UxhE4hxrkKrzKZGyl/JZvQrJ0imMiXF/+F5mhYjQ6RLakUh4+x9HW8HvsnxRtEXX+fVshlFNnWV1MHieTLxWxZhMqJsiTC0MEb7fX9kiQy6ugQbau8nnCV3fZVGAbMqpXjCBoZOPFP7o/WaIgoLFLUkICeKPIK1+frqWs/xdv9fIsY1OAln4m9QcCS76Akcs3YoGLXUcnlrpG3JPCh2K4z0Qi9GmezLjWFLhZ2odaLxbhZNjfHieFqigYwIa+p8mnESXrBQKXv0ijbIEYi5O0qbuXvDOPnyZE5Wm4VejeUyu0PaVahMtOmYkqDFXSC9kBRZNUazEXfi+rmt2vviCEG NuRK+bT6 vf35Fo0n3oupJ3R8WM7nnKJ4OIbM8gK5yf9/HYk4fWd93msJTr5CnBQwjQ6X4Aw7lQOLDOppQ1SdLR3ASE1wo6Fib6x8zfZkgYKDALoDwd7I9KUhTWw5hjS3MwDv+4HMvBdJ+Z6FskWG3GuTI8ZFUH9oc5gBV90Ly2uh4KQPFMIqG0b3Lp35nK27Bo4rJ/RoE3hhngUwXjEed8qMib9ALvde0HeN3IbHKINoA2o0M11Y7txfkyT1Dp1inGCYxXEUD7LSPw6Jgih3cFeg8tXmQE4vghhS9bHyf2o/GC0w7inqt80zteRsNx7osXG29u8Y/YWhtaSS7/CIPHJveOdQEo9bshgz4hL0HybXBQ6bcTRPHV+LXr7rNkUFqB7+vvVlyeMS1oD77cRFiz7oisQSuNkvpGyf6sYnQtToCUDu/3pxmdeBRebSlZ829yX/M55qcmHxF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 01:38:18AM +0000, Wei Yang wrote: > Since pageblock_nr_pages and BITS_PER_LONG are power of 2, we could use > round_up() to calculate it. > > Also we have renamed blockflags to pageblock_flags, adjust the comment > accordingly. > > Signed-off-by: Wei Yang > Suggested-by: Shivank Garg Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/mm_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 3ec50b5fda12..550d5ae98cfd 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1459,7 +1459,7 @@ void __meminit init_currently_empty_zone(struct zone *zone, > > #ifndef CONFIG_SPARSEMEM > /* > - * Calculate the size of the zone->blockflags rounded to an unsigned long > + * Calculate the size of the zone->pageblock_flags rounded to an unsigned long > * Start by making sure zonesize is a multiple of pageblock_order by rounding > * up. Then use 1 NR_PAGEBLOCK_BITS worth of bits per pageblock, finally > * round what is now in bits to nearest long in bits, then return it in > @@ -1470,10 +1470,10 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > unsigned long usemapsize; > > zonesize += zone_start_pfn & (pageblock_nr_pages-1); > - usemapsize = roundup(zonesize, pageblock_nr_pages); > + usemapsize = round_up(zonesize, pageblock_nr_pages); > usemapsize = usemapsize >> pageblock_order; > usemapsize *= NR_PAGEBLOCK_BITS; > - usemapsize = roundup(usemapsize, BITS_PER_LONG); > + usemapsize = round_up(usemapsize, BITS_PER_LONG); > > return usemapsize / BITS_PER_BYTE; > } > -- > 2.34.1 > -- Sincerely yours, Mike.