From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6554BC021A5 for ; Thu, 13 Feb 2025 06:32:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACE766B0093; Thu, 13 Feb 2025 01:32:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5800280007; Thu, 13 Feb 2025 01:32:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94660280001; Thu, 13 Feb 2025 01:32:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 761E36B0093 for ; Thu, 13 Feb 2025 01:32:03 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1FF60120693 for ; Thu, 13 Feb 2025 06:32:03 +0000 (UTC) X-FDA: 83113951326.07.0BAC6C6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 83F2AA000A for ; Thu, 13 Feb 2025 06:32:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cBeUl7E8; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739428321; a=rsa-sha256; cv=none; b=R/D/zihRj+nTcDHZ7UN3iEMdOMtl9mbSAKHKCOrpGXxI/4bH3kvdzJ2mkq/ODh8g++iTDH vTL7KaCst2w/GxA6gk/v0IzFyBCCRSbkdNWTaYGnI1FeDewCzl0uyt0NL8rjJ4/3y9Brja Ah6nEqQQt7w6UxvUa72cMfytaAXV7Bk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cBeUl7E8; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739428321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/PEaML03qgboy3aiuV6tWbREJXpWURB4ylAfJyDnDFc=; b=W01qu6i396tvRRlUTyWsj6N2nJhCI3CyQ19hIHisd6bXylWYRPXKurolJuAfIZwMlOkFOC q24OUmnOiuJ7cA7ir0WWjl7zbKyjvA14zLCGkbcbdASnTvrKEtubRhmTXjVJ578RYbX5b2 1PoVa4/SGDy90y/iP/OnYSagPrQi1h0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 059355C01C7; Thu, 13 Feb 2025 06:31:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9428C4CED1; Thu, 13 Feb 2025 06:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739428320; bh=7c3D0JQUZ3H0ERxaBdcWxbOwxoTv++swgaw8d6+vMhI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cBeUl7E8vdoKEUWe3TLh+JovzVQxr/ZrvZUCYIO7FMnOD3YxZp6z60FIcLMcv6vBY lwJ2Vnifx5TC1LBI9iLRbIAHVMh2zTZtKr3ok9NT/DSR4YWhFbSwBTwgkSuacCtEK+ bxRT7De7tw/71c8RCFXYIj/lqFZN5KoM5nrSRXQ+u1hBE2q0OenF/vK2sKHT5hOL31 XduU8dcFZf4WzhB5/4dIyu5J/5xeb03mR+Ao+tSIZ/m/CkT3YvQdVvtnWVdI1o8Ena 3MMxVg7ouzkqrShLENgeQxt2RhfOtoHvZJ4QdvlP+UEZ3MCGHzlv515t846WDBfYhW NEqZrgIu+5Qcg== Date: Thu, 13 Feb 2025 08:31:50 +0200 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/mm_init.c: only align start of ZONE_MOVALBE on nodes with memory Message-ID: References: <20250211082900.10877-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250211082900.10877-1-richard.weiyang@gmail.com> X-Stat-Signature: qf947y586aztdc885wa6ks4edkh8h5ny X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 83F2AA000A X-Rspam-User: X-HE-Tag: 1739428321-670305 X-HE-Meta: U2FsdGVkX19HGBnh0ycnbaFFxp+859/QwY5aySflhMb/FpWKfAKUlrDmPr03zVv04RjY3MEWxG5AcPHi1EwMt7N7N83yD5bMUBBpAh1x7DmsITFVZsq+zYu6naFXAFruJfxVv2VhWNTYnXRN2+fuFpPFTBlFXc8GIsprlaQlOs4VzCt2o4Jlvx+z+chybk53cUjnr/WqIB3NqlR0TtOLk1kh9qZUquQwfI5PSZIGFlHbftAa/8HhRguchBJeyQ1Omaw9+aM0giUJuW2gEbv+I2myUJBvBdicq7Aj4L9NtQKXl7/E4ry6i1Pi91hxsW/Q3rpI2CdVTmnOefPr7KwQyz0x7CUyTag40BPTnjEWJF3PQxYEdvyrQOEvO/Di6BqpdYAV5c/Yiqj7Zi+9QICDMsqEj2JR7W/SN12lU2AwYjdnxDW0u0ScZM7e+cGox5PC0JJsocEOgPzMdiyxDiKGC+aSHrCBNiJPHeUlAEcaCuQmDOBI+M6dXoe4SsCP2GrpIqjMMEHvryjZ4y6yfxCvOpcdhdxiiFbCmbcNOCYYGgammy64rnSHMiM4T0t+5prS89pXpPi3H97IoZk8242Fubv7wRwwXG9LVyyoKDk7TQQXWJsSr51bn2i5ne68k3KQlWjT5hWjw5/vN+uMul90vYYkzyDKC4xas8TikXWXroiL0JWJdAWWYn6OtxXZgG+fKkDwp7M2JUnTr7IsGsr10Mk6KQcslz0OikXVGyWo6SxufZ3i/2c/0tmqzroZMEx0/3ovj+1vgSp8mytAtAq8vX3pC9GnuyHM3hngHMTTmvDrQokRcrZGpkzoziJLKNvR6teK+zZyRyjPSFE5C0XTSIfUbqTxE5oNeTK4iT+n5vU6hO0fzmYhv/HT05O6H2XtE+1lyNn02Gyx6qTAMctSIacMdDXJzNqYakS13oGmxzRZ4OUzz+nCZnoofssva2gvmpN9L5oZrbS+AD5MaSo 3S2W44r1 yOUq5id8kKuonKPvUWDvhrB1XrXOF72eDWC6I9c/agr7g+Jxpb7UJxZJfw4NkUIQURuj/sN+rEq81c/Q0mQI7GKb1fSdC5ttzgZXvHq68B9LCwCksI49O+Vr7PnqyXbG6GVmPYI1y3VanJ4ujCL3woCnH1EMFhW8wXmCnFLjpPbG22q5aLTDJSGxKDq0FnlAuQBw9eQF4bAqgw/h/uqzjGo355O54i5WmxnIt6jqSfDHKy0i0yPEWLc2r6xa8YLU3IX1T6K4p0FU6A2S6/1r1tr+lJD1auzS6lNsgmZqQdwhQ3ZMKoVaUsC40CXKC9IAbfWT5rE8hxXErBnTNplEKUZrTdYi/NpqnMCqeg9oJH9e7zs9ZP4nb+AfKzfieKPqY4/IH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 11, 2025 at 08:29:00AM +0000, Wei Yang wrote: > At the beginning of find_zone_movable_pfns_for_nodes(), it has properly > set node_states[N_MEMORY] in early_calculate_totalpages(). > > Instead of iterate on all possible nodes, we can just do the alignment > on nodes with memory. > > Signed-off-by: Wei Yang Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/mm_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 35754a8ae6c0..3ec50b5fda12 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -547,7 +547,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > > out2: > /* Align start of ZONE_MOVABLE on all nids to MAX_ORDER_NR_PAGES */ > - for (nid = 0; nid < MAX_NUMNODES; nid++) { > + for_each_node_state(nid, N_MEMORY) { > unsigned long start_pfn, end_pfn; > > zone_movable_pfn[nid] = > -- > 2.34.1 > -- Sincerely yours, Mike.