From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E24C02198 for ; Fri, 14 Feb 2025 20:13:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94A81280002; Fri, 14 Feb 2025 15:13:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FA93280001; Fri, 14 Feb 2025 15:13:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C198280002; Fri, 14 Feb 2025 15:13:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5C308280001 for ; Fri, 14 Feb 2025 15:13:53 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 097ED1609DE for ; Fri, 14 Feb 2025 20:13:53 +0000 (UTC) X-FDA: 83119651146.19.DE6A753 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 4CD6F1A0003 for ; Fri, 14 Feb 2025 20:13:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rXv0vaa5; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739564031; a=rsa-sha256; cv=none; b=3+a265FJ/u/5na8adaKK0P3UhQpl4UzCX3KSw6tBdUr4XoViZsMfakT0UDpBf2GCerNMLl wdVe40Zt9j8S7rwNkHvhTvxyuN/vk2ZVzj8+wqFyBC7AQ0q75sUTmo3iCclyvzf/yse+du Os4HdYQ4q/boDFkWxxQWNyUkoj8g5xE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rXv0vaa5; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739564031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fVBh7aaxMWrgdPSRhNEUp6jby7sv5vPC7kuSsBAFoKo=; b=CE+nNFaiSsH98yYkSslA++jCwhyuO70Bwe7x54c/hs5sEcT11J2JGYEzVpPT8AokQLLciB 5UVMQlGzQZhiS0QZ/Hh2RVbMwuk3DTNKesWtTXEVuQ2hifJb0m3A+xX+e9zcF/q5+QqZoQ sI6TXZdmkZlncHN4gbQR6tcYmBMvm2M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fVBh7aaxMWrgdPSRhNEUp6jby7sv5vPC7kuSsBAFoKo=; b=rXv0vaa54mCblIpaapXigfgfw0 41pAAYZSHcUBiYziL6XmjiawVrMCkvCDnhF3+uHPURZKvrqyDxeP439DBjJl3Ky4C92EQIEVGLAVU VQZcI0k6puXOTRH9Fzsk2crQ8SYp6BmBeB55MgQpCtUS5u8NTALpN0z+pCXddgI8/lKuKVYVxIjby 2ew+8Bo7j7lj6jjn+fTLGKwti7RKK9L0Kod5D1ltwDamFQEfxqDyuikQcPRof4SCqnKgpZvlebwNe m5j5AFRmPWW058UoPMNhXFFGIgH1Di26Qy3IwqlxeYTfV94ZmWCiNHEweF9WhuHZ5c0Wo+hjCpHTZ JjtxbjtA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tj24F-0000000Bzz5-0gH6; Fri, 14 Feb 2025 20:13:43 +0000 Date: Fri, 14 Feb 2025 20:13:43 +0000 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Barry Song , Hugh Dickins , Yosry Ahmed , "Huang, Ying" , Baoquan He , Nhat Pham , Johannes Weiner , Kalesh Singh , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] mm, swap: simplify folio swap allocation Message-ID: References: <20250214175709.76029-1-ryncsn@gmail.com> <20250214175709.76029-8-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250214175709.76029-8-ryncsn@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 4CD6F1A0003 X-Rspamd-Server: rspam12 X-Stat-Signature: ai5hjb5h748i6iycjwxigrsj8k7ie9p1 X-HE-Tag: 1739564031-394026 X-HE-Meta: U2FsdGVkX1+q2vNFYOKlbSykfHgTVFbp30+Sje+br3/LqKISgVQo+CujtKNW3CMGna+424T3Q1vz7smVnL69PADyc/5ZB5CosYDTnK1GoeJF1j+shaxVUoSNsrXyoc1Wb+vsYxYhUN/IEhTVjZpbrqtIRoWB/oBdoDbE1uqlCPxYG+UXxRpi1VVuoM6/UUD8uSPLXIlO+txBDg4cDIPY0HZO3iDlrcuiSoY42K1VyuwWEHCVFYFJDrM1N/tqxQE/36HKTraVoSdTu/B9w/TmhYbn2IhSlrmDUeGEVKkTGT+k5khX5R2YaXt/FT2XDx8GnIAfZn0BNmk15RW5Cd70OJTc50x9ymyUcN/2EBpmy4CKJr16HzIXUk1cwD1OcQrWWxTDtfPPFvvorekXZOeM/aTHqv+iRNX7tpYIGsvh1he1S7ZO6IvqGdhCziVARfUZQrKT8U7fjknnU4fR8KalifBtwrWATdANFl+D2o+tIi9OAKk6utjxMF8yUzfYQ4ux4JpbZcShh1/B/d8T4U8BcqNCcFRX/PsiTX6Qa9nS/3xu8BwM62Z9R0kL+hxF80gE0lE7kTondQJLuusPuKgz38OW226o/9FDjOZUvxIXZXdTYruMUNwkxN0ptzkcUMFuPv61/qAdkRYyETJWV5AdBetL28VI/TFARDURUdm2/LwfxHTIb/vR6ePHmaFjbgTcR0C45wqBi/84i54wxW+P03gL1wjynaAJ9sI3yZtwVBjqSFYbNoT+6Ah/fAP9z5ZBeJO7o+HLLQYemhg0c7M+UglB9sUSsFhhv/JUNc5g89f8lGJAPxtSfROWUrF42nCFtgrXDekc3gNBSj/Y4+4ACkwGXs9qpSnixI0P/DZlhksiWfRvkdqWHR4Ocv+2V+87WY11eWm2+BqSfSyR+PuSluZDwsvyqCFBTj3EXMycdfIMmw5D4E24jGfCogJCsc3fkd1pvc9yDQnTtUHCyXq XQ0zTHbl gICuOWljrz0BCpYt3MCHk1KXfsS9hs4Nppdm1+PCzxYYKfDjMztUjq2J507VvQvFK7P7dsVB6Bjprdy/kqSl9NbqU2Sm5O62iIwoIt4jfrJmbVRHv1EH0ZSJYBn82l+YKTLF8xVqVhbgaT9XsM0QEvuaWHFwOAbP8W8LTI2jdKwMhu+AqQ14KupiaXMri9/VvGXqrZDak09IzMjKfJmIZukAaojfmHiDZ9cqEFMD0fIiVNSY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 15, 2025 at 01:57:09AM +0800, Kairui Song wrote: > @@ -1648,20 +1639,20 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > if (list_empty(&info->swaplist)) > list_add(&info->swaplist, &shmem_swaplist); > > - if (add_to_swap_cache(folio, swap, > - __GFP_HIGH | __GFP_NOMEMALLOC | __GFP_NOWARN, > - NULL) == 0) { > + if (folio_alloc_swap(folio, __GFP_HIGH | __GFP_NOMEMALLOC | __GFP_NOWARN)) { add_to_swap_cache() returns 0 on success or -errno. folio_alloc_swap returns true on success. That would seem to indicate you should change the polarity of this test? Or should folio_alloc_swap() return an errno? Is there value in distinguishing why we couldn't alloc swap (ENOMEM vs ENOSPC, perhaps?)