From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB373C0218F for ; Fri, 31 Jan 2025 14:21:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0982280070; Fri, 31 Jan 2025 09:21:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4553280004; Fri, 31 Jan 2025 09:21:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A70B2280058; Fri, 31 Jan 2025 09:21:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 80C07280004 for ; Fri, 31 Jan 2025 09:21:52 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DECC41A0DAE for ; Fri, 31 Jan 2025 14:21:51 +0000 (UTC) X-FDA: 83067960822.20.689A036 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id EFDC41C000A for ; Fri, 31 Jan 2025 14:21:48 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GcI+YDUi; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738333309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gn6ROdhimfH2SlxaFG9S9wImJavIsJGvPsiITl9Tyxg=; b=liw/UkqGgRNHoR6OMLIQYZt0gXXnqsi4eXHPLkCceIgl5cNI/xHM1hBuAh9RYm7lJejRlb XcvYjXkT5TN8GQqeW4+c5Pss6vK+hRNijts+QOh1mKEEGvbzdfJaM9/n4yaumzfc7WkIFt gR3KbIWPoWrPtHKI36K66InDdPqaT+4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GcI+YDUi; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738333309; a=rsa-sha256; cv=none; b=q3ntG3YYl+/829dvZLilOkCa2QZmbdV6mWldxezu4C8LM/KKj48u3n9NkzW3S8WIlZV2An 2mLGZefO9BmcC6GIzqoRKfbZcVo/bHZckDBd3Zyv90/FhpoAzgIBnF3rWTmZLOTy3TWV66 o+jFTzPtPNn/eV0W0IioefUiHlTFS4Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gn6ROdhimfH2SlxaFG9S9wImJavIsJGvPsiITl9Tyxg=; b=GcI+YDUi42q8wWLAaliLPMiJCL jC3vbx12pAXO2Q4jttDBHLad6PFrI8gKFC3UGsAmD9CGyvTct74eea7pwBUi30YOPI6ohMHsELXRa WTkZKm4FPDerhWo7QwIC3sY8fg06rYWHQ+C/HxXpwV2FZ1kAuXRRCAg1UfEL2sqGk4RbLj6BuD2qa NQw6KWjJxuVhMY3rwD/NiDfpZcCBes6Wo+8nK9PgbM5Tqg7/Fr0zPXey2d2H8QVOORFMWSgoJTKjk /JriUdLVUEli8ufJKmilaBRGPP2FpKCWfAuKk2Ubz4QxzjU62JGSWjoLnj8bempgYL3036hFSGCmw xa5KYQwA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tdrtX-0000000EmeT-34tM; Fri, 31 Jan 2025 14:21:19 +0000 Date: Fri, 31 Jan 2025 14:21:19 +0000 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Chris Wilson , Andrew Morton , Jens Axboe , "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , David Hildenbrand , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCHv3 02/11] drm/i915/gem: Convert __shmem_writeback() to folios Message-ID: References: <20250130100050.1868208-1-kirill.shutemov@linux.intel.com> <20250130100050.1868208-3-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250130100050.1868208-3-kirill.shutemov@linux.intel.com> X-Rspamd-Queue-Id: EFDC41C000A X-Stat-Signature: xt6ha8mdebyhd13fmbqnr7fc43bnicjk X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738333308-212210 X-HE-Meta: U2FsdGVkX1+Q7VgHWC24JRYbfUw69PiwBA4SWLqZN+b7FXxRk+DrLfbOyb0xC7CsEVo40PIT0R/5yXgVMdua2DF7Em8p2w6IvGz1rC12eZUvJa92tbdH/taMWgMUfmuNOo1uF23Z6GbA8aPHBs9t5YVEs8ujxGXiHZPNprCWSsQRx9Pf95G3vFbDAxOvjzeQcZ1jP+1l7ufi76NF050NZLYmQq+0GAud14z9GNG/dKBqeAPMXZK5baYh2lzA/3LbwbhoLVRvqHonpsyvNGIndh1fzlMwR9OluxIpj+zf6lYS573+0OA+yY39bw5DY3VhbmT4GwcambQ8pVjlviSEhIW+afvuFICu7BI/FHE4sIwUxu4ToPle9S34nhX9jMPJhiyhf93CF4mGe+6R5ZWAAjMa4UbT4b3pdIZS0/SEzZLBndpSS9tjUWVi+bTUAE8HaHb74Xaa9G7uqLRlRFWLrfiqpiDerZTmZxjuYJoq4ElLgdCQsCwbNtzLvobmrTsYDCkUO+5tejfuSTK+bpk6S+KL7f7i7le1hMMYnRSodnQFM7ocMHn3RzmyFGcQQPjag8BqjyveP9jks/GHG1vwt50Mn99CfIzANdtqhU7ct2/cXOgD9VM5t1G5YkBhmw6S3NjyLsTYLJokpjnapGbotXSC/4N1QPTHPRj1lJxhSnS0/iUQwTeRNekNBI2oyyTWhiLEcnWWH0otp4/FaZgSTa7qbsg1Aet40gOeBsjVzZWssyVPg7Xvn/kjGb2QPoI79N5lPxsJM8UxAxSZuwoQvugc32p7lavsDKENLmGl9RwvMlyrkSrjzxcYkooFNLivrx+ThsabzOej/3YvtkhoSZ/CBMhKtRQ1Wb/pRt4CgIEcFzlbf3uZUBow4vpVr6J3dKY30Le7B2UPlaPMLJB3PJyzjkpIMdHXn0e9o+ZAgGlNPNTrz91huQ/DPrzZiF151vEYORyj2ik1YiE6Ctv DtK+py0w 1OxbU0o+cM/ZuITynW6fvB3KhvHmp3R0FLastQJYhncaabSFD4cd5Z//bicGwBYBlzIcH6VJ1d/KvLC/lH2S7xZmer2plBzlqPpqHVcTmlHyf0uPcA+CpCW8p8qhEeLLvBtdVyPjAz553s31DLObxTR+ntwGt1fVqVCpHLnlAMZlo062gWnn+i3kPdTXCiTEWbtZ11ruiCdm89I19lK0/JBj7WtK9BDavafgvoqqo7QIqcTN5wpXINg44kh1M5Ss3UEQjB7p/9EqFXmqnMPHgcZC77DDwJVcuY1/uXQRBLWjIwzA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 30, 2025 at 12:00:40PM +0200, Kirill A. Shutemov wrote: > Use folios instead of pages. > > This is preparation for removing PG_reclaim. Well, this is a horrid little function. Rather than iterating just the dirty folios, it iterates all folios, then locks them before checking whether they're dirty. I don't know whether the comments are correct or the code is correct. This comment doesn't match with setting PageReclaim: * Leave mmapings intact (GTT will have been revoked on unbinding, * leaving only CPU mmapings around) and add those pages to the LRU * instead of invoking writeback so they are aged and paged out * as normal. so I wonder if Chris was confused about what PageReclaim actually does. Let's find out if he still remembers what he thought it did!