From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B30C02195 for ; Fri, 31 Jan 2025 13:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 214902800C3; Fri, 31 Jan 2025 08:39:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C3A12800C2; Fri, 31 Jan 2025 08:39:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08B792800C3; Fri, 31 Jan 2025 08:39:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF0132800C2 for ; Fri, 31 Jan 2025 08:39:02 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4B93F80C04 for ; Fri, 31 Jan 2025 13:39:02 +0000 (UTC) X-FDA: 83067852924.08.0E6089E Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf20.hostedemail.com (Postfix) with ESMTP id 2BC621C0013 for ; Fri, 31 Jan 2025 13:38:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gvlCNfkU; spf=none (imf20.hostedemail.com: domain of andi.shyti@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=andi.shyti@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738330740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bELOy2h06piI5RieMP2OsKCXHuAHymiBEKYKTGRJ4uc=; b=HPwifdqnXZvTs3sgftO9YDrzRdxHGb5uqzz57MZesHXOO+JO5ALQYRHYySH8vS+94NJsMd tcrC9PNQ3MiZZ+U/nhRNoC6sQrmYaSXT66iNTdEJRKfhSelgu8mbVOCEDbx0DKa3ZruEfQ dSHGFERb8ogEovhIc71VaEBc372aCqs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gvlCNfkU; spf=none (imf20.hostedemail.com: domain of andi.shyti@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=andi.shyti@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738330740; a=rsa-sha256; cv=none; b=WVJ9sBhFNQ3vfl4CPj0fut7KUDeDR2UPKj4AgZ6WF/zuxdzB4EKalCESgc3Gy49PkPKsSF AN+8GK1nH0RuQucW/8f4TR+FZEvhY9AztrpAWqYCP2Kf4cmMQJb4nRbtFglDE8SnO3qmEe 8Tw10YPWDFjxhD4bdJyEvEzBtAt8VHA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738330741; x=1769866741; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BlkMwqZELP0Gp0TzhdEuSlXKujbDb3xlMAHFMVLsdm8=; b=gvlCNfkUycnS9sK+YWi+fxVckrH9LyKZMeVTsGBEEe3n+23sSrhgX+Db Jb5TiDSLbltaPoZDENUyaSfLljpiGwa/rO2tdiikwthr7IPCPe7/pdVKf MayXoRh287QDPdhmvLw9rfe53/emw46EA9NTU/PN3TBmYRKPnmOYZALKN aI3DJbWNho0YXn8a/goOrraY4TvOWUCmBTt82B/+JlNGo2e4oyaXTDNoQ m44ILd7F8+wwjbRok6MX++i4Gmy3bUBTirbx1Xx5xqFEpps0yPcMy0pYn tFGLgjSVMHU34sPComUFL0bythIpO4xMCu8aZp/iPvtmXrjnArp4EE8pY g==; X-CSE-ConnectionGUID: +H4/6dzTSS2hTLq93j3BZw== X-CSE-MsgGUID: yNG6cd8rRiOB5OTaMcDvUA== X-IronPort-AV: E=McAfee;i="6700,10204,11332"; a="50283197" X-IronPort-AV: E=Sophos;i="6.13,248,1732608000"; d="scan'208";a="50283197" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2025 05:38:58 -0800 X-CSE-ConnectionGUID: yJ4rsx1GRSusxX/Vynh0XQ== X-CSE-MsgGUID: gJj2D0AhTKuPuWC4WLeG5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="146816937" Received: from dprybysh-mobl.ger.corp.intel.com (HELO intel.com) ([10.245.246.175]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2025 05:38:46 -0800 Date: Fri, 31 Jan 2025 14:38:42 +0100 From: Andi Shyti To: "Kirill A. Shutemov" Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe , "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , David Hildenbrand , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCHv3 03/11] drm/i915/gem: Use PG_dropbehind instead of PG_reclaim Message-ID: References: <20250130100050.1868208-1-kirill.shutemov@linux.intel.com> <20250130100050.1868208-4-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250130100050.1868208-4-kirill.shutemov@linux.intel.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2BC621C0013 X-Stat-Signature: 1k4nws3pgmw9thguyhnb51ywz4keub9s X-Rspam-User: X-HE-Tag: 1738330739-420873 X-HE-Meta: U2FsdGVkX1+LDTV/ORjVtvZqdIrQF+205G3WpTcern2AY5WaRH10biitDJI8QpHdLsQa2RwZtdf2tcHdkbXYFJs7HyWgyCIy1LZR/9Q9kYpAGOjam6++wOdZDrRsxOUrPeXn4VkBvXFP0lfIPIZeovXYgbWWoEBRm9qGlzz4lPayO92zTZ0vcvIW2/R/KANaqWOE6YeYsOn9/EnxaoeGecsVioytkjsRlGQyosubiWwQRzK++Bh9DUzBkTNq8tVyK0ysOIPdzygc03L+4coppMQDqORkuSovNptubBgnQ8wR03l56T8cejV9vdShlc8Jfi7IsGlmd0BiBPuXN/MQkqvOtyZeWWr2bktOFBGHLOHk2Zjwex9bgUDhpky35ASE35LJV8dEWf1vJKY7us1PmxZI/9qTBSX7N9UCkK2bFE9681ySPhMbSLX/F2E4ZAPTLltWJpjQr1LX/34ySf24w98f6uxq8xYgGaoQ1vQZwupFCd2qFeblY+jnI/J3yDD2RKoP1S9ArLNzzKsCXJ84i/ePwXNp0XsVGhveDHanPv+DH1rbMrwt7F3D7Ko1ThlswRELwiRutzsuh7a/h9X6+KDWo2VHAQF9kdZw4JcDtVnknVAd8JkpmQEClzc1ipFB+Qtmu3wLysmoa9L32sGSD9fN8EK4mEGD2oQcsd8vm9n/1eLPRg9LDdpffDm1l/69e6p+iUpUCrRkNQQqNtLoKWrSUI2p5hrJpHPZkdg7LNQoWVP4H4/D2lzmMiA2rmbyTdL71bekdgMRNusqUHmLZzQCpMftrM+jDSK3lOzKJv4mvlaCZBJ5DQNSZ7A1N3vIRCKTP50neSw8gcy8F05pQd4vdK4bnPugjYqvYPifHmqwdf4LBsoqpBI2tqrIbGIE6/RW/aFQv1edAUqkxKvVpDORZeyEkK5ellOf1zJGp8szCD5oC5MJSmD+anymLoje6HK5CloFO9q89Wdnz1s GfbWtUqR FG7t+CYNQ2BkXmPN1Nh+4nFJtRVtLnqsJ26J/k8s0dpKhyY6K2WiZBJS7P8zosJMlVsa68oEUPzCFAGPNhcJiba4tRRH/tYovGXvzJLVw1qyxwPp+SostRPEZ5f4qpuVZ9Sl5RiQakc4Op2vc2vpdRhq/eYQGvPluDcvcaR69PntVCqVl8zRnMkIoY8C3qaUc0ehLctg3X8SmT482SOeKSTT+lVTwHxpMT2c++poQVZWPRoU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kirill, On Thu, Jan 30, 2025 at 12:00:41PM +0200, Kirill A. Shutemov wrote: > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > Instead of using folio_set_reclaim(), use folio_set_dropbehind() in > __shmem_writeback() > > It is safe to leave PG_dropbehind on the folio if, for some reason > (bug?), the folio is not in a writeback state after ->writepage(). > In these cases, the kernel had to clear PG_reclaim as it shared a page > flag bit with PG_readahead. > > Signed-off-by: Kirill A. Shutemov > Acked-by: David Hildenbrand Reviewed-by: Andi Shyti Thanks, Andi